jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-27 07:07:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add TURN_ON/OFF ClimateEntityFeature for smartthings (#108979)

Browse Source
This commit is contained in:
G Johansson 2024-01-30 17:56:52 +01:00 committed by GitHub
parent 360697836f
commit cac0d07549
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
homeassistant/components/smartthings/climate.py
View File

@ -173,6 +173,8 @@ class SmartThingsThermostat(SmartThingsEntity, ClimateEntity):
flags = ( flags = (
ClimateEntityFeature.TARGET_TEMPERATURE ClimateEntityFeature.TARGET_TEMPERATURE
| ClimateEntityFeature.TARGET_TEMPERATURE_RANGE | ClimateEntityFeature.TARGET_TEMPERATURE_RANGE
| ClimateEntityFeature.TURN_OFF
| ClimateEntityFeature.TURN_ON
) )
if self._device.get_capability( if self._device.get_capability(
Capability.thermostat_fan_mode, Capability.thermostat Capability.thermostat_fan_mode, Capability.thermostat
@ -353,7 +355,10 @@ class SmartThingsAirConditioner(SmartThingsEntity, ClimateEntity):
def _determine_supported_features(self) -> ClimateEntityFeature: def _determine_supported_features(self) -> ClimateEntityFeature:
features = ( features = (
ClimateEntityFeature.TARGET_TEMPERATURE | ClimateEntityFeature.FAN_MODE ClimateEntityFeature.TARGET_TEMPERATURE
| ClimateEntityFeature.FAN_MODE
| ClimateEntityFeature.TURN_OFF
| ClimateEntityFeature.TURN_ON
) )
if self._device.get_capability(Capability.fan_oscillation_mode): if self._device.get_capability(Capability.fan_oscillation_mode):
features |= ClimateEntityFeature.SWING_MODE features |= ClimateEntityFeature.SWING_MODE

8
tests/components/smartthings/test_climate.py
View File

@ -213,6 +213,8 @@ async def test_legacy_thermostat_entity_state(
== ClimateEntityFeature.FAN_MODE == ClimateEntityFeature.FAN_MODE
| ClimateEntityFeature.TARGET_TEMPERATURE_RANGE | ClimateEntityFeature.TARGET_TEMPERATURE_RANGE
| ClimateEntityFeature.TARGET_TEMPERATURE | ClimateEntityFeature.TARGET_TEMPERATURE
| ClimateEntityFeature.TURN_OFF
| ClimateEntityFeature.TURN_ON
) )
assert state.attributes[ATTR_HVAC_ACTION] == HVACAction.IDLE assert state.attributes[ATTR_HVAC_ACTION] == HVACAction.IDLE
assert sorted(state.attributes[ATTR_HVAC_MODES]) == [ assert sorted(state.attributes[ATTR_HVAC_MODES]) == [
@ -240,6 +242,8 @@ async def test_basic_thermostat_entity_state(
state.attributes[ATTR_SUPPORTED_FEATURES] state.attributes[ATTR_SUPPORTED_FEATURES]
== ClimateEntityFeature.TARGET_TEMPERATURE_RANGE == ClimateEntityFeature.TARGET_TEMPERATURE_RANGE
| ClimateEntityFeature.TARGET_TEMPERATURE | ClimateEntityFeature.TARGET_TEMPERATURE
| ClimateEntityFeature.TURN_OFF
| ClimateEntityFeature.TURN_ON
) )
assert ATTR_HVAC_ACTION not in state.attributes assert ATTR_HVAC_ACTION not in state.attributes
assert sorted(state.attributes[ATTR_HVAC_MODES]) == [ assert sorted(state.attributes[ATTR_HVAC_MODES]) == [
@ -261,6 +265,8 @@ async def test_thermostat_entity_state(hass: HomeAssistant, thermostat) -> None:
== ClimateEntityFeature.FAN_MODE == ClimateEntityFeature.FAN_MODE
| ClimateEntityFeature.TARGET_TEMPERATURE_RANGE | ClimateEntityFeature.TARGET_TEMPERATURE_RANGE
| ClimateEntityFeature.TARGET_TEMPERATURE | ClimateEntityFeature.TARGET_TEMPERATURE
| ClimateEntityFeature.TURN_OFF
| ClimateEntityFeature.TURN_ON
) )
assert state.attributes[ATTR_HVAC_ACTION] == HVACAction.IDLE assert state.attributes[ATTR_HVAC_ACTION] == HVACAction.IDLE
assert sorted(state.attributes[ATTR_HVAC_MODES]) == [ assert sorted(state.attributes[ATTR_HVAC_MODES]) == [
@ -288,6 +294,8 @@ async def test_buggy_thermostat_entity_state(
state.attributes[ATTR_SUPPORTED_FEATURES] state.attributes[ATTR_SUPPORTED_FEATURES]
== ClimateEntityFeature.TARGET_TEMPERATURE_RANGE == ClimateEntityFeature.TARGET_TEMPERATURE_RANGE
| ClimateEntityFeature.TARGET_TEMPERATURE | ClimateEntityFeature.TARGET_TEMPERATURE
| ClimateEntityFeature.TURN_OFF
| ClimateEntityFeature.TURN_ON
) )
assert state.state is STATE_UNKNOWN assert state.state is STATE_UNKNOWN
assert state.attributes[ATTR_TEMPERATURE] is None assert state.attributes[ATTR_TEMPERATURE] is None