jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 13:17:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rfxtrx config validating (#1747)

Browse Source 
* config validation

* Config validation of rfxtrx switch

* Config validation of rfxtrx light

* Config validation of rfxtrx

* Config validation of rfxtrx
This commit is contained in:
Daniel Høyer Iversen 2016-04-09 05:55:31 +02:00 committed by Paulus Schoutsen
parent d6abdc0d4e
commit cac555fc69
6 changed files with 303 additions and 273 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
homeassistant/components/light/rfxtrx.py
View File

@ -13,6 +13,8 @@ DEPENDENCIES = ['rfxtrx']
_LOGGER = logging.getLogger(__name__) _LOGGER = logging.getLogger(__name__)
PLATFORM_SCHEMA = rfxtrx.DEFAULT_SCHEMA
def setup_platform(hass, config, add_devices_callback, discovery_info=None): def setup_platform(hass, config, add_devices_callback, discovery_info=None):
"""Setup the RFXtrx platform.""" """Setup the RFXtrx platform."""

62
homeassistant/components/rfxtrx.py
View File

@ -5,15 +5,19 @@ For more details about this component, please refer to the documentation at
https://home-assistant.io/components/rfxtrx/ https://home-assistant.io/components/rfxtrx/
""" """
import logging import logging
import voluptuous as vol
import homeassistant.helpers.config_validation as cv
from homeassistant.util import slugify from homeassistant.util import slugify
from homeassistant.const import EVENT_HOMEASSISTANT_STOP from homeassistant.const import EVENT_HOMEASSISTANT_STOP
from homeassistant.helpers.entity import Entity from homeassistant.helpers.entity import Entity
from homeassistant.const import ATTR_ENTITY_ID from homeassistant.const import ATTR_ENTITY_ID
REQUIREMENTS = ['pyRFXtrx==0.6.5'] REQUIREMENTS = ['pyRFXtrx==0.6.5']
DOMAIN = "rfxtrx" DOMAIN = "rfxtrx"
ATTR_AUTOMATIC_ADD = 'automatic_add'
ATTR_DEVICE = 'device' ATTR_DEVICE = 'device'
ATTR_DEBUG = 'debug' ATTR_DEBUG = 'debug'
ATTR_STATE = 'state' ATTR_STATE = 'state'
@ -21,8 +25,10 @@ ATTR_NAME = 'name'
ATTR_PACKETID = 'packetid' ATTR_PACKETID = 'packetid'
ATTR_FIREEVENT = 'fire_event' ATTR_FIREEVENT = 'fire_event'
ATTR_DATA_TYPE = 'data_type' ATTR_DATA_TYPE = 'data_type'
ATTR_DUMMY = "dummy" ATTR_DUMMY = 'dummy'
SIGNAL_REPETITIONS = 1 CONF_SIGNAL_REPETITIONS = 'signal_repetitions'
CONF_DEVICES = 'devices'
DEFAULT_SIGNAL_REPETITIONS = 1
EVENT_BUTTON_PRESSED = 'button_pressed' EVENT_BUTTON_PRESSED = 'button_pressed'
@ -32,6 +38,36 @@ _LOGGER = logging.getLogger(__name__)
RFXOBJECT = None RFXOBJECT = None
def _validate_packetid(value):
if get_rfx_object(value):
return value
else:
raise vol.Invalid('invalid packet id for {}'.format(value))
DEVICE_SCHEMA = vol.Schema({
vol.Required(ATTR_NAME): cv.string,
vol.Required(ATTR_PACKETID): _validate_packetid,
vol.Optional(ATTR_FIREEVENT, default=False): cv.boolean,
})
DEFAULT_SCHEMA = vol.Schema({
vol.Required("platform"): DOMAIN,
vol.Required(CONF_DEVICES): {cv.slug: DEVICE_SCHEMA},
vol.Optional(ATTR_AUTOMATIC_ADD, default=False): cv.boolean,
vol.Optional(CONF_SIGNAL_REPETITIONS, default=DEFAULT_SIGNAL_REPETITIONS):
vol.Coerce(int),
})
CONFIG_SCHEMA = vol.Schema({
DOMAIN: vol.Schema({
vol.Required(ATTR_DEVICE): cv.string,
vol.Optional(ATTR_DEBUG, default=False): cv.boolean,
vol.Optional(ATTR_DUMMY, default=False): cv.boolean,
}),
})
def setup(hass, config): def setup(hass, config):
"""Setup the RFXtrx component.""" """Setup the RFXtrx component."""
# Declare the Handle event # Declare the Handle event
@ -56,16 +92,9 @@ def setup(hass, config):
# Init the rfxtrx module. # Init the rfxtrx module.
global RFXOBJECT global RFXOBJECT
if ATTR_DEVICE not in config[DOMAIN]:
_LOGGER.error(
"can not find device parameter in %s YAML configuration section",
DOMAIN
)
return False
device = config[DOMAIN][ATTR_DEVICE] device = config[DOMAIN][ATTR_DEVICE]
debug = config[DOMAIN].get(ATTR_DEBUG, False) debug = config[DOMAIN][ATTR_DEBUG]
dummy_connection = config[DOMAIN].get(ATTR_DUMMY, False) dummy_connection = config[DOMAIN][ATTR_DUMMY]
if dummy_connection: if dummy_connection:
RFXOBJECT =\ RFXOBJECT =\
@ -103,16 +132,16 @@ def get_rfx_object(packetid):
def get_devices_from_config(config, device): def get_devices_from_config(config, device):
"""Read rfxtrx configuration.""" """Read rfxtrx configuration."""
signal_repetitions = config.get('signal_repetitions', SIGNAL_REPETITIONS) signal_repetitions = config[CONF_SIGNAL_REPETITIONS]
devices = [] devices = []
for device_id, entity_info in config.get('devices', {}).items(): for device_id, entity_info in config[CONF_DEVICES].items():
if device_id in RFX_DEVICES: if device_id in RFX_DEVICES:
continue continue
_LOGGER.info("Add %s rfxtrx", entity_info[ATTR_NAME]) _LOGGER.info("Add %s rfxtrx", entity_info[ATTR_NAME])
# Check if i must fire event # Check if i must fire event
fire_event = entity_info.get(ATTR_FIREEVENT, False) fire_event = entity_info[ATTR_FIREEVENT]
datas = {ATTR_STATE: False, ATTR_FIREEVENT: fire_event} datas = {ATTR_STATE: False, ATTR_FIREEVENT: fire_event}
rfxobject = get_rfx_object(entity_info[ATTR_PACKETID]) rfxobject = get_rfx_object(entity_info[ATTR_PACKETID])
@ -127,7 +156,7 @@ def get_new_device(event, config, device):
"""Add entity if not exist and the automatic_add is True.""" """Add entity if not exist and the automatic_add is True."""
device_id = slugify(event.device.id_string.lower()) device_id = slugify(event.device.id_string.lower())
if device_id not in RFX_DEVICES: if device_id not in RFX_DEVICES:
automatic_add = config.get('automatic_add', False) automatic_add = config[ATTR_AUTOMATIC_ADD]
if not automatic_add: if not automatic_add:
return return
@ -140,8 +169,7 @@ def get_new_device(event, config, device):
pkt_id = "".join("{0:02x}".format(x) for x in event.data) pkt_id = "".join("{0:02x}".format(x) for x in event.data)
entity_name = "%s : %s" % (device_id, pkt_id) entity_name = "%s : %s" % (device_id, pkt_id)
datas = {ATTR_STATE: False, ATTR_FIREEVENT: False} datas = {ATTR_STATE: False, ATTR_FIREEVENT: False}
signal_repetitions = config.get('signal_repetitions', signal_repetitions = config[CONF_SIGNAL_REPETITIONS]
SIGNAL_REPETITIONS)
new_device = device(entity_name, event, datas, new_device = device(entity_name, event, datas,
signal_repetitions) signal_repetitions)
RFX_DEVICES[device_id] = new_device RFX_DEVICES[device_id] = new_device

3
homeassistant/components/switch/rfxtrx.py
View File

@ -6,6 +6,7 @@ https://home-assistant.io/components/switch.rfxtrx/
""" """
import logging import logging
import homeassistant.components.rfxtrx as rfxtrx import homeassistant.components.rfxtrx as rfxtrx
from homeassistant.components.switch import SwitchDevice from homeassistant.components.switch import SwitchDevice
@ -13,6 +14,8 @@ DEPENDENCIES = ['rfxtrx']
_LOGGER = logging.getLogger(__name__) _LOGGER = logging.getLogger(__name__)
PLATFORM_SCHEMA = rfxtrx.DEFAULT_SCHEMA
def setup_platform(hass, config, add_devices_callback, discovery_info=None): def setup_platform(hass, config, add_devices_callback, discovery_info=None):
"""Setup the RFXtrx platform.""" """Setup the RFXtrx platform."""

233
tests/components/light/test_rfxtrx.py
View File

@ -1,9 +1,8 @@
"""The tests for the Rfxtrx light platform.""" """The tests for the Rfxtrx light platform."""
import unittest import unittest
from homeassistant.bootstrap import _setup_component
from homeassistant.components import rfxtrx as rfxtrx_core from homeassistant.components import rfxtrx as rfxtrx_core
from homeassistant.components.light import rfxtrx
from unittest.mock import patch
from tests.common import get_test_home_assistant from tests.common import get_test_home_assistant
@ -14,6 +13,7 @@ class TestLightRfxtrx(unittest.TestCase):
def setUp(self): def setUp(self):
"""Setup things to be run when tests are started.""" """Setup things to be run when tests are started."""
self.hass = get_test_home_assistant(0) self.hass = get_test_home_assistant(0)
self.hass.config.components = ['rfxtrx']
def tearDown(self): def tearDown(self):
"""Stop everything that was started.""" """Stop everything that was started."""
@ -23,40 +23,60 @@ class TestLightRfxtrx(unittest.TestCase):
rfxtrx_core.RFXOBJECT.close_connection() rfxtrx_core.RFXOBJECT.close_connection()
self.hass.stop() self.hass.stop()
def test_valid_config(self):
"""Test configuration."""
self.assertTrue(_setup_component(self.hass, 'light', {
'light': {'platform': 'rfxtrx',
'automatic_add': True,
'devices':
{'213c7f216': {
'name': 'Test',
'packetid': '0b1100cd0213c7f210010f51',
rfxtrx_core.ATTR_FIREEVENT: True}}}}))
self.assertTrue(_setup_component(self.hass, 'light', {
'light': {'platform': 'rfxtrx',
'automatic_add': True,
'devices':
{'213c7f216': {
'name': 'Test',
'packetid': '0b1100cd0213c7f210010f51',
'signal_repetitions': 3}}}}))
def test_invalid_config(self):
"""Test configuration."""
self.assertFalse(_setup_component(self.hass, 'light', {
'light': {'platform': 'rfxtrx',
'automatic_add': True,
'invalid_key': 'afda',
'devices':
{'213c7f216': {
'name': 'Test',
'packetid': '0b1100cd0213c7f210010f51',
rfxtrx_core.ATTR_FIREEVENT: True}}}}))
def test_default_config(self): def test_default_config(self):
"""Test with 0 lights.""" """Test with 0 switches."""
config = {'devices': {}} self.assertTrue(_setup_component(self.hass, 'light', {
devices = [] 'light': {'platform': 'rfxtrx',
'devices': {}}}))
self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES))
def add_dev_callback(devs): def test_one_light(self):
"""Add a callback to add devices."""
for dev in devs:
devices.append(dev)
rfxtrx.setup_platform(self.hass, config, add_dev_callback)
self.assertEqual(0, len(devices))
def test_one_sensor(self):
"""Test with 1 light.""" """Test with 1 light."""
config = {'devices': self.assertTrue(_setup_component(self.hass, 'light', {
{'123efab1': { 'light': {'platform': 'rfxtrx',
'name': 'Test', 'devices':
'packetid': '0b1100cd0213c7f210010f51'}}} {'123efab1': {
'name': 'Test',
'packetid': '0b1100cd0213c7f210010f51'}}}}))
import RFXtrx as rfxtrxmod import RFXtrx as rfxtrxmod
rfxtrx_core.RFXOBJECT =\ rfxtrx_core.RFXOBJECT =\
rfxtrxmod.Core("", transport_protocol=rfxtrxmod.DummyTransport) rfxtrxmod.Core("", transport_protocol=rfxtrxmod.DummyTransport)
devices = [] self.assertEqual(1, len(rfxtrx_core.RFX_DEVICES))
entity = rfxtrx_core.RFX_DEVICES['123efab1']
def add_dev_callback(devs):
"""Add a callback to add devices."""
for dev in devs:
devices.append(dev)
rfxtrx.setup_platform(self.hass, config, add_dev_callback)
self.assertEqual(1, len(devices))
entity = devices[0]
self.assertEqual('Test', entity.name) self.assertEqual('Test', entity.name)
self.assertEqual('off', entity.state) self.assertEqual('off', entity.state)
self.assertTrue(entity.assumed_state) self.assertTrue(entity.assumed_state)
@ -65,62 +85,47 @@ class TestLightRfxtrx(unittest.TestCase):
self.assertFalse(entity.should_poll) self.assertFalse(entity.should_poll)
self.assertFalse(entity.is_on) self.assertFalse(entity.is_on)
with patch('homeassistant.components.light.' +
'rfxtrx.RfxtrxLight.update_ha_state', entity.turn_on()
return_value=None):
entity.turn_on()
self.assertTrue(entity.is_on) self.assertTrue(entity.is_on)
self.assertEqual(entity.brightness, 255) self.assertEqual(entity.brightness, 255)
with patch('homeassistant.components.light.' +
'rfxtrx.RfxtrxLight.update_ha_state', entity.turn_off()
return_value=None):
entity.turn_off()
self.assertFalse(entity.is_on) self.assertFalse(entity.is_on)
self.assertEqual(entity.brightness, 0) self.assertEqual(entity.brightness, 0)
with patch('homeassistant.components.light.' +
'rfxtrx.RfxtrxLight.update_ha_state', entity.turn_on(brightness=100)
return_value=None):
entity.turn_on(brightness=100)
self.assertTrue(entity.is_on) self.assertTrue(entity.is_on)
self.assertEqual(entity.brightness, 100) self.assertEqual(entity.brightness, 100)
with patch('homeassistant.components.light.' +
'rfxtrx.RfxtrxLight.update_ha_state', entity.turn_on(brightness=10)
return_value=None):
entity.turn_on(brightness=10)
self.assertTrue(entity.is_on) self.assertTrue(entity.is_on)
self.assertEqual(entity.brightness, 10) self.assertEqual(entity.brightness, 10)
with patch('homeassistant.components.light.' +
'rfxtrx.RfxtrxLight.update_ha_state', entity.turn_on(brightness=255)
return_value=None):
entity.turn_on(brightness=255)
self.assertTrue(entity.is_on) self.assertTrue(entity.is_on)
self.assertEqual(entity.brightness, 255) self.assertEqual(entity.brightness, 255)
def test_several_lights(self): def test_several_lights(self):
"""Test with 3 lights.""" """Test with 3 lights."""
config = {'signal_repetitions': 3, self.assertTrue(_setup_component(self.hass, 'light', {
'devices': 'light': {'platform': 'rfxtrx',
{'123efab1': { 'signal_repetitions': 3,
'name': 'Test', 'devices':
'packetid': '0b1100cd0213c7f230010f71'}, {'123efab1': {
'118cdea2': { 'name': 'Test',
'name': 'Bath', 'packetid': '0b1100cd0213c7f230010f71'},
'packetid': '0b1100100118cdea02010f70'}, '118cdea2': {
'213c7f216': { 'name': 'Bath',
'name': 'Living', 'packetid': '0b1100100118cdea02010f70'},
'packetid': '2b1121cd1213c7f211111f71'}}} '213c7f216': {
devices = [] 'name': 'Living',
'packetid': '0b1100100118cdea02010f70'}}}}))
def add_dev_callback(devs): self.assertEqual(3, len(rfxtrx_core.RFX_DEVICES))
"""Add a callback to add devices."""
for dev in devs:
devices.append(dev)
rfxtrx.setup_platform(self.hass, config, add_dev_callback)
self.assertEqual(3, len(devices))
device_num = 0 device_num = 0
for entity in devices: for id in rfxtrx_core.RFX_DEVICES:
entity = rfxtrx_core.RFX_DEVICES[id]
self.assertEqual(entity.signal_repetitions, 3) self.assertEqual(entity.signal_repetitions, 3)
if entity.name == 'Living': if entity.name == 'Living':
device_num = device_num + 1 device_num = device_num + 1
@ -139,47 +144,33 @@ class TestLightRfxtrx(unittest.TestCase):
def test_discover_light(self): def test_discover_light(self):
"""Test with discovery of lights.""" """Test with discovery of lights."""
config = {'automatic_add': True, 'devices': {}} self.assertTrue(_setup_component(self.hass, 'light', {
devices = [] 'light': {'platform': 'rfxtrx',
'automatic_add': True,
def add_dev_callback(devs): 'devices': {}}}))
"""Add a callback to add devices."""
for dev in devs:
devices.append(dev)
rfxtrx.setup_platform(self.hass, config, add_dev_callback)
event = rfxtrx_core.get_rfx_object('0b11009e00e6116202020070') event = rfxtrx_core.get_rfx_object('0b11009e00e6116202020070')
event.data = bytearray(b'\x0b\x11\x00\x9e\x00\xe6\x11b\x02\x02\x00p') event.data = bytearray(b'\x0b\x11\x00\x9e\x00\xe6\x11b\x02\x02\x00p')
with patch('homeassistant.components.light.' +
'rfxtrx.RfxtrxLight.update_ha_state', rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
return_value=None): entity = rfxtrx_core.RFX_DEVICES['0e611622']
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
entity = devices[0]
self.assertEqual(1, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(1, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(1, len(devices))
self.assertEqual('<Entity 0e611622 : 0b11009e00e6116202020070: on>', self.assertEqual('<Entity 0e611622 : 0b11009e00e6116202020070: on>',
entity.__str__()) entity.__str__())
event = rfxtrx_core.get_rfx_object('0b11009e00e6116201010070') event = rfxtrx_core.get_rfx_object('0b11009e00e6116201010070')
event.data = bytearray(b'\x0b\x11\x00\x9e\x00\xe6\x11b\x01\x01\x00p') event.data = bytearray(b'\x0b\x11\x00\x9e\x00\xe6\x11b\x01\x01\x00p')
with patch('homeassistant.components.light.' +
'rfxtrx.RfxtrxLight.update_ha_state', rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
return_value=None):
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(1, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(1, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(1, len(devices))
event = rfxtrx_core.get_rfx_object('0b1100120118cdea02020070') event = rfxtrx_core.get_rfx_object('0b1100120118cdea02020070')
event.data = bytearray([0x0b, 0x11, 0x00, 0x12, 0x01, 0x18, event.data = bytearray([0x0b, 0x11, 0x00, 0x12, 0x01, 0x18,
0xcd, 0xea, 0x02, 0x02, 0x00, 0x70]) 0xcd, 0xea, 0x02, 0x02, 0x00, 0x70])
with patch('homeassistant.components.light.' +
'rfxtrx.RfxtrxLight.update_ha_state', rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
return_value=None): entity = rfxtrx_core.RFX_DEVICES['118cdea2']
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
entity = devices[1]
self.assertEqual(2, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(2, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(2, len(devices))
self.assertEqual('<Entity 118cdea2 : 0b1100120118cdea02020070: on>', self.assertEqual('<Entity 118cdea2 : 0b1100120118cdea02020070: on>',
entity.__str__()) entity.__str__())
@ -188,75 +179,53 @@ class TestLightRfxtrx(unittest.TestCase):
event.data = bytearray(b'\nR\x08^\x07\x01\x00\xb3\x1b\x02y') event.data = bytearray(b'\nR\x08^\x07\x01\x00\xb3\x1b\x02y')
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event) rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(2, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(2, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(2, len(devices))
# trying to add a swicth # trying to add a swicth
event = rfxtrx_core.get_rfx_object('0b1100100118cdea02010f70') event = rfxtrx_core.get_rfx_object('0b1100100118cdea02010f70')
event.data = bytearray([0x0b, 0x11, 0x00, 0x10, 0x01, 0x18, event.data = bytearray([0x0b, 0x11, 0x00, 0x10, 0x01, 0x18,
0xcd, 0xea, 0x01, 0x01, 0x0f, 0x70]) 0xcd, 0xea, 0x01, 0x01, 0x0f, 0x70])
with patch('homeassistant.components.light.' +
'rfxtrx.RfxtrxLight.update_ha_state', rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
return_value=None):
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(2, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(2, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(2, len(devices))
def test_discover_light_noautoadd(self): def test_discover_light_noautoadd(self):
"""Test with discover of light when auto add is False.""" """Test with discover of light when auto add is False."""
config = {'automatic_add': False, 'devices': {}} self.assertTrue(_setup_component(self.hass, 'light', {
devices = [] 'light': {'platform': 'rfxtrx',
'automatic_add': False,
def add_dev_callback(devs): 'devices': {}}}))
"""Add a callback to add devices."""
for dev in devs:
devices.append(dev)
rfxtrx.setup_platform(self.hass, config, add_dev_callback)
event = rfxtrx_core.get_rfx_object('0b1100120118cdea02020070') event = rfxtrx_core.get_rfx_object('0b1100120118cdea02020070')
event.data = bytearray([0x0b, 0x11, 0x00, 0x12, 0x01, 0x18, event.data = bytearray([0x0b, 0x11, 0x00, 0x12, 0x01, 0x18,
0xcd, 0xea, 0x02, 0x02, 0x00, 0x70]) 0xcd, 0xea, 0x02, 0x02, 0x00, 0x70])
with patch('homeassistant.components.light.' +
'rfxtrx.RfxtrxLight.update_ha_state', rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
return_value=None):
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(0, len(devices))
event = rfxtrx_core.get_rfx_object('0b1100120118cdea02010070') event = rfxtrx_core.get_rfx_object('0b1100120118cdea02010070')
event.data = bytearray([0x0b, 0x11, 0x00, 0x12, 0x01, 0x18, event.data = bytearray([0x0b, 0x11, 0x00, 0x12, 0x01, 0x18,
0xcd, 0xea, 0x02, 0x01, 0x00, 0x70]) 0xcd, 0xea, 0x02, 0x01, 0x00, 0x70])
with patch('homeassistant.components.light.' +
'rfxtrx.RfxtrxLight.update_ha_state', rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
return_value=None):
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(0, len(devices))
event = rfxtrx_core.get_rfx_object('0b1100120118cdea02020070') event = rfxtrx_core.get_rfx_object('0b1100120118cdea02020070')
event.data = bytearray([0x0b, 0x11, 0x00, 0x12, 0x01, 0x18, event.data = bytearray([0x0b, 0x11, 0x00, 0x12, 0x01, 0x18,
0xcd, 0xea, 0x02, 0x02, 0x00, 0x70]) 0xcd, 0xea, 0x02, 0x02, 0x00, 0x70])
with patch('homeassistant.components.light.' +
'rfxtrx.RfxtrxLight.update_ha_state', rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
return_value=None):
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(0, len(devices))
# Trying to add a sensor # Trying to add a sensor
event = rfxtrx_core.get_rfx_object('0a52085e070100b31b0279') event = rfxtrx_core.get_rfx_object('0a52085e070100b31b0279')
event.data = bytearray(b'\nR\x08^\x07\x01\x00\xb3\x1b\x02y') event.data = bytearray(b'\nR\x08^\x07\x01\x00\xb3\x1b\x02y')
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event) rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(0, len(devices))
# Trying to add a switch # Trying to add a switch
event = rfxtrx_core.get_rfx_object('0b1100100118cdea02010f70') event = rfxtrx_core.get_rfx_object('0b1100100118cdea02010f70')
event.data = bytearray([0x0b, 0x11, 0x00, 0x10, 0x01, 0x18, event.data = bytearray([0x0b, 0x11, 0x00, 0x10, 0x01, 0x18,
0xcd, 0xea, 0x01, 0x01, 0x0f, 0x70]) 0xcd, 0xea, 0x01, 0x01, 0x0f, 0x70])
with patch('homeassistant.components.light.' +
'rfxtrx.RfxtrxLight.update_ha_state', rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
return_value=None):
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(0, len(devices))

249
tests/components/switch/test_rfxtrx.py
View File

@ -1,9 +1,8 @@
"""The tests for the Rfxtrx switch platform.""" """The tests for the Rfxtrx switch platform."""
import unittest import unittest
from homeassistant.bootstrap import _setup_component
from homeassistant.components import rfxtrx as rfxtrx_core from homeassistant.components import rfxtrx as rfxtrx_core
from homeassistant.components.switch import rfxtrx
from unittest.mock import patch
from tests.common import get_test_home_assistant from tests.common import get_test_home_assistant
@ -14,6 +13,7 @@ class TestSwitchRfxtrx(unittest.TestCase):
def setUp(self): def setUp(self):
"""Setup things to be run when tests are started.""" """Setup things to be run when tests are started."""
self.hass = get_test_home_assistant(0) self.hass = get_test_home_assistant(0)
self.hass.config.components = ['rfxtrx']
def tearDown(self): def tearDown(self):
"""Stop everything that was started.""" """Stop everything that was started."""
@ -23,40 +23,98 @@ class TestSwitchRfxtrx(unittest.TestCase):
rfxtrx_core.RFXOBJECT.close_connection() rfxtrx_core.RFXOBJECT.close_connection()
self.hass.stop() self.hass.stop()
def test_valid_config(self):
"""Test configuration."""
self.assertTrue(_setup_component(self.hass, 'switch', {
'switch': {'platform': 'rfxtrx',
'automatic_add': True,
'devices':
{'213c7f216': {
'name': 'Test',
'packetid': '0b1100cd0213c7f210010f51',
rfxtrx_core.ATTR_FIREEVENT: True}
}}}))
def test_invalid_config1(self):
self.assertFalse(_setup_component(self.hass, 'switch', {
'switch': {'platform': 'rfxtrx',
'automatic_add': True,
'devices':
{'2FF7f216': {
'name': 'Test',
'packetid': '0b1100cd0213c7f210010f51',
'signal_repetitions': 3}
}}}))
def test_invalid_config2(self):
"""Test configuration."""
self.assertFalse(_setup_component(self.hass, 'switch', {
'switch': {'platform': 'rfxtrx',
'automatic_add': True,
'invalid_key': 'afda',
'devices':
{'213c7f216': {
'name': 'Test',
'packetid': '0b1100cd0213c7f210010f51',
rfxtrx_core.ATTR_FIREEVENT: True}
}}}))
def test_invalid_config3(self):
self.assertFalse(_setup_component(self.hass, 'switch', {
'switch': {'platform': 'rfxtrx',
'automatic_add': True,
'devices':
{'213c7f216': {
'name': 'Test',
'packetid': 'AA1100cd0213c7f210010f51',
rfxtrx_core.ATTR_FIREEVENT: True}
}}}))
def test_invalid_config4(self):
self.assertFalse(_setup_component(self.hass, 'switch', {
'switch': {'platform': 'rfxtrx',
'automatic_add': True,
'devices':
{'AA3c7f216': {
'name': 'Test',
'packetid': '0b1100cd0213c7f210010f51',
rfxtrx_core.ATTR_FIREEVENT: True}
}}}))
def test_invalid_config5(self):
"""Test configuration."""
self.assertFalse(_setup_component(self.hass, 'switch', {
'switch': {'platform': 'rfxtrx',
'automatic_add': True,
'devices':
{'213c7f216': {
'name': 'Test',
rfxtrx_core.ATTR_FIREEVENT: True}
}}}))
def test_default_config(self): def test_default_config(self):
"""Test with 0 switches.""" """Test with 0 switches."""
config = {'devices': {}} self.assertTrue(_setup_component(self.hass, 'switch', {
devices = [] 'switch': {'platform': 'rfxtrx',
'devices':
{}}}))
self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES))
def add_dev_callback(devs): def test_one_switch(self):
"""Add a callback to add devices."""
for dev in devs:
devices.append(dev)
rfxtrx.setup_platform(self.hass, config, add_dev_callback)
self.assertEqual(0, len(devices))
def test_one_sensor(self):
"""Test with 1 switch.""" """Test with 1 switch."""
config = {'devices': self.assertTrue(_setup_component(self.hass, 'switch', {
{'123efab1': { 'switch': {'platform': 'rfxtrx',
'name': 'Test', 'devices':
'packetid': '0b1100cd0213c7f210010f51'}}} {'123efab1': {
'name': 'Test',
'packetid': '0b1100cd0213c7f210010f51'}}}}))
import RFXtrx as rfxtrxmod import RFXtrx as rfxtrxmod
rfxtrx_core.RFXOBJECT =\ rfxtrx_core.RFXOBJECT =\
rfxtrxmod.Core("", transport_protocol=rfxtrxmod.DummyTransport) rfxtrxmod.Core("", transport_protocol=rfxtrxmod.DummyTransport)
devices = [] self.assertEqual(1, len(rfxtrx_core.RFX_DEVICES))
entity = rfxtrx_core.RFX_DEVICES['123efab1']
def add_dev_callback(devs):
"""Add a callback to add devices."""
for dev in devs:
devices.append(dev)
rfxtrx.setup_platform(self.hass, config, add_dev_callback)
self.assertEqual(1, len(devices))
entity = devices[0]
self.assertEqual('Test', entity.name) self.assertEqual('Test', entity.name)
self.assertEqual('off', entity.state) self.assertEqual('off', entity.state)
self.assertTrue(entity.assumed_state) self.assertTrue(entity.assumed_state)
@ -65,42 +123,31 @@ class TestSwitchRfxtrx(unittest.TestCase):
self.assertFalse(entity.should_poll) self.assertFalse(entity.should_poll)
self.assertFalse(entity.is_on) self.assertFalse(entity.is_on)
with patch('homeassistant.components.switch.' + entity.turn_on()
'rfxtrx.RfxtrxSwitch.update_ha_state',
return_value=None):
entity.turn_on()
self.assertTrue(entity.is_on) self.assertTrue(entity.is_on)
with patch('homeassistant.components.switch.' + entity.turn_off()
'rfxtrx.RfxtrxSwitch.update_ha_state',
return_value=None):
entity.turn_off()
self.assertFalse(entity.is_on) self.assertFalse(entity.is_on)
def test_several_switchs(self): def test_several_switches(self):
"""Test with 3 switches.""" """Test with 3 switches."""
config = {'signal_repetitions': 3, self.assertTrue(_setup_component(self.hass, 'switch', {
'devices': 'switch': {'platform': 'rfxtrx',
{'123efab1': { 'signal_repetitions': 3,
'name': 'Test', 'devices':
'packetid': '0b1100cd0213c7f230010f71'}, {'123efab1': {
'118cdea2': { 'name': 'Test',
'name': 'Bath', 'packetid': '0b1100cd0213c7f230010f71'},
'packetid': '0b1100100118cdea02010f70'}, '118cdea2': {
'213c7f216': { 'name': 'Bath',
'name': 'Living', 'packetid': '0b1100100118cdea02010f70'},
'packetid': '2b1121cd1213c7f211111f71'}}} '213c7f216': {
devices = [] 'name': 'Living',
'packetid': '0b1100100118cdea02010f70'}}}}))
def add_dev_callback(devs): self.assertEqual(3, len(rfxtrx_core.RFX_DEVICES))
"""Add a callback to add devices."""
for dev in devs:
devices.append(dev)
rfxtrx.setup_platform(self.hass, config, add_dev_callback)
self.assertEqual(3, len(devices))
device_num = 0 device_num = 0
for entity in devices: for id in rfxtrx_core.RFX_DEVICES:
entity = rfxtrx_core.RFX_DEVICES[id]
self.assertEqual(entity.signal_repetitions, 3) self.assertEqual(entity.signal_repetitions, 3)
if entity.name == 'Living': if entity.name == 'Living':
device_num = device_num + 1 device_num = device_num + 1
@ -119,46 +166,31 @@ class TestSwitchRfxtrx(unittest.TestCase):
def test_discover_switch(self): def test_discover_switch(self):
"""Test with discovery of switches.""" """Test with discovery of switches."""
config = {'automatic_add': True, 'devices': {}} self.assertTrue(_setup_component(self.hass, 'switch', {
devices = [] 'switch': {'platform': 'rfxtrx',
'automatic_add': True,
def add_dev_callback(devs): 'devices': {}}}))
"""Add a callback to add devices."""
for dev in devs:
devices.append(dev)
rfxtrx.setup_platform(self.hass, config, add_dev_callback)
event = rfxtrx_core.get_rfx_object('0b1100100118cdea02010f70') event = rfxtrx_core.get_rfx_object('0b1100100118cdea02010f70')
event.data = bytearray([0x0b, 0x11, 0x00, 0x10, 0x01, 0x18, event.data = bytearray([0x0b, 0x11, 0x00, 0x10, 0x01, 0x18,
0xcd, 0xea, 0x01, 0x01, 0x0f, 0x70]) 0xcd, 0xea, 0x01, 0x01, 0x0f, 0x70])
with patch('homeassistant.components.switch.' +
'rfxtrx.RfxtrxSwitch.update_ha_state', rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
return_value=None): entity = rfxtrx_core.RFX_DEVICES['118cdea2']
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
entity = devices[0]
self.assertEqual(1, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(1, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(1, len(devices))
self.assertEqual('<Entity 118cdea2 : 0b1100100118cdea01010f70: on>', self.assertEqual('<Entity 118cdea2 : 0b1100100118cdea01010f70: on>',
entity.__str__()) entity.__str__())
with patch('homeassistant.components.switch.' + rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
'rfxtrx.RfxtrxSwitch.update_ha_state',
return_value=None):
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(1, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(1, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(1, len(devices))
event = rfxtrx_core.get_rfx_object('0b1100100118cdeb02010f70') event = rfxtrx_core.get_rfx_object('0b1100100118cdeb02010f70')
event.data = bytearray([0x0b, 0x11, 0x00, 0x12, 0x01, 0x18, event.data = bytearray([0x0b, 0x11, 0x00, 0x12, 0x01, 0x18,
0xcd, 0xea, 0x02, 0x00, 0x00, 0x70]) 0xcd, 0xea, 0x02, 0x00, 0x00, 0x70])
with patch('homeassistant.components.switch.' +
'rfxtrx.RfxtrxSwitch.update_ha_state', rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
return_value=None): entity = rfxtrx_core.RFX_DEVICES['118cdeb2']
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
entity = devices[1]
self.assertEqual(2, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(2, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(2, len(devices))
self.assertEqual('<Entity 118cdeb2 : 0b1100120118cdea02000070: on>', self.assertEqual('<Entity 118cdeb2 : 0b1100120118cdea02000070: on>',
entity.__str__()) entity.__str__())
@ -167,72 +199,47 @@ class TestSwitchRfxtrx(unittest.TestCase):
event.data = bytearray(b'\nR\x08^\x07\x01\x00\xb3\x1b\x02y') event.data = bytearray(b'\nR\x08^\x07\x01\x00\xb3\x1b\x02y')
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event) rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(2, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(2, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(2, len(devices))
# Trying to add a light # Trying to add a light
event = rfxtrx_core.get_rfx_object('0b1100100118cdea02010f70') event = rfxtrx_core.get_rfx_object('0b1100100118cdea02010f70')
event.data = bytearray([0x0b, 0x11, 0x11, 0x10, 0x01, 0x18, event.data = bytearray([0x0b, 0x11, 0x11, 0x10, 0x01, 0x18,
0xcd, 0xea, 0x01, 0x02, 0x0f, 0x70]) 0xcd, 0xea, 0x01, 0x02, 0x0f, 0x70])
with patch('homeassistant.components.switch.' + rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
'rfxtrx.RfxtrxSwitch.update_ha_state',
return_value=None):
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(2, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(2, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(2, len(devices))
def test_discover_switch_noautoadd(self): def test_discover_switch_noautoadd(self):
"""Test with discovery of switch when auto add is False.""" """Test with discovery of switch when auto add is False."""
config = {'automatic_add': False, 'devices': {}} self.assertTrue(_setup_component(self.hass, 'switch', {
devices = [] 'switch': {'platform': 'rfxtrx',
'automatic_add': False,
def add_dev_callback(devs): 'devices': {}}}))
"""Add a callback to add devices."""
for dev in devs:
devices.append(dev)
rfxtrx.setup_platform(self.hass, config, add_dev_callback)
event = rfxtrx_core.get_rfx_object('0b1100100118cdea02010f70') event = rfxtrx_core.get_rfx_object('0b1100100118cdea02010f70')
event.data = bytearray([0x0b, 0x11, 0x00, 0x10, 0x01, 0x18, event.data = bytearray([0x0b, 0x11, 0x00, 0x10, 0x01, 0x18,
0xcd, 0xea, 0x01, 0x01, 0x0f, 0x70]) 0xcd, 0xea, 0x01, 0x01, 0x0f, 0x70])
with patch('homeassistant.components.switch.' +
'rfxtrx.RfxtrxSwitch.update_ha_state',
return_value=None):
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(0, len(devices))
with patch('homeassistant.components.switch.' + rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
'rfxtrx.RfxtrxSwitch.update_ha_state', self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES))
return_value=None): self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES))
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(0, len(devices))
event = rfxtrx_core.get_rfx_object('0b1100100118cdeb02010f70') event = rfxtrx_core.get_rfx_object('0b1100100118cdeb02010f70')
event.data = bytearray([0x0b, 0x11, 0x00, 0x12, 0x01, 0x18, event.data = bytearray([0x0b, 0x11, 0x00, 0x12, 0x01, 0x18,
0xcd, 0xea, 0x02, 0x00, 0x00, 0x70]) 0xcd, 0xea, 0x02, 0x00, 0x00, 0x70])
with patch('homeassistant.components.switch.' + rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
'rfxtrx.RfxtrxSwitch.update_ha_state',
return_value=None):
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(0, len(devices))
# Trying to add a sensor # Trying to add a sensor
event = rfxtrx_core.get_rfx_object('0a52085e070100b31b0279') event = rfxtrx_core.get_rfx_object('0a52085e070100b31b0279')
event.data = bytearray(b'\nR\x08^\x07\x01\x00\xb3\x1b\x02y') event.data = bytearray(b'\nR\x08^\x07\x01\x00\xb3\x1b\x02y')
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event) rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(0, len(devices))
# Trying to add a light # Trying to add a light
event = rfxtrx_core.get_rfx_object('0b1100100118cdea02010f70') event = rfxtrx_core.get_rfx_object('0b1100100118cdea02010f70')
event.data = bytearray([0x0b, 0x11, 0x11, 0x10, 0x01, event.data = bytearray([0x0b, 0x11, 0x11, 0x10, 0x01,
0x18, 0xcd, 0xea, 0x01, 0x02, 0x0f, 0x70]) 0x18, 0xcd, 0xea, 0x01, 0x02, 0x0f, 0x70])
with patch('homeassistant.components.switch.' + rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
'rfxtrx.RfxtrxSwitch.update_ha_state',
return_value=None):
rfxtrx_core.RECEIVED_EVT_SUBSCRIBERS[0](event)
self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES)) self.assertEqual(0, len(rfxtrx_core.RFX_DEVICES))
self.assertEqual(0, len(devices))

27
tests/components/test_rfxtrx.py
View File

@ -26,7 +26,7 @@ class TestRFXTRX(unittest.TestCase):
def test_default_config(self): def test_default_config(self):
"""Test configuration.""" """Test configuration."""
self.assertTrue(rfxtrx.setup(self.hass, { self.assertTrue(_setup_component(self.hass, 'rfxtrx', {
'rfxtrx': { 'rfxtrx': {
'device': '/dev/serial/by-id/usb' + 'device': '/dev/serial/by-id/usb' +
'-RFXCOM_RFXtrx433_A1Y0NJGR-if00-port0', '-RFXCOM_RFXtrx433_A1Y0NJGR-if00-port0',
@ -49,12 +49,33 @@ class TestRFXTRX(unittest.TestCase):
self.assertEqual(len(rfxtrx.RFXOBJECT.sensors()), 2) self.assertEqual(len(rfxtrx.RFXOBJECT.sensors()), 2)
self.assertEqual(len(devices), 2) self.assertEqual(len(devices), 2)
def test_config_failing(self): def test_valid_config(self):
"""Test configuration.""" """Test configuration."""
self.assertFalse(rfxtrx.setup(self.hass, { self.assertTrue(_setup_component(self.hass, 'rfxtrx', {
'rfxtrx': {
'device': '/dev/serial/by-id/usb' +
'-RFXCOM_RFXtrx433_A1Y0NJGR-if00-port0',
'dummy': True}}))
self.assertTrue(_setup_component(self.hass, 'rfxtrx', {
'rfxtrx': {
'device': '/dev/serial/by-id/usb' +
'-RFXCOM_RFXtrx433_A1Y0NJGR-if00-port0',
'dummy': True,
'debug': True}}))
def test_invalid_config(self):
"""Test configuration."""
self.assertFalse(_setup_component(self.hass, 'rfxtrx', {
'rfxtrx': {} 'rfxtrx': {}
})) }))
self.assertFalse(_setup_component(self.hass, 'rfxtrx', {
'rfxtrx': {
'device': '/dev/serial/by-id/usb' +
'-RFXCOM_RFXtrx433_A1Y0NJGR-if00-port0',
'invalid_key': True}}))
def test_fire_event(self): def test_fire_event(self):
"""Test fire event.""" """Test fire event."""