jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-22 12:47:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use device class constants for velux cover entity (#36078)

Browse Source 
* Add support for Velux Gates

* Comment expanded and listing sorted alphabetically.

* There are constants in the cover entity integration for the valid device classes. Import and use those here.

* Blank line deleted

* Reformate code because of "CheckFormat" error

* Import only the names we need instead of the whole module

* Reformate code because of "CheckFormat" error

* isort error
This commit is contained in:
mnaggatz 2020-05-25 00:46:31 +02:00 committed by GitHub
parent bd8848e57a
commit cc1951c13d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
homeassistant/components/velux/cover.py
View File

@ -4,6 +4,12 @@ from pyvlx.opening_device import Awning, Blind, GarageDoor, Gate, RollerShutter,
from homeassistant.components.cover import ( from homeassistant.components.cover import (
ATTR_POSITION, ATTR_POSITION,
DEVICE_CLASS_AWNING,
DEVICE_CLASS_BLIND,
DEVICE_CLASS_GARAGE,
DEVICE_CLASS_GATE,
DEVICE_CLASS_SHUTTER,
DEVICE_CLASS_WINDOW,
SUPPORT_CLOSE, SUPPORT_CLOSE,
SUPPORT_OPEN, SUPPORT_OPEN,
SUPPORT_SET_POSITION, SUPPORT_SET_POSITION,
@ -19,7 +25,6 @@ async def async_setup_platform(hass, config, async_add_entities, discovery_info=
"""Set up cover(s) for Velux platform.""" """Set up cover(s) for Velux platform."""
entities = [] entities = []
for node in hass.data[DATA_VELUX].pyvlx.nodes: for node in hass.data[DATA_VELUX].pyvlx.nodes:
if isinstance(node, OpeningDevice): if isinstance(node, OpeningDevice):
entities.append(VeluxCover(node)) entities.append(VeluxCover(node))
async_add_entities(entities) async_add_entities(entities)
@ -75,18 +80,18 @@ class VeluxCover(CoverEntity):
def device_class(self): def device_class(self):
"""Define this cover as either awning, blind, garage, gate, shutter or window.""" """Define this cover as either awning, blind, garage, gate, shutter or window."""
if isinstance(self.node, Awning): if isinstance(self.node, Awning):
return "awning" return DEVICE_CLASS_AWNING
if isinstance(self.node, Blind): if isinstance(self.node, Blind):
return "blind" return DEVICE_CLASS_BLIND
if isinstance(self.node, GarageDoor): if isinstance(self.node, GarageDoor):
return "garage" return DEVICE_CLASS_GARAGE
if isinstance(self.node, Gate): if isinstance(self.node, Gate):
return "gate" return DEVICE_CLASS_GATE
if isinstance(self.node, RollerShutter): if isinstance(self.node, RollerShutter):
return "shutter" return DEVICE_CLASS_SHUTTER
if isinstance(self.node, Window): if isinstance(self.node, Window):
return "window" return DEVICE_CLASS_WINDOW
return "window" return DEVICE_CLASS_WINDOW
@property @property
def is_closed(self): def is_closed(self):