From cc2ce4f4a6f64abe0dc75fb54568682196c9a9fb Mon Sep 17 00:00:00 2001 From: Joost Lekkerkerker Date: Fri, 1 Mar 2024 12:25:34 +0100 Subject: [PATCH] Add icon translations to Flipr (#111540) --- homeassistant/components/flipr/icons.json | 12 ++++++++++++ homeassistant/components/flipr/sensor.py | 3 --- tests/components/flipr/test_sensor.py | 7 ------- 3 files changed, 12 insertions(+), 10 deletions(-) create mode 100644 homeassistant/components/flipr/icons.json diff --git a/homeassistant/components/flipr/icons.json b/homeassistant/components/flipr/icons.json new file mode 100644 index 00000000000..2e55e81e562 --- /dev/null +++ b/homeassistant/components/flipr/icons.json @@ -0,0 +1,12 @@ +{ + "entity": { + "sensor": { + "chlorine": { + "default": "mdi:pool" + }, + "red_ox": { + "default": "mdi:pool" + } + } + } +} diff --git a/homeassistant/components/flipr/sensor.py b/homeassistant/components/flipr/sensor.py index 66078c50c1a..452e5b097e9 100644 --- a/homeassistant/components/flipr/sensor.py +++ b/homeassistant/components/flipr/sensor.py @@ -20,12 +20,10 @@ SENSOR_TYPES: tuple[SensorEntityDescription, ...] = ( key="chlorine", translation_key="chlorine", native_unit_of_measurement=UnitOfElectricPotential.MILLIVOLT, - icon="mdi:pool", state_class=SensorStateClass.MEASUREMENT, ), SensorEntityDescription( key="ph", - icon="mdi:pool", device_class=SensorDeviceClass.PH, state_class=SensorStateClass.MEASUREMENT, ), @@ -45,7 +43,6 @@ SENSOR_TYPES: tuple[SensorEntityDescription, ...] = ( key="red_ox", translation_key="red_ox", native_unit_of_measurement=UnitOfElectricPotential.MILLIVOLT, - icon="mdi:pool", state_class=SensorStateClass.MEASUREMENT, ), SensorEntityDescription( diff --git a/tests/components/flipr/test_sensor.py b/tests/components/flipr/test_sensor.py index 54684722802..339986dd54b 100644 --- a/tests/components/flipr/test_sensor.py +++ b/tests/components/flipr/test_sensor.py @@ -7,7 +7,6 @@ from flipr_api.exceptions import FliprError from homeassistant.components.flipr.const import CONF_FLIPR_ID, DOMAIN from homeassistant.components.sensor import ATTR_STATE_CLASS, SensorStateClass from homeassistant.const import ( - ATTR_ICON, ATTR_UNIT_OF_MEASUREMENT, CONF_EMAIL, CONF_PASSWORD, @@ -61,42 +60,36 @@ async def test_sensors(hass: HomeAssistant, entity_registry: er.EntityRegistry) state = hass.states.get("sensor.flipr_myfliprid_ph") assert state - assert state.attributes.get(ATTR_ICON) == "mdi:pool" assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) is None assert state.attributes.get(ATTR_STATE_CLASS) is SensorStateClass.MEASUREMENT assert state.state == "7.03" state = hass.states.get("sensor.flipr_myfliprid_water_temperature") assert state - assert state.attributes.get(ATTR_ICON) is None assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == UnitOfTemperature.CELSIUS assert state.attributes.get(ATTR_STATE_CLASS) is SensorStateClass.MEASUREMENT assert state.state == "10.5" state = hass.states.get("sensor.flipr_myfliprid_last_measured") assert state - assert state.attributes.get(ATTR_ICON) is None assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) is None assert state.attributes.get(ATTR_STATE_CLASS) is None assert state.state == "2021-02-15T09:10:32+00:00" state = hass.states.get("sensor.flipr_myfliprid_red_ox") assert state - assert state.attributes.get(ATTR_ICON) == "mdi:pool" assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == "mV" assert state.attributes.get(ATTR_STATE_CLASS) is SensorStateClass.MEASUREMENT assert state.state == "657.58" state = hass.states.get("sensor.flipr_myfliprid_chlorine") assert state - assert state.attributes.get(ATTR_ICON) == "mdi:pool" assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == "mV" assert state.attributes.get(ATTR_STATE_CLASS) is SensorStateClass.MEASUREMENT assert state.state == "0.23654886" state = hass.states.get("sensor.flipr_myfliprid_battery") assert state - assert state.attributes.get(ATTR_ICON) is None assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == PERCENTAGE assert state.attributes.get(ATTR_STATE_CLASS) is SensorStateClass.MEASUREMENT assert state.state == "95.0"