From ce86fe47e3337d384c38338dd3fb442f152576a7 Mon Sep 17 00:00:00 2001 From: Rohan Kapoor Date: Sat, 23 Feb 2019 17:24:38 -0800 Subject: [PATCH] Remove the google travel time update service (#21153) --- .../components/sensor/google_travel_time.py | 28 ++++++------------- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git a/homeassistant/components/sensor/google_travel_time.py b/homeassistant/components/sensor/google_travel_time.py index 6c197475653..1f4d8425d6e 100644 --- a/homeassistant/components/sensor/google_travel_time.py +++ b/homeassistant/components/sensor/google_travel_time.py @@ -4,21 +4,21 @@ Support for Google travel time sensors. For more details about this platform, please refer to the documentation at https://home-assistant.io/components/sensor.google_travel_time/ """ +import logging from datetime import datetime from datetime import timedelta -import logging import voluptuous as vol -from homeassistant.components.sensor import DOMAIN, PLATFORM_SCHEMA -from homeassistant.helpers.entity import Entity +import homeassistant.helpers.config_validation as cv +import homeassistant.util.dt as dt_util +from homeassistant.components.sensor import PLATFORM_SCHEMA from homeassistant.const import ( CONF_API_KEY, CONF_NAME, EVENT_HOMEASSISTANT_START, ATTR_LATITUDE, ATTR_LONGITUDE, CONF_MODE) -from homeassistant.util import Throttle -import homeassistant.helpers.config_validation as cv from homeassistant.helpers import location -import homeassistant.util.dt as dt_util +from homeassistant.helpers.entity import Entity +from homeassistant.util import Throttle REQUIREMENTS = ['googlemaps==2.5.1'] @@ -83,18 +83,16 @@ def convert_time_to_utc(timestr): def setup_platform(hass, config, add_entities_callback, discovery_info=None): """Set up the Google travel time platform.""" def run_setup(event): - """Delay the setup until Home Assistant is fully initialized. + """ + Delay the setup until Home Assistant is fully initialized. This allows any entities to be created already """ + hass.data.setdefault(DATA_KEY, []) options = config.get(CONF_OPTIONS) if options.get('units') is None: options['units'] = hass.config.units.name - if DATA_KEY not in hass.data: - hass.data[DATA_KEY] = [] - hass.services.register( - DOMAIN, 'google_travel_sensor_update', update) travel_mode = config.get(CONF_TRAVEL_MODE) mode = options.get(CONF_MODE) @@ -120,14 +118,6 @@ def setup_platform(hass, config, add_entities_callback, discovery_info=None): if sensor.valid_api_connection: add_entities_callback([sensor]) - def update(service): - """Update service for manual updates.""" - entity_id = service.data.get('entity_id') - for sensor in hass.data[DATA_KEY]: - if sensor.entity_id == entity_id: - sensor.update(no_throttle=True) - sensor.schedule_update_ha_state() - # Wait until start event is sent to load this component. hass.bus.listen_once(EVENT_HOMEASSISTANT_START, run_setup)