jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 13:17:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make SimpliSafe integration more resilient to SimpliSafe cloud issues (#31116)

Browse Source 
* Make SimpliSafe integration more resilient to SimpliSafe cloud issues

* Clear emergency refresh token

* Stop listening when appropriate

* Cleanup

* Saving refresh token should happen after all updates

* Code review
This commit is contained in:
Aaron Bach 2020-01-24 21:19:40 -07:00 committed by GitHub
parent 0eee152386
commit cf165cc35f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 32 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
homeassistant/components/simplisafe/__init__.py
View File

@ -307,6 +307,7 @@ class SimpliSafe:
"""Initialize.""" """Initialize."""
self._api = api self._api = api
self._config_entry = config_entry self._config_entry = config_entry
self._emergency_refresh_token_used = False
self._hass = hass self._hass = hass
self.last_event_data = {} self.last_event_data = {}
self.systems = systems self.systems = systems
@ -316,6 +317,28 @@ class SimpliSafe:
try: try:
await system.update() await system.update()
latest_event = await system.get_latest_event() latest_event = await system.get_latest_event()
except InvalidCredentialsError:
# SimpliSafe's cloud is a little shaky. At times, a 500 or 502 will
# seemingly harm simplisafe-python's existing access token _and_ refresh
# token, thus preventing the integration from recovering. However, the
# refresh token stored in the config entry escapes unscathed (again,
# apparently); so, if we detect that we're in such a situation, try a last-
# ditch effort by re-authenticating with the stored token:
if self._emergency_refresh_token_used:
# If we've already tried this, log the error, suggest a HASS restart,
# and stop the time tracker:
_LOGGER.error(
"SimpliSafe authentication disconnected. Please restart HASS."
)
remove_listener = self._hass.data[DOMAIN][DATA_LISTENER].pop(
self._config_entry.entry_id
)
remove_listener()
return
_LOGGER.warning("SimpliSafe cloud error; trying stored refresh token")
self._emergency_refresh_token_used = True
await self._api.refresh_access_token(self._config_entry.data[CONF_TOKEN])
except SimplipyError as err: except SimplipyError as err:
_LOGGER.error( _LOGGER.error(
'SimpliSafe error while updating "%s": %s', system.address, err 'SimpliSafe error while updating "%s": %s', system.address, err
@ -327,10 +350,10 @@ class SimpliSafe:
self.last_event_data[system.system_id] = latest_event self.last_event_data[system.system_id] = latest_event
if self._api.refresh_token_dirty: # If we've reached this point using an emergency refresh token, we're in the
_async_save_refresh_token( # clear and we can discard it:
self._hass, self._config_entry, self._api.refresh_token if self._emergency_refresh_token_used:
) self._emergency_refresh_token_used = False
async def async_update(self): async def async_update(self):
"""Get updated data from SimpliSafe.""" """Get updated data from SimpliSafe."""
@ -338,6 +361,11 @@ class SimpliSafe:
await asyncio.gather(*tasks) await asyncio.gather(*tasks)
if self._api.refresh_token_dirty:
_async_save_refresh_token(
self._hass, self._config_entry, self._api.refresh_token
)
class SimpliSafeEntity(Entity): class SimpliSafeEntity(Entity):
"""Define a base SimpliSafe entity.""" """Define a base SimpliSafe entity."""