jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-21 12:17:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix jewish calendar sensor with language set to english (#17104)

Browse Source 
* Add failing testcase for issue #16830

* Fix for #16830
This commit is contained in:
Tsvi Mostovicz 2018-10-03 19:43:25 +03:00 committed by Fabian Affolter
parent 467a59a6ed
commit cf5f02b347
2 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
homeassistant/components/sensor/jewish_calendar.py
View File

@ -116,10 +116,14 @@ class JewishCalSensor(Entity):
date.get_reading(self.diaspora), hebrew=self._hebrew)
elif self.type == 'holiday_name':
try:
self._state = next(
x.description[self._hebrew].long
description = next(
x.description[self._hebrew]
for x in hdate.htables.HOLIDAYS
if x.index == date.get_holyday())
if not self._hebrew:
self._state = description
else:
self._state = description.long
except StopIteration:
self._state = None
elif self.type == 'holyness':

12
tests/components/sensor/test_jewish_calendar.py
View File

@ -95,6 +95,18 @@ class TestJewishCalenderSensor(unittest.TestCase):
sensor.async_update(), self.hass.loop).result()
self.assertEqual(sensor.state, "א\' ראש השנה")
def test_jewish_calendar_sensor_holiday_name_english(self):
"""Test Jewish calendar sensor date output in hebrew."""
test_time = dt(2018, 9, 10)
sensor = JewishCalSensor(
name='test', language='english', sensor_type='holiday_name',
latitude=self.TEST_LATITUDE, longitude=self.TEST_LONGITUDE,
diaspora=False)
with patch('homeassistant.util.dt.now', return_value=test_time):
run_coroutine_threadsafe(
sensor.async_update(), self.hass.loop).result()
self.assertEqual(sensor.state, "Rosh Hashana I")
def test_jewish_calendar_sensor_holyness(self):
"""Test Jewish calendar sensor date output in hebrew."""
test_time = dt(2018, 9, 10)