jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-24 13:47:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Significantly speed up single use callback dispatchers (#117934)

Browse Source
This commit is contained in:
J. Nick Koston 2024-05-24 11:21:10 -10:00 committed by GitHub
parent 881237189d
commit cf73a47fc0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
homeassistant/helpers/dispatcher.py
View File

@ -9,13 +9,14 @@ from typing import Any, overload
from homeassistant.core import ( from homeassistant.core import (
HassJob, HassJob,
HassJobType,
HomeAssistant, HomeAssistant,
callback, callback,
get_hassjob_callable_job_type, get_hassjob_callable_job_type,
) )
from homeassistant.loader import bind_hass from homeassistant.loader import bind_hass
from homeassistant.util.async_ import run_callback_threadsafe from homeassistant.util.async_ import run_callback_threadsafe
from homeassistant.util.logging import catch_log_exception from homeassistant.util.logging import catch_log_exception, log_exception
# Explicit reexport of 'SignalType' for backwards compatibility # Explicit reexport of 'SignalType' for backwards compatibility
from homeassistant.util.signal_type import SignalType as SignalType # noqa: PLC0414 from homeassistant.util.signal_type import SignalType as SignalType # noqa: PLC0414
@ -167,11 +168,17 @@ def _generate_job[*_Ts](
) -> HassJob[..., Coroutine[Any, Any, None] | None]: ) -> HassJob[..., Coroutine[Any, Any, None] | None]:
"""Generate a HassJob for a signal and target.""" """Generate a HassJob for a signal and target."""
job_type = get_hassjob_callable_job_type(target) job_type = get_hassjob_callable_job_type(target)
name = f"dispatcher {signal}"
if job_type is HassJobType.Callback:
# We will catch exceptions in the callback to avoid
# wrapping the callback since calling wraps() is more
# expensive than the whole dispatcher_send process
return HassJob(target, name, job_type=job_type)
return HassJob( return HassJob(
catch_log_exception( catch_log_exception(
target, partial(_format_err, signal, target), job_type=job_type target, partial(_format_err, signal, target), job_type=job_type
), ),
f"dispatcher {signal}", name,
job_type=job_type, job_type=job_type,
) )
@ -236,4 +243,13 @@ def async_dispatcher_send_internal[*_Ts](
if job is None: if job is None:
job = _generate_job(signal, target) job = _generate_job(signal, target)
target_list[target] = job target_list[target] = job
hass.async_run_hass_job(job, *args) # We do not wrap Callback jobs in catch_log_exception since
# single use dispatchers spend more time wrapping the callback
# than the actual callback takes to run in many cases.
if job.job_type is HassJobType.Callback:
try:
job.target(*args)
except Exception: # noqa: BLE001
log_exception(partial(_format_err, signal, target), *args) # type: ignore[arg-type]
else:
hass.async_run_hass_job(job, *args)