jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-22 20:57:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Convert Hue scenes brightness to 0..255 (#105871)

Browse Source 
Co-authored-by: Franck Nijhof <git@frenck.dev>
This commit is contained in:
Barry vd. Heuvel 2024-07-06 19:04:52 +02:00 committed by GitHub
parent ec536bda3d
commit d113ea8e47
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
homeassistant/components/hue/scene.py
View File

@ -177,6 +177,9 @@ class HueSceneEntity(HueSceneEntityBase):
if action.action.dimming: if action.action.dimming:
brightness = action.action.dimming.brightness brightness = action.action.dimming.brightness
break break
if brightness is not None:
# Hue uses a range of [0, 100] to control brightness.
brightness = round((brightness / 100) * 255)
return { return {
"group_name": self.group.metadata.name, "group_name": self.group.metadata.name,
"group_type": self.group.type.value, "group_type": self.group.type.value,

8
tests/components/hue/test_scene.py
View File

@ -35,7 +35,7 @@ async def test_scene(
assert test_entity.attributes["group_type"] == "zone" assert test_entity.attributes["group_type"] == "zone"
assert test_entity.attributes["name"] == "Dynamic Test Scene" assert test_entity.attributes["name"] == "Dynamic Test Scene"
assert test_entity.attributes["speed"] == 0.6269841194152832 assert test_entity.attributes["speed"] == 0.6269841194152832
assert test_entity.attributes["brightness"] == 46.85 assert test_entity.attributes["brightness"] == 119
assert test_entity.attributes["is_dynamic"] is True assert test_entity.attributes["is_dynamic"] is True
# test (regular) scene for a hue room # test (regular) scene for a hue room
@ -47,7 +47,7 @@ async def test_scene(
assert test_entity.attributes["group_type"] == "room" assert test_entity.attributes["group_type"] == "room"
assert test_entity.attributes["name"] == "Regular Test Scene" assert test_entity.attributes["name"] == "Regular Test Scene"
assert test_entity.attributes["speed"] == 0.5 assert test_entity.attributes["speed"] == 0.5
assert test_entity.attributes["brightness"] == 100.0 assert test_entity.attributes["brightness"] == 255
assert test_entity.attributes["is_dynamic"] is False assert test_entity.attributes["is_dynamic"] is False
# test smart scene # test smart scene
@ -170,7 +170,7 @@ async def test_scene_updates(
assert test_entity is not None assert test_entity is not None
assert test_entity.state == STATE_UNKNOWN assert test_entity.state == STATE_UNKNOWN
assert test_entity.name == "Test Room Mocked Scene" assert test_entity.name == "Test Room Mocked Scene"
assert test_entity.attributes["brightness"] == 65.0 assert test_entity.attributes["brightness"] == 166
# test update # test update
updated_resource = {**FAKE_SCENE} updated_resource = {**FAKE_SCENE}
@ -179,7 +179,7 @@ async def test_scene_updates(
await hass.async_block_till_done() await hass.async_block_till_done()
test_entity = hass.states.get(test_entity_id) test_entity = hass.states.get(test_entity_id)
assert test_entity is not None assert test_entity is not None
assert test_entity.attributes["brightness"] == 35.0 assert test_entity.attributes["brightness"] == 89
# # test entity name changes on group name change # # test entity name changes on group name change
mock_bridge_v2.api.emit_event( mock_bridge_v2.api.emit_event(