From d39784906b26d4322c9ed72f073eb0967f8f6470 Mon Sep 17 00:00:00 2001 From: Louis Matthijssen Date: Sat, 26 Jan 2019 03:13:44 +0100 Subject: [PATCH] Fix HTTP login attempts check triggering too late (#20431) --- homeassistant/components/http/ban.py | 2 +- tests/components/http/test_ban.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/homeassistant/components/http/ban.py b/homeassistant/components/http/ban.py index d6d7168ce6d..0d748c91c66 100644 --- a/homeassistant/components/http/ban.py +++ b/homeassistant/components/http/ban.py @@ -104,7 +104,7 @@ async def process_wrong_login(request): request.app[KEY_FAILED_LOGIN_ATTEMPTS][remote_addr] += 1 - if (request.app[KEY_FAILED_LOGIN_ATTEMPTS][remote_addr] > + if (request.app[KEY_FAILED_LOGIN_ATTEMPTS][remote_addr] >= request.app[KEY_LOGIN_THRESHOLD]): new_ban = IpBan(remote_addr) request.app[KEY_BANNED_IPS].append(new_ban) diff --git a/tests/components/http/test_ban.py b/tests/components/http/test_ban.py index 6624937da8d..954337bb413 100644 --- a/tests/components/http/test_ban.py +++ b/tests/components/http/test_ban.py @@ -71,7 +71,7 @@ async def test_ip_bans_file_creation(hass, aiohttp_client): raise HTTPUnauthorized app.router.add_get('/', unauth_handler) - setup_bans(hass, app, 1) + setup_bans(hass, app, 2) mock_real_ip(app)("200.201.202.204") with patch('homeassistant.components.http.ban.async_load_ip_bans_config',