jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-21 20:27:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use a single session to compile statistics (#88405)

Browse Source 
We had two session_scope contexts in compile_statistics which causes
a commit to happen twice during the compile.
This commit is contained in:
J. Nick Koston 2023-02-18 19:23:47 -06:00 committed by GitHub
parent 3ca9f3c0d5
commit d4376b2041
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 25 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
homeassistant/components/recorder/statistics.py
View File

@ -737,7 +737,10 @@ def compile_statistics(instance: Recorder, start: datetime, fire_events: bool) -
end = start + timedelta(minutes=5) end = start + timedelta(minutes=5)
# Return if we already have 5-minute statistics for the requested period # Return if we already have 5-minute statistics for the requested period
with session_scope(session=instance.get_session()) as session: with session_scope(
session=instance.get_session(),
exception_filter=_filter_unique_constraint_integrity_error(instance),
) as session:
if session.query(StatisticsRuns).filter_by(start=start).first(): if session.query(StatisticsRuns).filter_by(start=start).first():
_LOGGER.debug("Statistics already compiled for %s-%s", start, end) _LOGGER.debug("Statistics already compiled for %s-%s", start, end)
return True return True
@ -763,10 +766,6 @@ def compile_statistics(instance: Recorder, start: datetime, fire_events: bool) -
current_metadata.update(compiled.current_metadata) current_metadata.update(compiled.current_metadata)
# Insert collected statistics in the database # Insert collected statistics in the database
with session_scope(
session=instance.get_session(),
exception_filter=_filter_unique_constraint_integrity_error(instance),
) as session:
for stats in platform_stats: for stats in platform_stats:
metadata_id = _update_or_add_metadata( metadata_id = _update_or_add_metadata(
session, stats["meta"], current_metadata session, stats["meta"], current_metadata