From d44e389844a515b416990a78909d7375c42989cf Mon Sep 17 00:00:00 2001 From: Jonas Fors Lellky Date: Mon, 26 Feb 2024 20:22:25 +0100 Subject: [PATCH] Add hvac_action to flexit_bacnet climate entity (#110498) * Add hvac_action to flexit_bacnet climate entity Also add extra state attributes * Remove extra state attrs * Change hvac action to heating --- homeassistant/components/flexit_bacnet/climate.py | 8 ++++++++ tests/components/flexit_bacnet/conftest.py | 1 + .../components/flexit_bacnet/snapshots/test_climate.ambr | 1 + 3 files changed, 10 insertions(+) diff --git a/homeassistant/components/flexit_bacnet/climate.py b/homeassistant/components/flexit_bacnet/climate.py index e641a9d7e4f..84785720fb2 100644 --- a/homeassistant/components/flexit_bacnet/climate.py +++ b/homeassistant/components/flexit_bacnet/climate.py @@ -15,6 +15,7 @@ from homeassistant.components.climate import ( PRESET_HOME, ClimateEntity, ClimateEntityFeature, + HVACAction, HVACMode, ) from homeassistant.config_entries import ConfigEntry @@ -83,6 +84,13 @@ class FlexitClimateEntity(FlexitEntity, ClimateEntity): """Refresh unit state.""" await self.device.update() + @property + def hvac_action(self) -> HVACAction | None: + """Return current HVAC action.""" + if self.device.electric_heater: + return HVACAction.HEATING + return HVACAction.FAN + @property def current_temperature(self) -> float: """Return the current temperature.""" diff --git a/tests/components/flexit_bacnet/conftest.py b/tests/components/flexit_bacnet/conftest.py index 307dbcfdd71..cfcecebd19b 100644 --- a/tests/components/flexit_bacnet/conftest.py +++ b/tests/components/flexit_bacnet/conftest.py @@ -60,6 +60,7 @@ def mock_flexit_bacnet() -> Generator[AsyncMock, None, None]: flexit_bacnet.heat_exchanger_efficiency = 81 flexit_bacnet.heat_exchanger_speed = 100 flexit_bacnet.air_filter_polluted = False + flexit_bacnet.air_filter_exchange_interval = 8784 flexit_bacnet.electric_heater = True # Mock fan setpoints diff --git a/tests/components/flexit_bacnet/snapshots/test_climate.ambr b/tests/components/flexit_bacnet/snapshots/test_climate.ambr index fc1d844e1ba..6d5ef2251b8 100644 --- a/tests/components/flexit_bacnet/snapshots/test_climate.ambr +++ b/tests/components/flexit_bacnet/snapshots/test_climate.ambr @@ -4,6 +4,7 @@ 'attributes': ReadOnlyDict({ 'current_temperature': 19.0, 'friendly_name': 'Device Name', + 'hvac_action': , 'hvac_modes': list([ , ,