jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 05:07:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure Jewish Calendar returns an iso formatted timestamp (#52722)

Browse Source
This commit is contained in:
Franck Nijhof 2021-07-27 05:23:25 +02:00 committed by GitHub
parent 2b3148296c
commit d4d791e0a1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
homeassistant/components/jewish_calendar/sensor.py
View File

@ -1,4 +1,5 @@
"""Platform to retrieve Jewish calendar information for Home Assistant.""" """Platform to retrieve Jewish calendar information for Home Assistant."""
from datetime import datetime
import logging import logging
import hdate import hdate
@ -51,6 +52,8 @@ class JewishCalendarSensor(SensorEntity):
@property @property
def state(self): def state(self):
"""Return the state of the sensor.""" """Return the state of the sensor."""
if isinstance(self._state, datetime):
return self._state.isoformat()
return self._state return self._state
async def async_update(self): async def async_update(self):
@ -133,7 +136,9 @@ class JewishCalendarTimeSensor(JewishCalendarSensor):
@property @property
def state(self): def state(self):
"""Return the state of the sensor.""" """Return the state of the sensor."""
return dt_util.as_utc(self._state) if self._state is not None else None if self._state is None:
return None
return dt_util.as_utc(self._state).isoformat()
@property @property
def extra_state_attributes(self): def extra_state_attributes(self):

6
tests/components/jewish_calendar/test_sensor.py
View File

@ -188,13 +188,13 @@ async def test_jewish_calendar_sensor(
await hass.async_block_till_done() await hass.async_block_till_done()
result = ( result = (
dt_util.as_utc(result.replace(tzinfo=time_zone)) dt_util.as_utc(result.replace(tzinfo=time_zone)).isoformat()
if isinstance(result, dt) if isinstance(result, dt)
else result else result
) )
sensor_object = hass.states.get(f"sensor.test_{sensor}") sensor_object = hass.states.get(f"sensor.test_{sensor}")
assert sensor_object.state == str(result) assert sensor_object.state == result
if sensor == "holiday": if sensor == "holiday":
assert sensor_object.attributes.get("id") == "rosh_hashana_i" assert sensor_object.attributes.get("id") == "rosh_hashana_i"
@ -544,7 +544,7 @@ async def test_shabbat_times_sensor(
sensor_type = sensor_type.replace(f"{language}_", "") sensor_type = sensor_type.replace(f"{language}_", "")
result_value = ( result_value = (
dt_util.as_utc(result_value) dt_util.as_utc(result_value).isoformat()
if isinstance(result_value, dt) if isinstance(result_value, dt)
else result_value else result_value
) )