From d5ef382fd5f58dc032c86a73fb02c0651b1da991 Mon Sep 17 00:00:00 2001 From: jan iversen Date: Sun, 4 Apr 2021 21:53:52 +0200 Subject: [PATCH] Add modbus write coils (#48676) * Add missing function in class. write_coils was missing. * Remove dead code. The HA configuration secures that CONF_TYPE only contains legal values, so having an empty assert to catch unknown values is dead code. An empty assert is not informative. --- homeassistant/components/modbus/modbus.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/homeassistant/components/modbus/modbus.py b/homeassistant/components/modbus/modbus.py index 099289d8472..0a5422ff6be 100644 --- a/homeassistant/components/modbus/modbus.py +++ b/homeassistant/components/modbus/modbus.py @@ -182,8 +182,6 @@ class ModbusHub: port=self._config_port, timeout=self._config_timeout, ) - else: - assert False # Connect device self.connect() @@ -228,6 +226,12 @@ class ModbusHub: kwargs = {"unit": unit} if unit else {} self._client.write_coil(address, value, **kwargs) + def write_coils(self, unit, address, value): + """Write coil.""" + with self._lock: + kwargs = {"unit": unit} if unit else {} + self._client.write_coils(address, value, **kwargs) + def write_register(self, unit, address, value): """Write register.""" with self._lock: