jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-27 15:17:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reduce startup time for System Bridge integration (#91171)

Browse Source
This commit is contained in:
Aidan Timson 2023-04-12 23:36:51 +01:00 committed by GitHub
parent ea12d7a86f
commit d6c954a909
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
homeassistant/components/system_bridge/__init__.py
View File

@ -53,7 +53,10 @@ SERVICE_SEND_KEYPRESS = "send_keypress"
SERVICE_SEND_TEXT = "send_text" SERVICE_SEND_TEXT = "send_text"
async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool: async def async_setup_entry(
hass: HomeAssistant,
entry: ConfigEntry,
) -> bool:
"""Set up System Bridge from a config entry.""" """Set up System Bridge from a config entry."""
# Check version before initialising # Check version before initialising
@ -64,11 +67,12 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
session=async_get_clientsession(hass), session=async_get_clientsession(hass),
) )
try: try:
if not await version.check_supported(): async with async_timeout.timeout(10):
raise ConfigEntryNotReady( if not await version.check_supported():
"You are not running a supported version of System Bridge. Please" raise ConfigEntryNotReady(
f" update to {SUPPORTED_VERSION} or higher." "You are not running a supported version of System Bridge. Please"
) f" update to {SUPPORTED_VERSION} or higher."
)
except AuthenticationException as exception: except AuthenticationException as exception:
_LOGGER.error("Authentication failed for %s: %s", entry.title, exception) _LOGGER.error("Authentication failed for %s: %s", entry.title, exception)
raise ConfigEntryAuthFailed from exception raise ConfigEntryAuthFailed from exception
@ -87,7 +91,7 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
entry=entry, entry=entry,
) )
try: try:
async with async_timeout.timeout(30): async with async_timeout.timeout(10):
await coordinator.async_get_data(MODULES) await coordinator.async_get_data(MODULES)
except AuthenticationException as exception: except AuthenticationException as exception:
_LOGGER.error("Authentication failed for %s: %s", entry.title, exception) _LOGGER.error("Authentication failed for %s: %s", entry.title, exception)
@ -105,8 +109,8 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
try: try:
# Wait for initial data # Wait for initial data
async with async_timeout.timeout(30): async with async_timeout.timeout(10):
while not coordinator.is_ready(): while not coordinator.is_ready:
_LOGGER.debug( _LOGGER.debug(
"Waiting for initial data from %s (%s)", "Waiting for initial data from %s (%s)",
entry.title, entry.title,

2
homeassistant/components/system_bridge/config_flow.py
View File

@ -55,7 +55,7 @@ async def _validate_input(
data[CONF_API_KEY], data[CONF_API_KEY],
) )
try: try:
async with async_timeout.timeout(30): async with async_timeout.timeout(15):
await websocket_client.connect(session=async_get_clientsession(hass)) await websocket_client.connect(session=async_get_clientsession(hass))
hass.async_create_task(websocket_client.listen()) hass.async_create_task(websocket_client.listen())
response = await websocket_client.get_data(GetData(modules=["system"])) response = await websocket_client.get_data(GetData(modules=["system"]))

5
homeassistant/components/system_bridge/coordinator.py
View File

@ -82,6 +82,7 @@ class SystemBridgeDataUpdateCoordinator(
hass, LOGGER, name=DOMAIN, update_interval=timedelta(seconds=30) hass, LOGGER, name=DOMAIN, update_interval=timedelta(seconds=30)
) )
@property
def is_ready(self) -> bool: def is_ready(self) -> bool:
"""Return if the data is ready.""" """Return if the data is ready."""
if self.data is None: if self.data is None:
@ -157,7 +158,7 @@ class SystemBridgeDataUpdateCoordinator(
self.last_update_success = False self.last_update_success = False
self.async_update_listeners() self.async_update_listeners()
except (ConnectionClosedException, ConnectionResetError) as exception: except (ConnectionClosedException, ConnectionResetError) as exception:
self.logger.info( self.logger.debug(
"Websocket connection closed for %s. Will retry: %s", "Websocket connection closed for %s. Will retry: %s",
self.title, self.title,
exception, exception,
@ -168,7 +169,7 @@ class SystemBridgeDataUpdateCoordinator(
self.last_update_success = False self.last_update_success = False
self.async_update_listeners() self.async_update_listeners()
except ConnectionErrorException as exception: except ConnectionErrorException as exception:
self.logger.warning( self.logger.debug(
"Connection error occurred for %s. Will retry: %s", "Connection error occurred for %s. Will retry: %s",
self.title, self.title,
exception, exception,