From 29e659cf4c4de7b9e25d0f9d8953444e91bc52d6 Mon Sep 17 00:00:00 2001 From: Vincent Van Den Berghe Date: Tue, 13 Mar 2018 22:20:56 +0100 Subject: [PATCH 1/3] Fixed SI units for current consumption --- homeassistant/components/sensor/smappee.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/homeassistant/components/sensor/smappee.py b/homeassistant/components/sensor/smappee.py index 51595d19b1a..c59798d16d7 100644 --- a/homeassistant/components/sensor/smappee.py +++ b/homeassistant/components/sensor/smappee.py @@ -21,17 +21,17 @@ SENSOR_TYPES = { 'active_power': ['Active Power', 'mdi:power-plug', 'local', 'W', 'active_power'], 'current': - ['Current', 'mdi:gauge', 'local', 'Amps', 'current'], + ['Current', 'mdi:gauge', 'local', 'A', 'current'], 'voltage': ['Voltage', 'mdi:gauge', 'local', 'V', 'voltage'], 'active_cosfi': ['Power Factor', 'mdi:gauge', 'local', '%', 'active_cosfi'], 'alwayson_today': - ['Always On Today', 'mdi:gauge', 'remote', 'kW', 'alwaysOn'], + ['Always On Today', 'mdi:gauge', 'remote', 'kWh', 'alwaysOn'], 'solar_today': - ['Solar Today', 'mdi:white-balance-sunny', 'remote', 'kW', 'solar'], + ['Solar Today', 'mdi:white-balance-sunny', 'remote', 'kWh', 'solar'], 'power_today': - ['Power Today', 'mdi:power-plug', 'remote', 'kW', 'consumption'] + ['Power Today', 'mdi:power-plug', 'remote', 'kWh', 'consumption'] } SCAN_INTERVAL = timedelta(seconds=30) From 61a41bb8fcd1cc31b5bc20175c0ab8fc49427b6b Mon Sep 17 00:00:00 2001 From: vandenberghev Date: Mon, 4 Jun 2018 20:08:17 +0200 Subject: [PATCH 2/3] Fix issue #14426: [homeassistant.components.sensor] smappee: Error on device update! https://github.com/home-assistant/home-assistant/issues/14426 --- homeassistant/components/sensor/smappee.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/homeassistant/components/sensor/smappee.py b/homeassistant/components/sensor/smappee.py index 5b84962144d..0263a1266c6 100644 --- a/homeassistant/components/sensor/smappee.py +++ b/homeassistant/components/sensor/smappee.py @@ -189,8 +189,10 @@ class SmappeeSensor(Entity): data = self._smappee.sensor_consumption[self._location_id]\ .get(int(sensor_id)) if data: - consumption = data.get('records')[-1] - _LOGGER.debug("%s (%s) %s", - sensor_name, sensor_id, consumption) - value = consumption.get(self._smappe_name) - self._state = value + tempdata = data.get('records'); + if tempdata: + consumption = tempdata[-1] + _LOGGER.debug("%s (%s) %s", + sensor_name, sensor_id, consumption) + value = consumption.get(self._smappe_name) + self._state = value From 5f65f67f1e5cc6489b34aac7d3dcd75c1cd810d5 Mon Sep 17 00:00:00 2001 From: vandenberghev Date: Sat, 9 Jun 2018 12:37:06 +0200 Subject: [PATCH 3/3] Removed semicolon --- homeassistant/components/sensor/smappee.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/homeassistant/components/sensor/smappee.py b/homeassistant/components/sensor/smappee.py index 0263a1266c6..783c2aad469 100644 --- a/homeassistant/components/sensor/smappee.py +++ b/homeassistant/components/sensor/smappee.py @@ -189,7 +189,7 @@ class SmappeeSensor(Entity): data = self._smappee.sensor_consumption[self._location_id]\ .get(int(sensor_id)) if data: - tempdata = data.get('records'); + tempdata = data.get('records') if tempdata: consumption = tempdata[-1] _LOGGER.debug("%s (%s) %s",