From d811125eb7474209bc01f922183cd8c658fbe94c Mon Sep 17 00:00:00 2001 From: Joost Lekkerkerker Date: Mon, 4 Mar 2024 15:26:41 +0100 Subject: [PATCH] Add icon translations to Rainbird (#112200) * Add icon translations to Rainbird * Add icon translations to Rainbird --- .../components/rainbird/binary_sensor.py | 1 - homeassistant/components/rainbird/calendar.py | 2 +- homeassistant/components/rainbird/icons.json | 28 +++++++++++++++++++ homeassistant/components/rainbird/number.py | 1 - homeassistant/components/rainbird/sensor.py | 1 - .../components/rainbird/test_binary_sensor.py | 1 - tests/components/rainbird/test_calendar.py | 3 -- tests/components/rainbird/test_number.py | 1 - tests/components/rainbird/test_sensor.py | 1 - 9 files changed, 29 insertions(+), 10 deletions(-) create mode 100644 homeassistant/components/rainbird/icons.json diff --git a/homeassistant/components/rainbird/binary_sensor.py b/homeassistant/components/rainbird/binary_sensor.py index 142e8ecc4b8..279b8625f20 100644 --- a/homeassistant/components/rainbird/binary_sensor.py +++ b/homeassistant/components/rainbird/binary_sensor.py @@ -21,7 +21,6 @@ _LOGGER = logging.getLogger(__name__) RAIN_SENSOR_ENTITY_DESCRIPTION = BinarySensorEntityDescription( key="rainsensor", translation_key="rainsensor", - icon="mdi:water", ) diff --git a/homeassistant/components/rainbird/calendar.py b/homeassistant/components/rainbird/calendar.py index 2001a14ac93..85906fa3fe3 100644 --- a/homeassistant/components/rainbird/calendar.py +++ b/homeassistant/components/rainbird/calendar.py @@ -49,7 +49,7 @@ class RainBirdCalendarEntity( _attr_has_entity_name = True _attr_name: str | None = None - _attr_icon = "mdi:sprinkler" + _attr_translation_key = "calendar" def __init__( self, diff --git a/homeassistant/components/rainbird/icons.json b/homeassistant/components/rainbird/icons.json new file mode 100644 index 00000000000..79d2256f184 --- /dev/null +++ b/homeassistant/components/rainbird/icons.json @@ -0,0 +1,28 @@ +{ + "entity": { + "binary_sensor": { + "rainsensor": { + "default": "mdi:water" + } + }, + "calendar": { + "calendar": { + "default": "mdi:sprinkler" + } + }, + "number": { + "rain_delay": { + "default": "mdi:water-off" + } + }, + "sensor": { + "raindelay": { + "default": "mdi:water-off" + } + } + }, + "services": { + "start_irrigation": "mdi:water", + "set_rain_delay": "mdi:water-sync" + } +} diff --git a/homeassistant/components/rainbird/number.py b/homeassistant/components/rainbird/number.py index dd9664222b2..9b7bdd481cb 100644 --- a/homeassistant/components/rainbird/number.py +++ b/homeassistant/components/rainbird/number.py @@ -41,7 +41,6 @@ class RainDelayNumber(CoordinatorEntity[RainbirdUpdateCoordinator], NumberEntity _attr_native_max_value = 14 _attr_native_step = 1 _attr_native_unit_of_measurement = UnitOfTime.DAYS - _attr_icon = "mdi:water-off" _attr_translation_key = "rain_delay" _attr_has_entity_name = True diff --git a/homeassistant/components/rainbird/sensor.py b/homeassistant/components/rainbird/sensor.py index 84bf8cadb7b..9daf0958327 100644 --- a/homeassistant/components/rainbird/sensor.py +++ b/homeassistant/components/rainbird/sensor.py @@ -19,7 +19,6 @@ _LOGGER = logging.getLogger(__name__) RAIN_DELAY_ENTITY_DESCRIPTION = SensorEntityDescription( key="raindelay", translation_key="raindelay", - icon="mdi:water-off", ) diff --git a/tests/components/rainbird/test_binary_sensor.py b/tests/components/rainbird/test_binary_sensor.py index 826a7635c53..77ad640e790 100644 --- a/tests/components/rainbird/test_binary_sensor.py +++ b/tests/components/rainbird/test_binary_sensor.py @@ -53,7 +53,6 @@ async def test_rainsensor( assert rainsensor.state == expected_state assert rainsensor.attributes == { "friendly_name": "Rain Bird Controller Rainsensor", - "icon": "mdi:water", } diff --git a/tests/components/rainbird/test_calendar.py b/tests/components/rainbird/test_calendar.py index 673d32998d5..497a88e4c3c 100644 --- a/tests/components/rainbird/test_calendar.py +++ b/tests/components/rainbird/test_calendar.py @@ -204,7 +204,6 @@ async def test_event_state( "description": "", "location": "", "friendly_name": "Rain Bird Controller", - "icon": "mdi:sprinkler", } assert state.state == expected_state @@ -248,7 +247,6 @@ async def test_no_schedule( assert state.state == "unavailable" assert state.attributes == { "friendly_name": "Rain Bird Controller", - "icon": "mdi:sprinkler", } client = await hass_client() @@ -276,7 +274,6 @@ async def test_program_schedule_disabled( assert state.state == "off" assert state.attributes == { "friendly_name": "Rain Bird Controller", - "icon": "mdi:sprinkler", } diff --git a/tests/components/rainbird/test_number.py b/tests/components/rainbird/test_number.py index b0c1856819e..0830a238fd7 100644 --- a/tests/components/rainbird/test_number.py +++ b/tests/components/rainbird/test_number.py @@ -57,7 +57,6 @@ async def test_number_values( assert raindelay.state == expected_state assert raindelay.attributes == { "friendly_name": "Rain Bird Controller Rain delay", - "icon": "mdi:water-off", "min": 0, "max": 14, "mode": "auto", diff --git a/tests/components/rainbird/test_sensor.py b/tests/components/rainbird/test_sensor.py index ebe852ccf46..730e1d50809 100644 --- a/tests/components/rainbird/test_sensor.py +++ b/tests/components/rainbird/test_sensor.py @@ -51,7 +51,6 @@ async def test_sensors( assert raindelay.state == expected_state assert raindelay.attributes == { "friendly_name": "Rain Bird Controller Raindelay", - "icon": "mdi:water-off", } entity_entry = entity_registry.async_get("sensor.rain_bird_controller_raindelay")