Add reconfigure flow to Nord Pool (#130151)

This commit is contained in:
G Johansson 2024-11-08 19:53:52 +01:00 committed by GitHub
parent e4aaaf10c3
commit da9c73a767
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 123 additions and 1 deletions

View File

@ -90,3 +90,22 @@ class NordpoolConfigFlow(ConfigFlow, domain=DOMAIN):
data_schema=DATA_SCHEMA,
errors=errors,
)
async def async_step_reconfigure(
self, user_input: dict[str, Any] | None = None
) -> ConfigFlowResult:
"""Handle the reconfiguration step."""
errors: dict[str, str] = {}
if user_input:
errors = await test_api(self.hass, user_input)
reconfigure_entry = self._get_reconfigure_entry()
if not errors:
return self.async_update_reload_and_abort(
reconfigure_entry, data_updates=user_input
)
return self.async_show_form(
step_id="reconfigure",
data_schema=DATA_SCHEMA,
errors=errors,
)

View File

@ -1,5 +1,8 @@
{
"config": {
"abort": {
"reconfigure_successful": "[%key:common::config_flow::abort::reconfigure_successful%]"
},
"error": {
"cannot_connect": "[%key:common::config_flow::error::cannot_connect%]",
"no_data": "API connected but the response was empty"
@ -10,6 +13,12 @@
"currency": "Currency",
"areas": "Areas"
}
},
"reconfigure": {
"data": {
"currency": "[%key:component::nordpool::config::step::user::data::currency%]",
"areas": "[%key:component::nordpool::config::step::user::data::areas%]"
}
}
}
},

View File

@ -15,12 +15,15 @@ from pynordpool import (
import pytest
from homeassistant import config_entries
from homeassistant.components.nordpool.const import DOMAIN
from homeassistant.components.nordpool.const import CONF_AREAS, DOMAIN
from homeassistant.const import CONF_CURRENCY
from homeassistant.core import HomeAssistant
from homeassistant.data_entry_flow import FlowResultType
from . import ENTRY_CONFIG
from tests.common import MockConfigEntry
@pytest.mark.freeze_time("2024-11-05T18:00:00+00:00")
async def test_form(hass: HomeAssistant, get_data: DeliveryPeriodData) -> None:
@ -149,3 +152,94 @@ async def test_empty_data(hass: HomeAssistant, get_data: DeliveryPeriodData) ->
assert result["type"] is FlowResultType.CREATE_ENTRY
assert result["title"] == "Nord Pool"
assert result["data"] == {"areas": ["SE3", "SE4"], "currency": "SEK"}
@pytest.mark.freeze_time("2024-11-05T18:00:00+00:00")
async def test_reconfigure(
hass: HomeAssistant,
load_int: MockConfigEntry,
get_data: DeliveryPeriodData,
) -> None:
"""Test reconfiguration."""
result = await load_int.start_reconfigure_flow(hass)
with (
patch(
"homeassistant.components.nordpool.coordinator.NordPoolClient.async_get_delivery_period",
return_value=get_data,
),
):
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
{
CONF_AREAS: ["SE3"],
CONF_CURRENCY: "EUR",
},
)
assert result["type"] is FlowResultType.ABORT
assert result["reason"] == "reconfigure_successful"
assert load_int.data == {
"areas": [
"SE3",
],
"currency": "EUR",
}
@pytest.mark.freeze_time("2024-11-05T18:00:00+00:00")
@pytest.mark.parametrize(
("error_message", "p_error"),
[
(NordPoolConnectionError, "cannot_connect"),
(NordPoolAuthenticationError, "cannot_connect"),
(NordPoolError, "cannot_connect"),
(NordPoolResponseError, "cannot_connect"),
],
)
async def test_reconfigure_cannot_connect(
hass: HomeAssistant,
load_int: MockConfigEntry,
get_data: DeliveryPeriodData,
error_message: Exception,
p_error: str,
) -> None:
"""Test cannot connect error in a reeconfigure flow."""
result = await load_int.start_reconfigure_flow(hass)
with patch(
"homeassistant.components.nordpool.coordinator.NordPoolClient.async_get_delivery_period",
side_effect=error_message,
):
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={
CONF_AREAS: ["SE3"],
CONF_CURRENCY: "EUR",
},
)
assert result["errors"] == {"base": p_error}
with patch(
"homeassistant.components.nordpool.coordinator.NordPoolClient.async_get_delivery_period",
return_value=get_data,
):
result = await hass.config_entries.flow.async_configure(
result["flow_id"],
user_input={
CONF_AREAS: ["SE3"],
CONF_CURRENCY: "EUR",
},
)
assert result["type"] is FlowResultType.ABORT
assert result["reason"] == "reconfigure_successful"
assert load_int.data == {
"areas": [
"SE3",
],
"currency": "EUR",
}