From db5943ad6d7570b4e91c2ebb422b7d151917c11f Mon Sep 17 00:00:00 2001 From: Simone Chemelli Date: Wed, 27 Sep 2023 08:52:46 +0200 Subject: [PATCH] Improve Comelit login with PIN (#100860) * improve login * library bump --- homeassistant/components/comelit/coordinator.py | 12 +++++------- homeassistant/components/comelit/manifest.json | 2 +- requirements_all.txt | 2 +- requirements_test_all.txt | 2 +- 4 files changed, 8 insertions(+), 10 deletions(-) diff --git a/homeassistant/components/comelit/coordinator.py b/homeassistant/components/comelit/coordinator.py index df1d745ce8a..a9c281c10c0 100644 --- a/homeassistant/components/comelit/coordinator.py +++ b/homeassistant/components/comelit/coordinator.py @@ -71,16 +71,14 @@ class ComelitSerialBridge(DataUpdateCoordinator): async def _async_update_data(self) -> dict[str, Any]: """Update router data.""" _LOGGER.debug("Polling Comelit Serial Bridge host: %s", self._host) + logged = False try: logged = await self.api.login() except (asyncio.exceptions.TimeoutError, aiohttp.ClientConnectorError) as err: _LOGGER.warning("Connection error for %s", self._host) raise UpdateFailed(f"Error fetching data: {repr(err)}") from err + finally: + if not logged: + raise ConfigEntryAuthFailed - if not logged: - raise ConfigEntryAuthFailed - - devices_data = await self.api.get_all_devices() - await self.api.logout() - - return devices_data + return await self.api.get_all_devices() diff --git a/homeassistant/components/comelit/manifest.json b/homeassistant/components/comelit/manifest.json index ee876434825..3e49996e50e 100644 --- a/homeassistant/components/comelit/manifest.json +++ b/homeassistant/components/comelit/manifest.json @@ -6,5 +6,5 @@ "documentation": "https://www.home-assistant.io/integrations/comelit", "iot_class": "local_polling", "loggers": ["aiocomelit"], - "requirements": ["aiocomelit==0.0.8"] + "requirements": ["aiocomelit==0.0.9"] } diff --git a/requirements_all.txt b/requirements_all.txt index 5c0e7446c78..45bdb08b7fb 100644 --- a/requirements_all.txt +++ b/requirements_all.txt @@ -210,7 +210,7 @@ aiobafi6==0.9.0 aiobotocore==2.6.0 # homeassistant.components.comelit -aiocomelit==0.0.8 +aiocomelit==0.0.9 # homeassistant.components.dhcp aiodiscover==1.5.1 diff --git a/requirements_test_all.txt b/requirements_test_all.txt index f22ccde834e..e78e1d2658d 100644 --- a/requirements_test_all.txt +++ b/requirements_test_all.txt @@ -191,7 +191,7 @@ aiobafi6==0.9.0 aiobotocore==2.6.0 # homeassistant.components.comelit -aiocomelit==0.0.8 +aiocomelit==0.0.9 # homeassistant.components.dhcp aiodiscover==1.5.1