jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-28 15:47:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

UnifiProtect refactor sensor retrieval in tests to use get_sensor_by_key function (#149398)

Browse Source
This commit is contained in:
Raphael Hehl 2025-07-24 22:11:47 +02:00 committed by GitHub
parent fbe257f997
commit dbc2b1354b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 46 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
tests/components/unifiprotect/test_sensor.py
View File

@ -30,6 +30,7 @@ from homeassistant.components.unifiprotect.sensor import (
NVR_DISABLED_SENSORS, NVR_DISABLED_SENSORS,
NVR_SENSORS, NVR_SENSORS,
SENSE_SENSORS, SENSE_SENSORS,
ProtectSensorEntityDescription,
) )
from homeassistant.const import ( from homeassistant.const import (
ATTR_ATTRIBUTION, ATTR_ATTRIBUTION,
@ -55,6 +56,16 @@ from .utils import (
from tests.common import async_capture_events from tests.common import async_capture_events
def get_sensor_by_key(sensors: tuple, key: str) -> ProtectSensorEntityDescription:
"""Get sensor description by key."""
for sensor in sensors:
if sensor.key == key:
return sensor
raise ValueError(f"Sensor with key '{key}' not found")
# Constants for test slicing (subsets of sensor tuples)
CAMERA_SENSORS_WRITE = CAMERA_SENSORS[:5] CAMERA_SENSORS_WRITE = CAMERA_SENSORS[:5]
SENSE_SENSORS_WRITE = SENSE_SENSORS[:8] SENSE_SENSORS_WRITE = SENSE_SENSORS[:8]
@ -123,7 +134,9 @@ async def test_sensor_setup_sensor(
# BLE signal # BLE signal
unique_id, entity_id = ids_from_device_description( unique_id, entity_id = ids_from_device_description(
Platform.SENSOR, sensor_all, ALL_DEVICES_SENSORS[1] Platform.SENSOR,
sensor_all,
get_sensor_by_key(ALL_DEVICES_SENSORS, "ble_signal"),
) )
entity = entity_registry.async_get(entity_id) entity = entity_registry.async_get(entity_id)
@ -269,7 +282,7 @@ async def test_sensor_nvr_missing_values(
assert_entity_counts(hass, Platform.SENSOR, 12, 9) assert_entity_counts(hass, Platform.SENSOR, 12, 9)
# Uptime # Uptime
description = NVR_SENSORS[0] description = get_sensor_by_key(NVR_SENSORS, "uptime")
unique_id, entity_id = ids_from_device_description( unique_id, entity_id = ids_from_device_description(
Platform.SENSOR, nvr, description Platform.SENSOR, nvr, description
) )
@ -285,8 +298,8 @@ async def test_sensor_nvr_missing_values(
assert state.state == STATE_UNKNOWN assert state.state == STATE_UNKNOWN
assert state.attributes[ATTR_ATTRIBUTION] == DEFAULT_ATTRIBUTION assert state.attributes[ATTR_ATTRIBUTION] == DEFAULT_ATTRIBUTION
# Memory # Recording capacity
description = NVR_SENSORS[8] description = get_sensor_by_key(NVR_SENSORS, "record_capacity")
unique_id, entity_id = ids_from_device_description( unique_id, entity_id = ids_from_device_description(
Platform.SENSOR, nvr, description Platform.SENSOR, nvr, description
) )
@ -300,8 +313,8 @@ async def test_sensor_nvr_missing_values(
assert state.state == "0" assert state.state == "0"
assert state.attributes[ATTR_ATTRIBUTION] == DEFAULT_ATTRIBUTION assert state.attributes[ATTR_ATTRIBUTION] == DEFAULT_ATTRIBUTION
# Memory # Memory utilization
description = NVR_DISABLED_SENSORS[2] description = get_sensor_by_key(NVR_DISABLED_SENSORS, "memory_utilization")
unique_id, entity_id = ids_from_device_description( unique_id, entity_id = ids_from_device_description(
Platform.SENSOR, nvr, description Platform.SENSOR, nvr, description
) )
@ -372,9 +385,9 @@ async def test_sensor_setup_camera(
assert state.state == expected_values[index] assert state.state == expected_values[index]
assert state.attributes[ATTR_ATTRIBUTION] == DEFAULT_ATTRIBUTION assert state.attributes[ATTR_ATTRIBUTION] == DEFAULT_ATTRIBUTION
# Wired signal # Wired signal (phy_rate / link speed)
unique_id, entity_id = ids_from_device_description( unique_id, entity_id = ids_from_device_description(
Platform.SENSOR, doorbell, ALL_DEVICES_SENSORS[2] Platform.SENSOR, doorbell, get_sensor_by_key(ALL_DEVICES_SENSORS, "phy_rate")
) )
entity = entity_registry.async_get(entity_id) entity = entity_registry.async_get(entity_id)
@ -391,7 +404,9 @@ async def test_sensor_setup_camera(
# WiFi signal # WiFi signal
unique_id, entity_id = ids_from_device_description( unique_id, entity_id = ids_from_device_description(
Platform.SENSOR, doorbell, ALL_DEVICES_SENSORS[3] Platform.SENSOR,
doorbell,
get_sensor_by_key(ALL_DEVICES_SENSORS, "wifi_signal"),
) )
entity = entity_registry.async_get(entity_id) entity = entity_registry.async_get(entity_id)
@ -422,7 +437,9 @@ async def test_sensor_setup_camera_with_last_trip_time(
# Last Trip Time # Last Trip Time
unique_id, entity_id = ids_from_device_description( unique_id, entity_id = ids_from_device_description(
Platform.SENSOR, doorbell, MOTION_TRIP_SENSORS[0] Platform.SENSOR,
doorbell,
get_sensor_by_key(MOTION_TRIP_SENSORS, "motion_last_trip_time"),
) )
entity = entity_registry.async_get(entity_id) entity = entity_registry.async_get(entity_id)
@ -447,7 +464,7 @@ async def test_sensor_update_alarm(
assert_entity_counts(hass, Platform.SENSOR, 22, 14) assert_entity_counts(hass, Platform.SENSOR, 22, 14)
_, entity_id = ids_from_device_description( _, entity_id = ids_from_device_description(
Platform.SENSOR, sensor_all, SENSE_SENSORS_WRITE[4] Platform.SENSOR, sensor_all, get_sensor_by_key(SENSE_SENSORS, "alarm_sound")
) )
event_metadata = EventMetadata(sensor_id=sensor_all.id, alarm_type="smoke") event_metadata = EventMetadata(sensor_id=sensor_all.id, alarm_type="smoke")
@ -498,7 +515,9 @@ async def test_sensor_update_alarm_with_last_trip_time(
# Last Trip Time # Last Trip Time
unique_id, entity_id = ids_from_device_description( unique_id, entity_id = ids_from_device_description(
Platform.SENSOR, sensor_all, SENSE_SENSORS_WRITE[-3] Platform.SENSOR,
sensor_all,
get_sensor_by_key(SENSE_SENSORS, "door_last_trip_time"),
) )
entity = entity_registry.async_get(entity_id) entity = entity_registry.async_get(entity_id)
@ -529,7 +548,9 @@ async def test_camera_update_license_plate(
assert_entity_counts(hass, Platform.SENSOR, 23, 13) assert_entity_counts(hass, Platform.SENSOR, 23, 13)
_, entity_id = ids_from_device_description( _, entity_id = ids_from_device_description(
Platform.SENSOR, camera, LICENSE_PLATE_EVENT_SENSORS[0] Platform.SENSOR,
camera,
get_sensor_by_key(LICENSE_PLATE_EVENT_SENSORS, "smart_obj_licenseplate"),
) )
event_metadata = EventMetadata( event_metadata = EventMetadata(
@ -644,7 +665,9 @@ async def test_camera_update_license_plate_changes_number_during_detect(
assert_entity_counts(hass, Platform.SENSOR, 23, 13) assert_entity_counts(hass, Platform.SENSOR, 23, 13)
_, entity_id = ids_from_device_description( _, entity_id = ids_from_device_description(
Platform.SENSOR, camera, LICENSE_PLATE_EVENT_SENSORS[0] Platform.SENSOR,
camera,
get_sensor_by_key(LICENSE_PLATE_EVENT_SENSORS, "smart_obj_licenseplate"),
) )
event_metadata = EventMetadata( event_metadata = EventMetadata(
@ -731,7 +754,9 @@ async def test_camera_update_license_plate_multiple_updates(
assert_entity_counts(hass, Platform.SENSOR, 23, 13) assert_entity_counts(hass, Platform.SENSOR, 23, 13)
_, entity_id = ids_from_device_description( _, entity_id = ids_from_device_description(
Platform.SENSOR, camera, LICENSE_PLATE_EVENT_SENSORS[0] Platform.SENSOR,
camera,
get_sensor_by_key(LICENSE_PLATE_EVENT_SENSORS, "smart_obj_licenseplate"),
) )
event_metadata = EventMetadata( event_metadata = EventMetadata(
@ -854,7 +879,9 @@ async def test_camera_update_license_no_dupes(
assert_entity_counts(hass, Platform.SENSOR, 23, 13) assert_entity_counts(hass, Platform.SENSOR, 23, 13)
_, entity_id = ids_from_device_description( _, entity_id = ids_from_device_description(
Platform.SENSOR, camera, LICENSE_PLATE_EVENT_SENSORS[0] Platform.SENSOR,
camera,
get_sensor_by_key(LICENSE_PLATE_EVENT_SENSORS, "smart_obj_licenseplate"),
) )
event_metadata = EventMetadata( event_metadata = EventMetadata(
@ -946,6 +973,8 @@ async def test_sensor_precision(
assert_entity_counts(hass, Platform.SENSOR, 22, 14) assert_entity_counts(hass, Platform.SENSOR, 22, 14)
nvr: NVR = ufp.api.bootstrap.nvr nvr: NVR = ufp.api.bootstrap.nvr
_, entity_id = ids_from_device_description(Platform.SENSOR, nvr, NVR_SENSORS[6]) _, entity_id = ids_from_device_description(
Platform.SENSOR, nvr, get_sensor_by_key(NVR_SENSORS, "resolution_4K")
)
assert hass.states.get(entity_id).state == "17.49" assert hass.states.get(entity_id).state == "17.49"