Fix dangerous-default-value in nest tests (#119561)

* Fix dangerous-default-value in nest tests

* Adjust

* Adjust
This commit is contained in:
epenet 2024-06-13 08:32:55 +02:00 committed by GitHub
parent dbd3147c9b
commit dda6ccccd2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 3 deletions

View File

@ -1,5 +1,7 @@
"""The tests for Nest device triggers.""" """The tests for Nest device triggers."""
from typing import Any
from google_nest_sdm.event import EventMessage from google_nest_sdm.event import EventMessage
import pytest import pytest
from pytest_unordered import unordered from pytest_unordered import unordered
@ -30,7 +32,9 @@ def platforms() -> list[str]:
return ["camera"] return ["camera"]
def make_camera(device_id, name=DEVICE_NAME, traits={}): def make_camera(
device_id, name: str = DEVICE_NAME, *, traits: dict[str, Any]
) -> dict[str, Any]:
"""Create a nest camera.""" """Create a nest camera."""
traits = traits.copy() traits = traits.copy()
traits.update( traits.update(

View File

@ -53,7 +53,7 @@ def device_traits() -> list[str]:
@pytest.fixture(autouse=True) @pytest.fixture(autouse=True)
def device( def device(
device_type: str, device_traits: dict[str, Any], create_device: CreateDevice device_type: str, device_traits: list[str], create_device: CreateDevice
) -> None: ) -> None:
"""Fixture to create a device under test.""" """Fixture to create a device under test."""
return create_device.create( return create_device.create(
@ -70,7 +70,7 @@ def event_view(d: Mapping[str, Any]) -> Mapping[str, Any]:
return {key: value for key, value in d.items() if key in EVENT_KEYS} return {key: value for key, value in d.items() if key in EVENT_KEYS}
def create_device_traits(event_traits=[]): def create_device_traits(event_traits: list[str]) -> dict[str, Any]:
"""Create fake traits for a device.""" """Create fake traits for a device."""
result = { result = {
"sdm.devices.traits.Info": { "sdm.devices.traits.Info": {