From ddb71a85b3fff393143e448519ed531b091ef06a Mon Sep 17 00:00:00 2001 From: Nathan Spencer Date: Wed, 29 Jan 2025 03:58:14 -0700 Subject: [PATCH] Update quality scale for litterrobot (#136764) --- .../components/litterrobot/manifest.json | 1 + .../components/litterrobot/quality_scale.yaml | 44 ++++--------------- script/hassfest/quality_scale.py | 1 - 3 files changed, 10 insertions(+), 36 deletions(-) diff --git a/homeassistant/components/litterrobot/manifest.json b/homeassistant/components/litterrobot/manifest.json index 4f1deb9a567..f7563296711 100644 --- a/homeassistant/components/litterrobot/manifest.json +++ b/homeassistant/components/litterrobot/manifest.json @@ -12,5 +12,6 @@ "integration_type": "hub", "iot_class": "cloud_push", "loggers": ["pylitterbot"], + "quality_scale": "bronze", "requirements": ["pylitterbot==2024.0.0"] } diff --git a/homeassistant/components/litterrobot/quality_scale.yaml b/homeassistant/components/litterrobot/quality_scale.yaml index d5f943943bc..82f01f64d18 100644 --- a/homeassistant/components/litterrobot/quality_scale.yaml +++ b/homeassistant/components/litterrobot/quality_scale.yaml @@ -1,40 +1,20 @@ rules: - # Adjust platform files for consistent flow: - # [entity description classes] - # [entity descriptions] - # [async_setup_entry] - # [entity classes]) - # Remove RequiredKeyMixins and add kw_only to classes - # Wrap multiline lambdas in parenthesis - # Extend entity description in switch.py to use value_fn instead of getattr - # Deprecate extra state attributes in vacuum.py # Bronze - action-setup: - status: todo - comment: | - Action async_set_sleep_mode is currently setup in the vacuum platform + action-setup: done appropriate-polling: status: done comment: | Primarily relies on push data, but polls every 5 minutes for missed updates brands: done - common-modules: - status: todo - comment: | - hub.py should be renamed to coordinator.py and updated accordingly - Also should not need to return bool (never used) + common-modules: done config-flow-test-coverage: done config-flow: done dependency-transparency: done - docs-actions: - status: todo - comment: Can be finished after async_set_sleep_mode is moved to async_setup + docs-actions: done docs-high-level-description: done - docs-installation-instructions: todo - docs-removal-instructions: todo - entity-event-setup: - status: todo - comment: Do we need to subscribe to both the coordinator and robot itself? + docs-installation-instructions: done + docs-removal-instructions: done + entity-event-setup: done entity-unique-id: done has-entity-name: done runtime-data: done @@ -61,9 +41,7 @@ rules: Other fields can be moved to const.py. Consider snapshots and testing data updates # Gold - devices: - status: done - comment: Currently uses the device_info property, could be moved to _attr_device_info + devices: done diagnostics: todo discovery-update-info: status: done @@ -81,16 +59,12 @@ rules: dynamic-devices: todo entity-category: done entity-device-class: done - entity-disabled-by-default: - status: todo - comment: Check if we should disable any entities by default + entity-disabled-by-default: done entity-translations: status: todo comment: Make sure all translated states are in sentence case exception-translations: todo - icon-translations: - status: todo - comment: BRIGHTNESS_LEVEL_ICON_MAP should be migrated to icons.json + icon-translations: done reconfiguration-flow: todo repair-issues: status: done diff --git a/script/hassfest/quality_scale.py b/script/hassfest/quality_scale.py index 3eedc43f613..72c1cfae219 100644 --- a/script/hassfest/quality_scale.py +++ b/script/hassfest/quality_scale.py @@ -1671,7 +1671,6 @@ INTEGRATIONS_WITHOUT_SCALE = [ "linux_battery", "lirc", "litejet", - "litterrobot", "livisi", "llamalab_automate", "local_calendar",