From dee47d50ecf4f0e80a127d624027c1688d34b504 Mon Sep 17 00:00:00 2001 From: Chris Jones Date: Mon, 2 Apr 2018 01:37:03 +1000 Subject: [PATCH] Use 0/1 for raspberry pi cover GPIO writes rather than true/false (#13610) * Use 0/1 for GPIO writes rather than true/false GPIO pins don't appear to respond to true/false writes, and this is reflected in code elsewhere. For example, in `\components\switch\rpio_gpio.py` the following code is used: ``` def turn_on(self, **kwargs): """Turn the device on.""" rpi_gpio.write_output(self._port, 0 if self._invert_logic else 1) self._state = True self.schedule_update_ha_state() ``` This code works. Hence this PR uses 0/1 in the raspberry pi GPIO cover, instead of true/false. * Update rpi_gpio.py --- homeassistant/components/cover/rpi_gpio.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/homeassistant/components/cover/rpi_gpio.py b/homeassistant/components/cover/rpi_gpio.py index 77cd0b0f7e2..49666139330 100644 --- a/homeassistant/components/cover/rpi_gpio.py +++ b/homeassistant/components/cover/rpi_gpio.py @@ -87,7 +87,7 @@ class RPiGPIOCover(CoverDevice): self._invert_relay = invert_relay rpi_gpio.setup_output(self._relay_pin) rpi_gpio.setup_input(self._state_pin, self._state_pull_mode) - rpi_gpio.write_output(self._relay_pin, not self._invert_relay) + rpi_gpio.write_output(self._relay_pin, 0 if self._invert_relay else 1) @property def name(self): @@ -105,9 +105,9 @@ class RPiGPIOCover(CoverDevice): def _trigger(self): """Trigger the cover.""" - rpi_gpio.write_output(self._relay_pin, self._invert_relay) + rpi_gpio.write_output(self._relay_pin, 1 if self._invert_relay else 0) sleep(self._relay_time) - rpi_gpio.write_output(self._relay_pin, not self._invert_relay) + rpi_gpio.write_output(self._relay_pin, 0 if self._invert_relay else 1) def close_cover(self, **kwargs): """Close the cover."""