jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-16 09:47:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Unifiprotect: add error message if the get_user_keyring_info permissions are not sufficient (#133841)

Browse Source
This commit is contained in:
Raphael Hehl 2024-12-22 23:58:13 +01:00 committed by GitHub
parent 8ab936b87c
commit df26166047
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 32 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
homeassistant/components/unifiprotect/services.py
View File

@ -236,6 +236,9 @@ async def get_user_keyring_info(call: ServiceCall) -> ServiceResponse:
"""Get the user keyring info.""" """Get the user keyring info."""
camera = _async_get_ufp_camera(call) camera = _async_get_ufp_camera(call)
ulp_users = camera.api.bootstrap.ulp_users.as_list() ulp_users = camera.api.bootstrap.ulp_users.as_list()
if not ulp_users:
raise HomeAssistantError("No users found, please check Protect permissions.")
user_keyrings: list[JsonValueType] = [ user_keyrings: list[JsonValueType] = [
{ {
KEYRINGS_USER_FULL_NAME: user.full_name, KEYRINGS_USER_FULL_NAME: user.full_name,

31
tests/components/unifiprotect/test_services.py
View File

@ -262,13 +262,13 @@ async def test_remove_privacy_zone(
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_get_doorbell_user( async def get_user_keyring_info(
hass: HomeAssistant, hass: HomeAssistant,
entity_registry: er.EntityRegistry, entity_registry: er.EntityRegistry,
ufp: MockUFPFixture, ufp: MockUFPFixture,
doorbell: Camera, doorbell: Camera,
) -> None: ) -> None:
"""Test get_doorbell_user service.""" """Test get_user_keyring_info service."""
ulp_user = Mock(full_name="Test User", status="active", ulp_id="user_ulp_id") ulp_user = Mock(full_name="Test User", status="active", ulp_id="user_ulp_id")
keyring = Mock( keyring = Mock(
@ -315,3 +315,30 @@ async def test_get_doorbell_user(
}, },
], ],
} }
async def test_get_user_keyring_info_no_users(
hass: HomeAssistant,
entity_registry: er.EntityRegistry,
ufp: MockUFPFixture,
doorbell: Camera,
) -> None:
"""Test get_user_keyring_info service with no users."""
ufp.api.bootstrap.ulp_users.as_list = Mock(return_value=[])
ufp.api.bootstrap.keyrings.as_list = Mock(return_value=[])
await init_entry(hass, ufp, [doorbell])
camera_entry = entity_registry.async_get("binary_sensor.test_camera_doorbell")
with pytest.raises(
HomeAssistantError, match="No users found, please check Protect permissions."
):
await hass.services.async_call(
DOMAIN,
SERVICE_GET_USER_KEYRING_INFO,
{ATTR_DEVICE_ID: camera_entry.device_id},
blocking=True,
return_response=True,
)