jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-24 05:37:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix SmartThings diagnostics (#139447)

Browse Source
This commit is contained in:
Joost Lekkerkerker 2025-02-27 18:39:18 +01:00 committed by Bram Kragten
parent d8a259044f
commit df4e5a54e3
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
homeassistant/components/smartthings/diagnostics.py
View File

@ -21,25 +21,24 @@ async def async_get_device_diagnostics(
hass: HomeAssistant, entry: SmartThingsConfigEntry, device: DeviceEntry hass: HomeAssistant, entry: SmartThingsConfigEntry, device: DeviceEntry
) -> dict[str, Any]: ) -> dict[str, Any]:
"""Return diagnostics for a device entry.""" """Return diagnostics for a device entry."""
client = entry.runtime_data.client
device_id = next( device_id = next(
identifier for identifier in device.identifiers if identifier[0] == DOMAIN identifier for identifier in device.identifiers if identifier[0] == DOMAIN
)[0] )[1]
device_status = await client.get_device_status(device_id)
events: list[DeviceEvent] = [] events: list[DeviceEvent] = []
def register_event(event: DeviceEvent) -> None: def register_event(event: DeviceEvent) -> None:
events.append(event) events.append(event)
client = entry.runtime_data.client
listener = client.add_device_event_listener(device_id, register_event) listener = client.add_device_event_listener(device_id, register_event)
await asyncio.sleep(EVENT_WAIT_TIME) await asyncio.sleep(EVENT_WAIT_TIME)
listener() listener()
device_status = await client.get_device_status(device_id)
status: dict[str, Any] = {} status: dict[str, Any] = {}
for component, capabilities in device_status.items(): for component, capabilities in device_status.items():
status[component] = {} status[component] = {}

5
tests/components/smartthings/test_diagnostics.py
View File

@ -34,6 +34,8 @@ async def test_device(
identifiers={(DOMAIN, "96a5ef74-5832-a84b-f1f7-ca799957065d")} identifiers={(DOMAIN, "96a5ef74-5832-a84b-f1f7-ca799957065d")}
) )
mock_smartthings.get_device_status.reset_mock()
with patch("homeassistant.components.smartthings.diagnostics.EVENT_WAIT_TIME", 0.1): with patch("homeassistant.components.smartthings.diagnostics.EVENT_WAIT_TIME", 0.1):
diag = await get_diagnostics_for_device( diag = await get_diagnostics_for_device(
hass, hass_client, mock_config_entry, device hass, hass_client, mock_config_entry, device
@ -42,3 +44,6 @@ async def test_device(
assert diag == snapshot( assert diag == snapshot(
exclude=props("last_changed", "last_reported", "last_updated") exclude=props("last_changed", "last_reported", "last_updated")
) )
mock_smartthings.get_device_status.assert_called_once_with(
"96a5ef74-5832-a84b-f1f7-ca799957065d"
)