jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-24 13:47:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve logging for selected options in Onkyo (#139279)

Browse Source 
Different error for not selected option
This commit is contained in:
Artur Pragacz 2025-02-26 15:51:16 +01:00 committed by GitHub
parent 2826198d5d
commit e09b40c2bd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 30 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
homeassistant/components/onkyo/media_player.py
View File

@ -398,6 +398,7 @@ class OnkyoMediaPlayer(MediaPlayerEntity):
self._volume_resolution = volume_resolution self._volume_resolution = volume_resolution
self._max_volume = max_volume self._max_volume = max_volume
self._options_sources = sources
self._source_lib_mapping = _input_source_lib_mappings(zone) self._source_lib_mapping = _input_source_lib_mappings(zone)
self._rev_source_lib_mapping = _rev_input_source_lib_mappings(zone) self._rev_source_lib_mapping = _rev_input_source_lib_mappings(zone)
self._source_mapping = { self._source_mapping = {
@ -409,6 +410,7 @@ class OnkyoMediaPlayer(MediaPlayerEntity):
value: key for key, value in self._source_mapping.items() value: key for key, value in self._source_mapping.items()
} }
self._options_sound_modes = sound_modes
self._sound_mode_lib_mapping = _listening_mode_lib_mappings(zone) self._sound_mode_lib_mapping = _listening_mode_lib_mappings(zone)
self._rev_sound_mode_lib_mapping = _rev_listening_mode_lib_mappings(zone) self._rev_sound_mode_lib_mapping = _rev_listening_mode_lib_mappings(zone)
self._sound_mode_mapping = { self._sound_mode_mapping = {
@ -623,11 +625,20 @@ class OnkyoMediaPlayer(MediaPlayerEntity):
return return
source_meaning = source.value_meaning source_meaning = source.value_meaning
_LOGGER.error(
'Input source "%s" is invalid for entity: %s', if source not in self._options_sources:
source_meaning, _LOGGER.warning(
self.entity_id, 'Input source "%s" for entity: %s is not in the list. Check integration options',
) source_meaning,
self.entity_id,
)
else:
_LOGGER.error(
'Input source "%s" is invalid for entity: %s',
source_meaning,
self.entity_id,
)
self._attr_source = source_meaning self._attr_source = source_meaning
@callback @callback
@ -638,11 +649,20 @@ class OnkyoMediaPlayer(MediaPlayerEntity):
return return
sound_mode_meaning = sound_mode.value_meaning sound_mode_meaning = sound_mode.value_meaning
_LOGGER.error(
'Listening mode "%s" is invalid for entity: %s', if sound_mode not in self._options_sound_modes:
sound_mode_meaning, _LOGGER.warning(
self.entity_id, 'Listening mode "%s" for entity: %s is not in the list. Check integration options',
) sound_mode_meaning,
self.entity_id,
)
else:
_LOGGER.error(
'Listening mode "%s" is invalid for entity: %s',
sound_mode_meaning,
self.entity_id,
)
self._attr_sound_mode = sound_mode_meaning self._attr_sound_mode = sound_mode_meaning
@callback @callback