jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 21:27:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bump plugwise to v0.18.4 (#72263)

Browse Source
This commit is contained in:
Bouwe Westerdijk 2022-05-23 10:59:10 +02:00 committed by GitHub
parent 800410ddf0
commit e17a653cf0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 12 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
homeassistant/components/plugwise/climate.py
View File

@ -105,6 +105,7 @@ class PlugwiseClimateEntity(PlugwiseEntity, ClimateEntity):
return HVACAction.HEATING return HVACAction.HEATING
if heater_central_data["binary_sensors"].get("cooling_state"): if heater_central_data["binary_sensors"].get("cooling_state"):
return HVACAction.COOLING return HVACAction.COOLING
return HVACAction.IDLE return HVACAction.IDLE
@property @property
@ -132,9 +133,6 @@ class PlugwiseClimateEntity(PlugwiseEntity, ClimateEntity):
@plugwise_command @plugwise_command
async def async_set_hvac_mode(self, hvac_mode: HVACMode) -> None: async def async_set_hvac_mode(self, hvac_mode: HVACMode) -> None:
"""Set the hvac mode.""" """Set the hvac mode."""
if hvac_mode == HVACMode.AUTO and not self.device.get("schedule_temperature"):
raise ValueError("Cannot set HVAC mode to Auto: No schedule available")
await self.coordinator.api.set_schedule_state( await self.coordinator.api.set_schedule_state(
self.device["location"], self.device["location"],
self.device.get("last_used"), self.device.get("last_used"),

2
homeassistant/components/plugwise/manifest.json
View File

@ -2,7 +2,7 @@
"domain": "plugwise", "domain": "plugwise",
"name": "Plugwise", "name": "Plugwise",
"documentation": "https://www.home-assistant.io/integrations/plugwise", "documentation": "https://www.home-assistant.io/integrations/plugwise",
"requirements": ["plugwise==0.18.2"], "requirements": ["plugwise==0.18.4"],
"codeowners": ["@CoMPaTech", "@bouwew", "@brefra", "@frenck"], "codeowners": ["@CoMPaTech", "@bouwew", "@brefra", "@frenck"],
"zeroconf": ["_plugwise._tcp.local."], "zeroconf": ["_plugwise._tcp.local."],
"config_flow": true, "config_flow": true,

2
requirements_all.txt
View File

@ -1245,7 +1245,7 @@ plexauth==0.0.6
plexwebsocket==0.0.13 plexwebsocket==0.0.13
# homeassistant.components.plugwise # homeassistant.components.plugwise
plugwise==0.18.2 plugwise==0.18.4
# homeassistant.components.plum_lightpad # homeassistant.components.plum_lightpad
plumlightpad==0.0.11 plumlightpad==0.0.11

2
requirements_test_all.txt
View File

@ -847,7 +847,7 @@ plexauth==0.0.6
plexwebsocket==0.0.13 plexwebsocket==0.0.13
# homeassistant.components.plugwise # homeassistant.components.plugwise
plugwise==0.18.2 plugwise==0.18.4
# homeassistant.components.plum_lightpad # homeassistant.components.plum_lightpad
plumlightpad==0.0.11 plumlightpad==0.0.11

5
tests/components/plugwise/fixtures/adam_multiple_devices_per_zone/all_data.json
View File

@ -34,7 +34,6 @@
], ],
"selected_schedule": "None", "selected_schedule": "None",
"last_used": "Badkamer Schema", "last_used": "Badkamer Schema",
"schedule_temperature": 0.0,
"mode": "heat", "mode": "heat",
"sensors": { "sensors": {
"temperature": 16.5, "temperature": 16.5,
@ -104,7 +103,6 @@
], ],
"selected_schedule": "GF7 Woonkamer", "selected_schedule": "GF7 Woonkamer",
"last_used": "GF7 Woonkamer", "last_used": "GF7 Woonkamer",
"schedule_temperature": 15.0,
"mode": "auto", "mode": "auto",
"sensors": { "sensors": {
"temperature": 20.9, "temperature": 20.9,
@ -301,7 +299,6 @@
], ],
"selected_schedule": "CV Jessie", "selected_schedule": "CV Jessie",
"last_used": "CV Jessie", "last_used": "CV Jessie",
"schedule_temperature": 15.0,
"mode": "auto", "mode": "auto",
"sensors": { "sensors": {
"temperature": 17.2, "temperature": 17.2,
@ -352,7 +349,6 @@
], ],
"selected_schedule": "Badkamer Schema", "selected_schedule": "Badkamer Schema",
"last_used": "Badkamer Schema", "last_used": "Badkamer Schema",
"schedule_temperature": 15.0,
"mode": "auto", "mode": "auto",
"sensors": { "sensors": {
"temperature": 18.9, "temperature": 18.9,
@ -402,7 +398,6 @@
], ],
"selected_schedule": "None", "selected_schedule": "None",
"last_used": "Badkamer Schema", "last_used": "Badkamer Schema",
"schedule_temperature": 0.0,
"mode": "heat", "mode": "heat",
"sensors": { "sensors": {
"temperature": 15.6, "temperature": 15.6,

9
tests/components/plugwise/fixtures/anna_heatpump/all_data.json
View File

@ -63,11 +63,10 @@
"resolution": 0.1, "resolution": 0.1,
"preset_modes": ["no_frost", "home", "away", "asleep", "vacation"], "preset_modes": ["no_frost", "home", "away", "asleep", "vacation"],
"active_preset": "home", "active_preset": "home",
"available_schedules": ["None"], "available_schedules": ["standaard"],
"selected_schedule": "None", "selected_schedule": "standaard",
"last_used": null, "last_used": "standaard",
"schedule_temperature": null, "mode": "auto",
"mode": "heat",
"sensors": { "sensors": {
"temperature": 19.3, "temperature": 19.3,
"setpoint": 21.0, "setpoint": 21.0,

19
tests/components/plugwise/test_climate.py
View File

@ -150,10 +150,11 @@ async def test_anna_climate_entity_attributes(
"""Test creation of anna climate device environment.""" """Test creation of anna climate device environment."""
state = hass.states.get("climate.anna") state = hass.states.get("climate.anna")
assert state assert state
assert state.state == HVACMode.HEAT assert state.state == HVACMode.AUTO
assert state.attributes["hvac_modes"] == [ assert state.attributes["hvac_modes"] == [
HVACMode.HEAT, HVACMode.HEAT,
HVACMode.COOL, HVACMode.COOL,
HVACMode.AUTO,
] ]
assert "no_frost" in state.attributes["preset_modes"] assert "no_frost" in state.attributes["preset_modes"]
assert "home" in state.attributes["preset_modes"] assert "home" in state.attributes["preset_modes"]
@ -199,24 +200,12 @@ async def test_anna_climate_entity_climate_changes(
await hass.services.async_call( await hass.services.async_call(
"climate", "climate",
"set_hvac_mode", "set_hvac_mode",
{"entity_id": "climate.anna", "hvac_mode": "heat_cool"}, {"entity_id": "climate.anna", "hvac_mode": "heat"},
blocking=True, blocking=True,
) )
assert mock_smile_anna.set_temperature.call_count == 1 assert mock_smile_anna.set_temperature.call_count == 1
assert mock_smile_anna.set_schedule_state.call_count == 1 assert mock_smile_anna.set_schedule_state.call_count == 1
mock_smile_anna.set_schedule_state.assert_called_with( mock_smile_anna.set_schedule_state.assert_called_with(
"c784ee9fdab44e1395b8dee7d7a497d5", None, "off" "c784ee9fdab44e1395b8dee7d7a497d5", "standaard", "off"
) )
# Auto mode is not available, no schedules
with pytest.raises(ValueError):
await hass.services.async_call(
"climate",
"set_hvac_mode",
{"entity_id": "climate.anna", "hvac_mode": "auto"},
blocking=True,
)
assert mock_smile_anna.set_temperature.call_count == 1
assert mock_smile_anna.set_schedule_state.call_count == 1

5
tests/components/plugwise/test_diagnostics.py
View File

@ -54,7 +54,6 @@ async def test_diagnostics(
], ],
"selected_schedule": "None", "selected_schedule": "None",
"last_used": "Badkamer Schema", "last_used": "Badkamer Schema",
"schedule_temperature": 0.0,
"mode": "heat", "mode": "heat",
"sensors": {"temperature": 16.5, "setpoint": 13.0, "battery": 67}, "sensors": {"temperature": 16.5, "setpoint": 13.0, "battery": 67},
}, },
@ -120,7 +119,6 @@ async def test_diagnostics(
], ],
"selected_schedule": "GF7 Woonkamer", "selected_schedule": "GF7 Woonkamer",
"last_used": "GF7 Woonkamer", "last_used": "GF7 Woonkamer",
"schedule_temperature": 15.0,
"mode": "auto", "mode": "auto",
"sensors": {"temperature": 20.9, "setpoint": 21.5, "battery": 34}, "sensors": {"temperature": 20.9, "setpoint": 21.5, "battery": 34},
}, },
@ -290,7 +288,6 @@ async def test_diagnostics(
], ],
"selected_schedule": "CV Jessie", "selected_schedule": "CV Jessie",
"last_used": "CV Jessie", "last_used": "CV Jessie",
"schedule_temperature": 15.0,
"mode": "auto", "mode": "auto",
"sensors": {"temperature": 17.2, "setpoint": 15.0, "battery": 37}, "sensors": {"temperature": 17.2, "setpoint": 15.0, "battery": 37},
}, },
@ -337,7 +334,6 @@ async def test_diagnostics(
], ],
"selected_schedule": "Badkamer Schema", "selected_schedule": "Badkamer Schema",
"last_used": "Badkamer Schema", "last_used": "Badkamer Schema",
"schedule_temperature": 15.0,
"mode": "auto", "mode": "auto",
"sensors": {"temperature": 18.9, "setpoint": 14.0, "battery": 92}, "sensors": {"temperature": 18.9, "setpoint": 14.0, "battery": 92},
}, },
@ -380,7 +376,6 @@ async def test_diagnostics(
], ],
"selected_schedule": "None", "selected_schedule": "None",
"last_used": "Badkamer Schema", "last_used": "Badkamer Schema",
"schedule_temperature": 0.0,
"mode": "heat", "mode": "heat",
"sensors": { "sensors": {
"temperature": 15.6, "temperature": 15.6,