jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-18 18:57:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix missing title placeholders in Synology DSM reauth flow (#83238)

Browse Source 
* Fix missing title placeholders in reauth flow

* fix tests

Co-authored-by: mib1185 <mail@mib85.de>
This commit is contained in:
Simone Chemelli 2022-12-04 19:11:24 +01:00 committed by GitHub
parent db0dfe875a
commit e436f6a7b2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
homeassistant/components/synology_dsm/config_flow.py
View File

@ -164,6 +164,7 @@ class SynologyDSMFlowHandler(ConfigFlow, domain=DOMAIN):
use_ssl = user_input.get(CONF_SSL, DEFAULT_USE_SSL) use_ssl = user_input.get(CONF_SSL, DEFAULT_USE_SSL)
verify_ssl = user_input.get(CONF_VERIFY_SSL, DEFAULT_VERIFY_SSL) verify_ssl = user_input.get(CONF_VERIFY_SSL, DEFAULT_VERIFY_SSL)
otp_code = user_input.get(CONF_OTP_CODE) otp_code = user_input.get(CONF_OTP_CODE)
friendly_name = user_input.get(CONF_NAME)
if not port: if not port:
if use_ssl is True: if use_ssl is True:
@ -229,7 +230,7 @@ class SynologyDSMFlowHandler(ConfigFlow, domain=DOMAIN):
return self.async_abort(reason="reauth_successful") return self.async_abort(reason="reauth_successful")
return self.async_abort(reason="reconfigure_successful") return self.async_abort(reason="reconfigure_successful")
return self.async_create_entry(title=host, data=config_data) return self.async_create_entry(title=friendly_name or host, data=config_data)
async def async_step_user( async def async_step_user(
self, user_input: dict[str, Any] | None = None self, user_input: dict[str, Any] | None = None
@ -303,6 +304,8 @@ class SynologyDSMFlowHandler(ConfigFlow, domain=DOMAIN):
async def async_step_reauth(self, entry_data: Mapping[str, Any]) -> FlowResult: async def async_step_reauth(self, entry_data: Mapping[str, Any]) -> FlowResult:
"""Perform reauth upon an API authentication error.""" """Perform reauth upon an API authentication error."""
self.reauth_conf = entry_data self.reauth_conf = entry_data
self.context["title_placeholders"][CONF_HOST] = entry_data[CONF_HOST]
return await self.async_step_reauth_confirm() return await self.async_step_reauth_confirm()
async def async_step_reauth_confirm( async def async_step_reauth_confirm(

3
tests/components/synology_dsm/test_config_flow.py
View File

@ -281,6 +281,7 @@ async def test_reauth(hass: HomeAssistant, service: MagicMock):
"source": SOURCE_REAUTH, "source": SOURCE_REAUTH,
"entry_id": entry.entry_id, "entry_id": entry.entry_id,
"unique_id": entry.unique_id, "unique_id": entry.unique_id,
"title_placeholders": {"name": entry.title},
}, },
data={ data={
CONF_HOST: HOST, CONF_HOST: HOST,
@ -409,7 +410,7 @@ async def test_form_ssdp(hass: HomeAssistant, service: MagicMock):
assert result["type"] == data_entry_flow.FlowResultType.CREATE_ENTRY assert result["type"] == data_entry_flow.FlowResultType.CREATE_ENTRY
assert result["result"].unique_id == SERIAL assert result["result"].unique_id == SERIAL
assert result["title"] == "192.168.1.5" assert result["title"] == "mydsm"
assert result["data"][CONF_HOST] == "192.168.1.5" assert result["data"][CONF_HOST] == "192.168.1.5"
assert result["data"][CONF_PORT] == 5001 assert result["data"][CONF_PORT] == 5001
assert result["data"][CONF_SSL] == DEFAULT_USE_SSL assert result["data"][CONF_SSL] == DEFAULT_USE_SSL