jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-16 17:57:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use friendly name instead of hostname in Tailscale integration (#64682)

Browse Source
This commit is contained in:
Brandon Rothweiler 2022-01-23 15:55:54 -05:00 committed by GitHub
parent eda5cfc12d
commit e564f4193f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
homeassistant/components/tailscale/__init__.py
View File

@ -52,7 +52,8 @@ class TailscaleEntity(CoordinatorEntity):
super().__init__(coordinator=coordinator) super().__init__(coordinator=coordinator)
self.entity_description = description self.entity_description = description
self.device_id = device.device_id self.device_id = device.device_id
self._attr_name = f"{device.hostname} {description.name}" self.friendly_name = device.name.split(".")[0]
self._attr_name = f"{self.friendly_name} {description.name}"
self._attr_unique_id = f"{device.device_id}_{description.key}" self._attr_unique_id = f"{device.device_id}_{description.key}"
@property @property
@ -70,6 +71,6 @@ class TailscaleEntity(CoordinatorEntity):
identifiers={(DOMAIN, device.device_id)}, identifiers={(DOMAIN, device.device_id)},
manufacturer="Tailscale Inc.", manufacturer="Tailscale Inc.",
model=device.os, model=device.os,
name=device.hostname, name=self.friendly_name,
sw_version=device.client_version, sw_version=device.client_version,
) )

16
tests/components/tailscale/test_binary_sensor.py
View File

@ -28,7 +28,7 @@ async def test_tailscale_binary_sensors(
assert entry.unique_id == "123456_update_available" assert entry.unique_id == "123456_update_available"
assert entry.entity_category == EntityCategory.DIAGNOSTIC assert entry.entity_category == EntityCategory.DIAGNOSTIC
assert state.state == STATE_ON assert state.state == STATE_ON
assert state.attributes.get(ATTR_FRIENDLY_NAME) == "Frencks-iPhone Client" assert state.attributes.get(ATTR_FRIENDLY_NAME) == "frencks-iphone Client"
assert state.attributes.get(ATTR_DEVICE_CLASS) == BinarySensorDeviceClass.UPDATE assert state.attributes.get(ATTR_DEVICE_CLASS) == BinarySensorDeviceClass.UPDATE
assert ATTR_ICON not in state.attributes assert ATTR_ICON not in state.attributes
@ -43,7 +43,7 @@ async def test_tailscale_binary_sensors(
assert state.state == STATE_OFF assert state.state == STATE_OFF
assert ( assert (
state.attributes.get(ATTR_FRIENDLY_NAME) state.attributes.get(ATTR_FRIENDLY_NAME)
== "Frencks-iPhone Supports Hairpinning" == "frencks-iphone Supports Hairpinning"
) )
assert state.attributes.get(ATTR_ICON) == "mdi:wan" assert state.attributes.get(ATTR_ICON) == "mdi:wan"
assert ATTR_DEVICE_CLASS not in state.attributes assert ATTR_DEVICE_CLASS not in state.attributes
@ -55,7 +55,7 @@ async def test_tailscale_binary_sensors(
assert entry.unique_id == "123456_client_supports_ipv6" assert entry.unique_id == "123456_client_supports_ipv6"
assert entry.entity_category == EntityCategory.DIAGNOSTIC assert entry.entity_category == EntityCategory.DIAGNOSTIC
assert state.state == STATE_OFF assert state.state == STATE_OFF
assert state.attributes.get(ATTR_FRIENDLY_NAME) == "Frencks-iPhone Supports IPv6" assert state.attributes.get(ATTR_FRIENDLY_NAME) == "frencks-iphone Supports IPv6"
assert state.attributes.get(ATTR_ICON) == "mdi:wan" assert state.attributes.get(ATTR_ICON) == "mdi:wan"
assert ATTR_DEVICE_CLASS not in state.attributes assert ATTR_DEVICE_CLASS not in state.attributes
@ -66,7 +66,7 @@ async def test_tailscale_binary_sensors(
assert entry.unique_id == "123456_client_supports_pcp" assert entry.unique_id == "123456_client_supports_pcp"
assert entry.entity_category == EntityCategory.DIAGNOSTIC assert entry.entity_category == EntityCategory.DIAGNOSTIC
assert state.state == STATE_OFF assert state.state == STATE_OFF
assert state.attributes.get(ATTR_FRIENDLY_NAME) == "Frencks-iPhone Supports PCP" assert state.attributes.get(ATTR_FRIENDLY_NAME) == "frencks-iphone Supports PCP"
assert state.attributes.get(ATTR_ICON) == "mdi:wan" assert state.attributes.get(ATTR_ICON) == "mdi:wan"
assert ATTR_DEVICE_CLASS not in state.attributes assert ATTR_DEVICE_CLASS not in state.attributes
@ -77,7 +77,7 @@ async def test_tailscale_binary_sensors(
assert entry.unique_id == "123456_client_supports_pmp" assert entry.unique_id == "123456_client_supports_pmp"
assert entry.entity_category == EntityCategory.DIAGNOSTIC assert entry.entity_category == EntityCategory.DIAGNOSTIC
assert state.state == STATE_OFF assert state.state == STATE_OFF
assert state.attributes.get(ATTR_FRIENDLY_NAME) == "Frencks-iPhone Supports NAT-PMP" assert state.attributes.get(ATTR_FRIENDLY_NAME) == "frencks-iphone Supports NAT-PMP"
assert state.attributes.get(ATTR_ICON) == "mdi:wan" assert state.attributes.get(ATTR_ICON) == "mdi:wan"
assert ATTR_DEVICE_CLASS not in state.attributes assert ATTR_DEVICE_CLASS not in state.attributes
@ -88,7 +88,7 @@ async def test_tailscale_binary_sensors(
assert entry.unique_id == "123456_client_supports_udp" assert entry.unique_id == "123456_client_supports_udp"
assert entry.entity_category == EntityCategory.DIAGNOSTIC assert entry.entity_category == EntityCategory.DIAGNOSTIC
assert state.state == STATE_ON assert state.state == STATE_ON
assert state.attributes.get(ATTR_FRIENDLY_NAME) == "Frencks-iPhone Supports UDP" assert state.attributes.get(ATTR_FRIENDLY_NAME) == "frencks-iphone Supports UDP"
assert state.attributes.get(ATTR_ICON) == "mdi:wan" assert state.attributes.get(ATTR_ICON) == "mdi:wan"
assert ATTR_DEVICE_CLASS not in state.attributes assert ATTR_DEVICE_CLASS not in state.attributes
@ -99,7 +99,7 @@ async def test_tailscale_binary_sensors(
assert entry.unique_id == "123456_client_supports_upnp" assert entry.unique_id == "123456_client_supports_upnp"
assert entry.entity_category == EntityCategory.DIAGNOSTIC assert entry.entity_category == EntityCategory.DIAGNOSTIC
assert state.state == STATE_OFF assert state.state == STATE_OFF
assert state.attributes.get(ATTR_FRIENDLY_NAME) == "Frencks-iPhone Supports UPnP" assert state.attributes.get(ATTR_FRIENDLY_NAME) == "frencks-iphone Supports UPnP"
assert state.attributes.get(ATTR_ICON) == "mdi:wan" assert state.attributes.get(ATTR_ICON) == "mdi:wan"
assert ATTR_DEVICE_CLASS not in state.attributes assert ATTR_DEVICE_CLASS not in state.attributes
@ -109,7 +109,7 @@ async def test_tailscale_binary_sensors(
assert device_entry.identifiers == {(DOMAIN, "123456")} assert device_entry.identifiers == {(DOMAIN, "123456")}
assert device_entry.manufacturer == "Tailscale Inc." assert device_entry.manufacturer == "Tailscale Inc."
assert device_entry.model == "iOS" assert device_entry.model == "iOS"
assert device_entry.name == "Frencks-iPhone" assert device_entry.name == "frencks-iphone"
assert device_entry.entry_type == dr.DeviceEntryType.SERVICE assert device_entry.entry_type == dr.DeviceEntryType.SERVICE
assert device_entry.sw_version == "1.12.3-td91ea7286-ge1bbbd90c" assert device_entry.sw_version == "1.12.3-td91ea7286-ge1bbbd90c"
assert ( assert (