From e626cd12aa3fab3d02478773f738da8a9b59e335 Mon Sep 17 00:00:00 2001 From: Joost Lekkerkerker Date: Wed, 27 Mar 2024 18:01:07 +0100 Subject: [PATCH] Fix feedback in ROVA (#114308) --- homeassistant/components/rova/sensor.py | 4 ++-- homeassistant/components/rova/strings.json | 2 +- tests/components/rova/test_config_flow.py | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/homeassistant/components/rova/sensor.py b/homeassistant/components/rova/sensor.py index 0fae976748a..e510bcf0caf 100644 --- a/homeassistant/components/rova/sensor.py +++ b/homeassistant/components/rova/sensor.py @@ -94,12 +94,12 @@ async def async_setup_platform( async_create_issue( hass, DOMAIN, - f"deprecated_yaml_import_issue_${result['reason']}", + f"deprecated_yaml_import_issue_{result['reason']}", breaks_in_ha_version="2024.10.0", is_fixable=False, issue_domain=DOMAIN, severity=IssueSeverity.WARNING, - translation_key=f"deprecated_yaml_import_issue_${result['reason']}", + translation_key=f"deprecated_yaml_import_issue_{result['reason']}", translation_placeholders=ISSUE_PLACEHOLDER, ) diff --git a/homeassistant/components/rova/strings.json b/homeassistant/components/rova/strings.json index 9a63bf27aec..709e5450411 100644 --- a/homeassistant/components/rova/strings.json +++ b/homeassistant/components/rova/strings.json @@ -23,7 +23,7 @@ "issues": { "deprecated_yaml_import_issue_cannot_connect": { "title": "The Rova YAML configuration import failed", - "description": "Configuring Rova using YAML is being removed but there was an connection error importing your YAML configuration.\n\nEnsure connection to Rova works and restart Home Assistant to try again or remove the Rova YAML configuration from your configuration.yaml file and continue to [set up the integration]({url}) manually." + "description": "Configuring Rova using YAML is being removed but there was a connection error importing your YAML configuration.\n\nEnsure connection to Rova works and restart Home Assistant to try again or remove the Rova YAML configuration from your configuration.yaml file and continue to [set up the integration]({url}) manually." }, "deprecated_yaml_import_issue_invalid_rova_area": { "title": "The Rova YAML configuration import failed", diff --git a/tests/components/rova/test_config_flow.py b/tests/components/rova/test_config_flow.py index b78e798c120..357cd9eb344 100644 --- a/tests/components/rova/test_config_flow.py +++ b/tests/components/rova/test_config_flow.py @@ -49,10 +49,10 @@ async def test_user(hass: HomeAssistant, mock_rova: MagicMock) -> None: assert data[CONF_HOUSE_NUMBER_SUFFIX] == HOUSE_NUMBER_SUFFIX -async def test_abort_if_not_rova_area( +async def test_error_if_not_rova_area( hass: HomeAssistant, mock_rova: MagicMock ) -> None: - """Test we abort if rova does not collect at the given address.""" + """Test we raise errors if rova does not collect at the given address.""" result = await hass.config_entries.flow.async_init( DOMAIN, context={"source": SOURCE_USER} )