jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-14 08:47:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix restoring isy994 brightness with no previous state (#34972)

Browse Source
This commit is contained in:
J. Nick Koston 2020-05-01 00:36:01 -05:00 committed by GitHub
parent af62660b14
commit e7157f2164
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 28 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CODEOWNERS
View File

@ -196,6 +196,7 @@ homeassistant/components/ipp/* @ctalkington
homeassistant/components/iqvia/* @bachya homeassistant/components/iqvia/* @bachya
homeassistant/components/irish_rail_transport/* @ttroy50 homeassistant/components/irish_rail_transport/* @ttroy50
homeassistant/components/islamic_prayer_times/* @engrbm87 homeassistant/components/islamic_prayer_times/* @engrbm87
homeassistant/components/isy994/* @bdraco
homeassistant/components/izone/* @Swamp-Ig homeassistant/components/izone/* @Swamp-Ig
homeassistant/components/jewish_calendar/* @tsvi homeassistant/components/jewish_calendar/* @tsvi
homeassistant/components/juicenet/* @jesserockz homeassistant/components/juicenet/* @jesserockz

29
homeassistant/components/isy994/light.py
View File

@ -3,12 +3,15 @@ import logging
from typing import Callable from typing import Callable
from homeassistant.components.light import DOMAIN, SUPPORT_BRIGHTNESS, LightEntity from homeassistant.components.light import DOMAIN, SUPPORT_BRIGHTNESS, LightEntity
from homeassistant.helpers.restore_state import RestoreEntity
from homeassistant.helpers.typing import ConfigType from homeassistant.helpers.typing import ConfigType
from . import ISY994_NODES, ISYDevice from . import ISY994_NODES, ISYDevice
_LOGGER = logging.getLogger(__name__) _LOGGER = logging.getLogger(__name__)
ATTR_LAST_BRIGHTNESS = "last_brightness"
def setup_platform( def setup_platform(
hass, config: ConfigType, add_entities: Callable[[list], None], discovery_info=None hass, config: ConfigType, add_entities: Callable[[list], None], discovery_info=None
@ -21,13 +24,13 @@ def setup_platform(
add_entities(devices) add_entities(devices)
class ISYLightDevice(ISYDevice, LightEntity): class ISYLightDevice(ISYDevice, LightEntity, RestoreEntity):
"""Representation of an ISY994 light device.""" """Representation of an ISY994 light device."""
def __init__(self, node) -> None: def __init__(self, node) -> None:
"""Initialize the ISY994 light device.""" """Initialize the ISY994 light device."""
super().__init__(node) super().__init__(node)
self._last_brightness = self.brightness self._last_brightness = None
@property @property
def is_on(self) -> bool: def is_on(self) -> bool:
@ -56,7 +59,7 @@ class ISYLightDevice(ISYDevice, LightEntity):
# pylint: disable=arguments-differ # pylint: disable=arguments-differ
def turn_on(self, brightness=None, **kwargs) -> None: def turn_on(self, brightness=None, **kwargs) -> None:
"""Send the turn on command to the ISY994 light device.""" """Send the turn on command to the ISY994 light device."""
if brightness is None and self._last_brightness is not None: if brightness is None and self._last_brightness:
brightness = self._last_brightness brightness = self._last_brightness
if not self._node.on(val=brightness): if not self._node.on(val=brightness):
_LOGGER.debug("Unable to turn on light") _LOGGER.debug("Unable to turn on light")
@ -65,3 +68,23 @@ class ISYLightDevice(ISYDevice, LightEntity):
def supported_features(self): def supported_features(self):
"""Flag supported features.""" """Flag supported features."""
return SUPPORT_BRIGHTNESS return SUPPORT_BRIGHTNESS
@property
def device_state_attributes(self):
"""Return the light attributes."""
return {ATTR_LAST_BRIGHTNESS: self._last_brightness}
async def async_added_to_hass(self) -> None:
"""Restore last_brightness on restart."""
await super().async_added_to_hass()
self._last_brightness = self.brightness or 255
last_state = await self.async_get_last_state()
if not last_state:
return
if (
ATTR_LAST_BRIGHTNESS in last_state.attributes
and last_state.attributes[ATTR_LAST_BRIGHTNESS]
):
self._last_brightness = last_state.attributes[ATTR_LAST_BRIGHTNESS]

2
homeassistant/components/isy994/manifest.json
View File

@ -3,5 +3,5 @@
"name": "Universal Devices ISY994", "name": "Universal Devices ISY994",
"documentation": "https://www.home-assistant.io/integrations/isy994", "documentation": "https://www.home-assistant.io/integrations/isy994",
"requirements": ["PyISY==1.1.2"], "requirements": ["PyISY==1.1.2"],
"codeowners": [] "codeowners": ["@bdraco"]
} }