From e76d553513efef21f8f587e939f29686c84956c3 Mon Sep 17 00:00:00 2001 From: Paulus Schoutsen Date: Thu, 10 Nov 2016 21:17:44 -0800 Subject: [PATCH] fix panasonic viera doing I/O in event loop (#4341) --- .../components/media_player/panasonic_viera.py | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/homeassistant/components/media_player/panasonic_viera.py b/homeassistant/components/media_player/panasonic_viera.py index d1a971eb91e..987364bbf63 100644 --- a/homeassistant/components/media_player/panasonic_viera.py +++ b/homeassistant/components/media_player/panasonic_viera.py @@ -79,16 +79,16 @@ class PanasonicVieraTVDevice(MediaPlayerDevice): self._playing = True self._state = STATE_UNKNOWN self._remote = remote + self._volume = 0 def update(self): """Retrieve the latest data.""" try: self._muted = self._remote.get_mute() + self._volume = self._remote.get_volume() / 100 self._state = STATE_ON except OSError: self._state = STATE_OFF - return False - return True def send_key(self, key): """Send a key to the tv and handles exceptions.""" @@ -113,13 +113,7 @@ class PanasonicVieraTVDevice(MediaPlayerDevice): @property def volume_level(self): """Volume level of the media player (0..1).""" - volume = 0 - try: - volume = self._remote.get_volume() / 100 - self._state = STATE_ON - except OSError: - self._state = STATE_OFF - return volume + return self._volume @property def is_volume_muted(self):