From e87603aa5942597f5199eb891a1443f9da23e8f1 Mon Sep 17 00:00:00 2001 From: John Hollowell Date: Wed, 13 Sep 2023 02:35:59 -0400 Subject: [PATCH] Correct Venstar firmware version to use device's FW version instead of API version (#98493) --- CODEOWNERS | 4 ++-- homeassistant/components/venstar/__init__.py | 2 +- homeassistant/components/venstar/manifest.json | 2 +- tests/components/venstar/__init__.py | 3 ++- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 9771a9e25e5..bba1c2debbf 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1361,8 +1361,8 @@ build.json @home-assistant/supervisor /homeassistant/components/velbus/ @Cereal2nd @brefra /tests/components/velbus/ @Cereal2nd @brefra /homeassistant/components/velux/ @Julius2342 -/homeassistant/components/venstar/ @garbled1 -/tests/components/venstar/ @garbled1 +/homeassistant/components/venstar/ @garbled1 @jhollowe +/tests/components/venstar/ @garbled1 @jhollowe /homeassistant/components/verisure/ @frenck /tests/components/verisure/ @frenck /homeassistant/components/versasense/ @imstevenxyz diff --git a/homeassistant/components/venstar/__init__.py b/homeassistant/components/venstar/__init__.py index a92d495f6af..1416bcf376a 100644 --- a/homeassistant/components/venstar/__init__.py +++ b/homeassistant/components/venstar/__init__.py @@ -153,5 +153,5 @@ class VenstarEntity(CoordinatorEntity[VenstarDataUpdateCoordinator]): name=self._client.name, manufacturer="Venstar", model=f"{self._client.model}-{self._client.get_type()}", - sw_version=self._client.get_api_ver(), + sw_version="{}.{}".format(*(self._client.get_firmware_ver())), ) diff --git a/homeassistant/components/venstar/manifest.json b/homeassistant/components/venstar/manifest.json index 39cbe0d3529..f3045fe49e8 100644 --- a/homeassistant/components/venstar/manifest.json +++ b/homeassistant/components/venstar/manifest.json @@ -1,7 +1,7 @@ { "domain": "venstar", "name": "Venstar", - "codeowners": ["@garbled1"], + "codeowners": ["@garbled1", "@jhollowe"], "config_flow": true, "documentation": "https://www.home-assistant.io/integrations/venstar", "iot_class": "local_polling", diff --git a/tests/components/venstar/__init__.py b/tests/components/venstar/__init__.py index fa35dd88379..f91f8f28bdf 100644 --- a/tests/components/venstar/__init__.py +++ b/tests/components/venstar/__init__.py @@ -18,7 +18,8 @@ class VenstarColorTouchMock: """Initialize the Venstar library.""" self.status = {} self.model = "COLORTOUCH" - self._api_ver = 5 + self._api_ver = 7 + self._firmware_ver = tuple(5, 28) self.name = "TestVenstar" self._info = {} self._sensors = {}