jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-12 15:57:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update ESPHome bluetooth repair issue for unique id change and 2022.12.0 (#84026)

Browse Source 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
This commit is contained in:
J. Nick Koston 2022-12-15 06:59:53 -10:00 committed by GitHub
parent dcea8a6ced
commit e94da1ad0f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
homeassistant/components/esphome/__init__.py
View File

@ -66,8 +66,12 @@ CONF_NOISE_PSK = "noise_psk"
_LOGGER = logging.getLogger(__name__) _LOGGER = logging.getLogger(__name__)
_R = TypeVar("_R") _R = TypeVar("_R")
STABLE_BLE_VERSION_STR = "2022.11.0" STABLE_BLE_VERSION_STR = "2022.12.0"
STABLE_BLE_VERSION = AwesomeVersion(STABLE_BLE_VERSION_STR) STABLE_BLE_VERSION = AwesomeVersion(STABLE_BLE_VERSION_STR)
PROJECT_URLS = {
"esphome.bluetooth-proxy": "https://esphome.github.io/bluetooth-proxies/",
}
DEFAULT_URL = f"https://esphome.io/changelog/{STABLE_BLE_VERSION_STR}.html"
@callback @callback
@ -75,13 +79,13 @@ def _async_check_firmware_version(
hass: HomeAssistant, device_info: EsphomeDeviceInfo hass: HomeAssistant, device_info: EsphomeDeviceInfo
) -> None: ) -> None:
"""Create or delete an the ble_firmware_outdated issue.""" """Create or delete an the ble_firmware_outdated issue."""
# ESPHome device_info.name is the unique_id # ESPHome device_info.mac_address is the unique_id
issue = f"ble_firmware_outdated-{device_info.name}" issue = f"ble_firmware_outdated-{device_info.mac_address}"
if ( if (
not device_info.bluetooth_proxy_version not device_info.bluetooth_proxy_version
# If the device has a project name its up to that project # If the device has a project name its up to that project
# to tell them about the firmware version update so we don't notify here # to tell them about the firmware version update so we don't notify here
or device_info.project_name or (device_info.project_name and device_info.project_name not in PROJECT_URLS)
or AwesomeVersion(device_info.esphome_version) >= STABLE_BLE_VERSION or AwesomeVersion(device_info.esphome_version) >= STABLE_BLE_VERSION
): ):
async_delete_issue(hass, DOMAIN, issue) async_delete_issue(hass, DOMAIN, issue)
@ -92,9 +96,12 @@ def _async_check_firmware_version(
issue, issue,
is_fixable=False, is_fixable=False,
severity=IssueSeverity.WARNING, severity=IssueSeverity.WARNING,
learn_more_url=f"https://esphome.io/changelog/{STABLE_BLE_VERSION_STR}.html", learn_more_url=PROJECT_URLS.get(device_info.project_name, DEFAULT_URL),
translation_key="ble_firmware_outdated", translation_key="ble_firmware_outdated",
translation_placeholders={"name": device_info.name}, translation_placeholders={
"name": device_info.name,
"version": STABLE_BLE_VERSION_STR,
},
) )

4
homeassistant/components/esphome/strings.json
View File

@ -47,8 +47,8 @@
}, },
"issues": { "issues": {
"ble_firmware_outdated": { "ble_firmware_outdated": {
"title": "Update {name} with ESPHome 2022.11.0 or later", "title": "Update {name} with ESPHome {version} or later",
"description": "To improve Bluetooth reliability and performance, we highly recommend updating {name} with ESPHome 2022.11.0 or later." "description": "To improve Bluetooth reliability and performance, we highly recommend updating {name} with ESPHome {version} or later. When updating the device to ESPHome {version}, it is recommended to use a serial cable instead of an over-the-air update to take advantage of the new partition scheme."
} }
} }
} }

4
homeassistant/components/esphome/translations/en.json
View File

@ -47,8 +47,8 @@
}, },
"issues": { "issues": {
"ble_firmware_outdated": { "ble_firmware_outdated": {
"description": "To improve Bluetooth reliability and performance, we highly recommend updating {name} with ESPHome 2022.11.0 or later.", "description": "To improve Bluetooth reliability and performance, we highly recommend updating {name} with ESPHome {version} or later. When updating the device to ESPHome {version}, it is recommended to use a serial cable instead of an over-the-air update to take advantage of the new partition scheme.",
"title": "Update {name} with ESPHome 2022.11.0 or later" "title": "Update {name} with ESPHome {version} or later"
} }
} }
} }