From e96635b5c1171f68c6b55fd32ba7aa81064a3a3d Mon Sep 17 00:00:00 2001 From: vikramgorla Date: Mon, 10 Sep 2018 16:13:05 +0200 Subject: [PATCH] bugfix - incorrect camera type and missing sensors when multiple netatmo cameras (#16490) fixed get_camera_type as it was originally not consuming any input, was looping with all cameras and the first camera type was retutned, modified to call cameraType using provided camera name. --- homeassistant/components/netatmo.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/homeassistant/components/netatmo.py b/homeassistant/components/netatmo.py index c25b57fbd62..59b0a64f6e9 100644 --- a/homeassistant/components/netatmo.py +++ b/homeassistant/components/netatmo.py @@ -101,10 +101,10 @@ class CameraData: return self.module_names def get_camera_type(self, camera=None, home=None, cid=None): - """Return all module available on the API as a list.""" - for camera_name in self.camera_names: - self.camera_type = self.camera_data.cameraType(camera_name) - return self.camera_type + """Return camera type for a camera, cid has preference over camera.""" + self.camera_type = self.camera_data.cameraType(camera=camera, + home=home, cid=cid) + return self.camera_type @Throttle(MIN_TIME_BETWEEN_UPDATES) def update(self):