jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-27 07:07:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Small cleanups to async_get_all_descriptions (#108633)

Browse Source
This commit is contained in:
J. Nick Koston 2024-01-21 18:09:33 -10:00 committed by GitHub
parent 0b3bcca49b
commit e9a7870080
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
homeassistant/helpers/service.py
View File

@ -581,31 +581,36 @@ async def async_get_all_descriptions(
descriptions_cache: dict[ descriptions_cache: dict[
tuple[str, str], dict[str, Any] | None tuple[str, str], dict[str, Any] | None
] = hass.data.setdefault(SERVICE_DESCRIPTION_CACHE, {}) ] = hass.data.setdefault(SERVICE_DESCRIPTION_CACHE, {})
services = hass.services.async_services()
# We don't mutate services here so we avoid calling
# async_services which makes a copy of every services
# dict.
services = hass.services._services # pylint: disable=protected-access
# See if there are new services not seen before. # See if there are new services not seen before.
# Any service that we saw before already has an entry in description_cache. # Any service that we saw before already has an entry in description_cache.
missing = set() domains_with_missing_services: set[str] = set()
all_services = [] all_services: set[tuple[str, str]] = set()
for domain in services: for domain, services_by_domain in services.items():
for service_name in services[domain]: for service_name in services_by_domain:
cache_key = (domain, service_name) cache_key = (domain, service_name)
all_services.append(cache_key) all_services.add(cache_key)
if cache_key not in descriptions_cache: if cache_key not in descriptions_cache:
missing.add(domain) domains_with_missing_services.add(domain)
# If we have a complete cache, check if it is still valid # If we have a complete cache, check if it is still valid
all_cache: tuple[set[tuple[str, str]], dict[str, dict[str, Any]]] | None
if all_cache := hass.data.get(ALL_SERVICE_DESCRIPTIONS_CACHE): if all_cache := hass.data.get(ALL_SERVICE_DESCRIPTIONS_CACHE):
previous_all_services, previous_descriptions_cache = all_cache previous_all_services, previous_descriptions_cache = all_cache
# If the services are the same, we can return the cache # If the services are the same, we can return the cache
if previous_all_services == all_services: if previous_all_services == all_services:
return cast(dict[str, dict[str, Any]], previous_descriptions_cache) return previous_descriptions_cache # type: ignore[no-any-return]
# Files we loaded for missing descriptions # Files we loaded for missing descriptions
loaded: dict[str, JSON_TYPE] = {} loaded: dict[str, JSON_TYPE] = {}
if missing: if domains_with_missing_services:
ints_or_excs = await async_get_integrations(hass, missing) ints_or_excs = await async_get_integrations(hass, domains_with_missing_services)
integrations: list[Integration] = [] integrations: list[Integration] = []
for domain, int_or_exc in ints_or_excs.items(): for domain, int_or_exc in ints_or_excs.items():
if type(int_or_exc) is Integration: # noqa: E721 if type(int_or_exc) is Integration: # noqa: E721
@ -617,11 +622,11 @@ async def async_get_all_descriptions(
contents = await hass.async_add_executor_job( contents = await hass.async_add_executor_job(
_load_services_files, hass, integrations _load_services_files, hass, integrations
) )
loaded = dict(zip(missing, contents)) loaded = dict(zip(domains_with_missing_services, contents))
# Load translations for all service domains # Load translations for all service domains
translations = await translation.async_get_translations( translations = await translation.async_get_translations(
hass, "en", "services", list(services) hass, "en", "services", services
) )
# Build response # Build response