Cache parsing the url for the device registry (#113910)

* Cache parsing the url for the device registry

There are lots of hub integrations that use the same url for every
sub-device which results in a lot of url parsing at startup. The
logic can be simplified quite a bit here by only using yarl
for URLs

* fix onvif

homeassistant/helpers/device_registry.py

@@ -9,7 +9,6 @@ from functools import lru_cache, partial
 import logging
 import time
 from typing import TYPE_CHECKING, Any, Literal, TypedDict, TypeVar, cast
-from urllib.parse import urlparse
 
 import attr
 from yarl import URL
@@ -212,22 +211,22 @@ def _validate_device_info(
     return device_info_type
 
 
+_cached_parse_url = lru_cache(maxsize=512)(URL)
+"""Parse a URL and cache the result."""
+
+
 def _validate_configuration_url(value: Any) -> str | None:
     """Validate and convert configuration_url."""
     if value is None:
         return None
-    if (
+
-        isinstance(value, URL)
+    url_as_str = str(value)
-        and (value.scheme not in CONFIGURATION_URL_SCHEMES or not value.host)
+    url = value if type(value) is URL else _cached_parse_url(url_as_str)
-    ) or (
+
-        (parsed_url := urlparse(str(value)))
+    if url.scheme not in CONFIGURATION_URL_SCHEMES or not url.host:
-        and (
-            parsed_url.scheme not in CONFIGURATION_URL_SCHEMES
-            or not parsed_url.hostname
-        )
-    ):
         raise ValueError(f"invalid configuration_url '{value}'")
-    return str(value)
+
+    return url_as_str
 
 
 @attr.s(frozen=True)

tests/components/onvif/__init__.py

@@ -125,6 +125,7 @@ def setup_mock_onvif_camera(
 def setup_mock_device(mock_device, capabilities=None):
     """Prepare mock ONVIFDevice."""
     mock_device.async_setup = AsyncMock(return_value=True)
+    mock_device.port = 80
     mock_device.available = True
     mock_device.name = NAME
     mock_device.info = DeviceInfo(