jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-15 09:17:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix misleading friendly names of pvoutput sensors (#141312)

Browse Source 
* Fix misleading friendly names of `pvoutput` sensors

* Update test_sensor.py

* Update test_sensor.py - prettier
This commit is contained in:
Norbert Rittel 2025-03-27 21:49:16 +01:00 committed by GitHub
parent 9633f03ddc
commit ea0c4a7263
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 17 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
homeassistant/components/pvoutput/strings.json
View File

@ -27,19 +27,19 @@
"entity": { "entity": {
"sensor": { "sensor": {
"energy_consumption": { "energy_consumption": {
"name": "Energy consumed" "name": "Energy consumption"
}, },
"energy_generation": { "energy_generation": {
"name": "Energy generated" "name": "Energy generation"
}, },
"efficiency": { "efficiency": {
"name": "Efficiency" "name": "Efficiency"
}, },
"power_consumption": { "power_consumption": {
"name": "Power consumed" "name": "Power consumption"
}, },
"power_generation": { "power_generation": {
"name": "Power generated" "name": "Power generation"
} }
} }
} }

25
tests/components/pvoutput/test_sensor.py
View File

@ -30,8 +30,8 @@ async def test_sensors(
) -> None: ) -> None:
"""Test the PVOutput sensors.""" """Test the PVOutput sensors."""
state = hass.states.get("sensor.frenck_s_solar_farm_energy_consumed") state = hass.states.get("sensor.frenck_s_solar_farm_energy_consumption")
entry = entity_registry.async_get("sensor.frenck_s_solar_farm_energy_consumed") entry = entity_registry.async_get("sensor.frenck_s_solar_farm_energy_consumption")
assert entry assert entry
assert state assert state
assert entry.unique_id == "12345_energy_consumption" assert entry.unique_id == "12345_energy_consumption"
@ -40,14 +40,14 @@ async def test_sensors(
assert state.attributes.get(ATTR_DEVICE_CLASS) == SensorDeviceClass.ENERGY assert state.attributes.get(ATTR_DEVICE_CLASS) == SensorDeviceClass.ENERGY
assert ( assert (
state.attributes.get(ATTR_FRIENDLY_NAME) state.attributes.get(ATTR_FRIENDLY_NAME)
== "Frenck's Solar Farm Energy consumed" == "Frenck's Solar Farm Energy consumption"
) )
assert state.attributes.get(ATTR_STATE_CLASS) is SensorStateClass.TOTAL_INCREASING assert state.attributes.get(ATTR_STATE_CLASS) is SensorStateClass.TOTAL_INCREASING
assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == UnitOfEnergy.WATT_HOUR assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == UnitOfEnergy.WATT_HOUR
assert ATTR_ICON not in state.attributes assert ATTR_ICON not in state.attributes
state = hass.states.get("sensor.frenck_s_solar_farm_energy_generated") state = hass.states.get("sensor.frenck_s_solar_farm_energy_generation")
entry = entity_registry.async_get("sensor.frenck_s_solar_farm_energy_generated") entry = entity_registry.async_get("sensor.frenck_s_solar_farm_energy_generation")
assert entry assert entry
assert state assert state
assert entry.unique_id == "12345_energy_generation" assert entry.unique_id == "12345_energy_generation"
@ -56,7 +56,7 @@ async def test_sensors(
assert state.attributes.get(ATTR_DEVICE_CLASS) == SensorDeviceClass.ENERGY assert state.attributes.get(ATTR_DEVICE_CLASS) == SensorDeviceClass.ENERGY
assert ( assert (
state.attributes.get(ATTR_FRIENDLY_NAME) state.attributes.get(ATTR_FRIENDLY_NAME)
== "Frenck's Solar Farm Energy generated" == "Frenck's Solar Farm Energy generation"
) )
assert state.attributes.get(ATTR_STATE_CLASS) is SensorStateClass.TOTAL_INCREASING assert state.attributes.get(ATTR_STATE_CLASS) is SensorStateClass.TOTAL_INCREASING
assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == UnitOfEnergy.WATT_HOUR assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == UnitOfEnergy.WATT_HOUR
@ -78,8 +78,8 @@ async def test_sensors(
assert ATTR_DEVICE_CLASS not in state.attributes assert ATTR_DEVICE_CLASS not in state.attributes
assert ATTR_ICON not in state.attributes assert ATTR_ICON not in state.attributes
state = hass.states.get("sensor.frenck_s_solar_farm_power_consumed") state = hass.states.get("sensor.frenck_s_solar_farm_power_consumption")
entry = entity_registry.async_get("sensor.frenck_s_solar_farm_power_consumed") entry = entity_registry.async_get("sensor.frenck_s_solar_farm_power_consumption")
assert entry assert entry
assert state assert state
assert entry.unique_id == "12345_power_consumption" assert entry.unique_id == "12345_power_consumption"
@ -87,14 +87,15 @@ async def test_sensors(
assert state.state == "2500.0" assert state.state == "2500.0"
assert state.attributes.get(ATTR_DEVICE_CLASS) == SensorDeviceClass.POWER assert state.attributes.get(ATTR_DEVICE_CLASS) == SensorDeviceClass.POWER
assert ( assert (
state.attributes.get(ATTR_FRIENDLY_NAME) == "Frenck's Solar Farm Power consumed" state.attributes.get(ATTR_FRIENDLY_NAME)
== "Frenck's Solar Farm Power consumption"
) )
assert state.attributes.get(ATTR_STATE_CLASS) is SensorStateClass.MEASUREMENT assert state.attributes.get(ATTR_STATE_CLASS) is SensorStateClass.MEASUREMENT
assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == UnitOfPower.WATT assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == UnitOfPower.WATT
assert ATTR_ICON not in state.attributes assert ATTR_ICON not in state.attributes
state = hass.states.get("sensor.frenck_s_solar_farm_power_generated") state = hass.states.get("sensor.frenck_s_solar_farm_power_generation")
entry = entity_registry.async_get("sensor.frenck_s_solar_farm_power_generated") entry = entity_registry.async_get("sensor.frenck_s_solar_farm_power_generation")
assert entry assert entry
assert state assert state
assert entry.unique_id == "12345_power_generation" assert entry.unique_id == "12345_power_generation"
@ -103,7 +104,7 @@ async def test_sensors(
assert state.attributes.get(ATTR_DEVICE_CLASS) == SensorDeviceClass.POWER assert state.attributes.get(ATTR_DEVICE_CLASS) == SensorDeviceClass.POWER
assert ( assert (
state.attributes.get(ATTR_FRIENDLY_NAME) state.attributes.get(ATTR_FRIENDLY_NAME)
== "Frenck's Solar Farm Power generated" == "Frenck's Solar Farm Power generation"
) )
assert state.attributes.get(ATTR_STATE_CLASS) is SensorStateClass.MEASUREMENT assert state.attributes.get(ATTR_STATE_CLASS) is SensorStateClass.MEASUREMENT
assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == UnitOfPower.WATT assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == UnitOfPower.WATT