jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-26 06:37:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve check for duplicated entity_id (#19194)

Browse Source 
* Fail if new entity_id is in hass.states

* Move check to websocket

* Review comments
This commit is contained in:
Paulus Schoutsen 2018-12-13 20:57:33 +01:00 committed by GitHub
commit eada1a184c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
homeassistant/components/config/entity_registry.py
View File

@ -88,7 +88,7 @@ async def websocket_get_entity(hass, connection, msg):
@async_response @async_response
async def websocket_update_entity(hass, connection, msg): async def websocket_update_entity(hass, connection, msg):
"""Handle get camera thumbnail websocket command. """Handle update entity websocket command.
Async friendly. Async friendly.
""" """
@ -106,6 +106,10 @@ async def websocket_update_entity(hass, connection, msg):
if 'new_entity_id' in msg: if 'new_entity_id' in msg:
changes['new_entity_id'] = msg['new_entity_id'] changes['new_entity_id'] = msg['new_entity_id']
if hass.states.get(msg['new_entity_id']) is not None:
connection.send_message(websocket_api.error_message(
msg['id'], 'invalid_info', 'Entity is already registered'))
return
try: try:
if changes: if changes: