jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-23 13:17:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent new discovery flows from being created when stopping (#88743)

Browse Source
This commit is contained in:
J. Nick Koston 2023-02-25 05:02:07 -06:00 committed by Franck Nijhof
parent 6196607c5d
commit ed8f538890
No known key found for this signature in database
GPG Key ID: D62583BA8AB11CA3
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
homeassistant/helpers/discovery_flow.py
View File

@ -44,7 +44,9 @@ def _async_init_flow(
# as ones in progress as it may cause additional device probing # as ones in progress as it may cause additional device probing
# which can overload devices since zeroconf/ssdp updates can happen # which can overload devices since zeroconf/ssdp updates can happen
# multiple times in the same minute # multiple times in the same minute
if hass.config_entries.flow.async_has_matching_flow(domain, context, data): if hass.is_stopping or hass.config_entries.flow.async_has_matching_flow(
domain, context, data
):
return None return None
return hass.config_entries.flow.async_init(domain, context=context, data=data) return hass.config_entries.flow.async_init(domain, context=context, data=data)

17
tests/helpers/test_discovery_flow.py
View File

@ -96,3 +96,20 @@ async def test_async_create_flow_checks_existing_flows_before_startup(
data={"properties": {"id": "aa:bb:cc:dd:ee:ff"}}, data={"properties": {"id": "aa:bb:cc:dd:ee:ff"}},
) )
] ]
async def test_async_create_flow_does_nothing_after_stop(
hass: HomeAssistant, mock_flow_init
) -> None:
"""Test we no longer create flows when hass is stopping."""
hass.bus.async_fire(EVENT_HOMEASSISTANT_STARTED)
await hass.async_block_till_done()
hass.state = CoreState.stopping
mock_flow_init.reset_mock()
discovery_flow.async_create_flow(
hass,
"hue",
{"source": config_entries.SOURCE_HOMEKIT},
{"properties": {"id": "aa:bb:cc:dd:ee:ff"}},
)
assert len(mock_flow_init.mock_calls) == 0