From edb7ec78f9f3151273c1942bf6c168f9729e9387 Mon Sep 17 00:00:00 2001 From: emontnemery Date: Mon, 24 Dec 2018 14:21:58 +0100 Subject: [PATCH] Fix support for base topic for empty values in MQTT discovery msg (#19501) * Fix topic expansion for short strings * Lint --- homeassistant/components/mqtt/discovery.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/homeassistant/components/mqtt/discovery.py b/homeassistant/components/mqtt/discovery.py index 8d5f28278d9..564840f27b2 100644 --- a/homeassistant/components/mqtt/discovery.py +++ b/homeassistant/components/mqtt/discovery.py @@ -196,7 +196,7 @@ async def async_start(hass: HomeAssistantType, discovery_topic, hass_config, if TOPIC_BASE in payload: base = payload[TOPIC_BASE] for key, value in payload.items(): - if isinstance(value, str): + if isinstance(value, str) and value: if value[0] == TOPIC_BASE and key.endswith('_topic'): payload[key] = "{}{}".format(base, value[1:]) if value[-1] == TOPIC_BASE and key.endswith('_topic'):