From f02b5de7b59ed66aaf1f326bb45c0acb5528bf66 Mon Sep 17 00:00:00 2001 From: mib1185 Date: Sun, 23 Mar 2025 21:50:10 +0000 Subject: [PATCH] move action registration into platform setup --- homeassistant/components/synology_dsm/__init__.py | 14 ++++++++++---- .../components/synology_dsm/quality_scale.yaml | 4 +--- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/homeassistant/components/synology_dsm/__init__.py b/homeassistant/components/synology_dsm/__init__.py index 70c7e76a53a..cc90900d4b9 100644 --- a/homeassistant/components/synology_dsm/__init__.py +++ b/homeassistant/components/synology_dsm/__init__.py @@ -12,7 +12,8 @@ from synology_dsm.exceptions import SynologyDSMNotLoggedInException from homeassistant.const import CONF_MAC, CONF_SCAN_INTERVAL, CONF_VERIFY_SSL from homeassistant.core import HomeAssistant from homeassistant.exceptions import ConfigEntryNotReady -from homeassistant.helpers import device_registry as dr +from homeassistant.helpers import config_validation as cv, device_registry as dr +from homeassistant.helpers.typing import ConfigType from .common import SynoApi, raise_config_entry_auth_error from .const import ( @@ -36,9 +37,17 @@ from .coordinator import ( ) from .service import async_setup_services +CONFIG_SCHEMA = cv.config_entry_only_config_schema(DOMAIN) + _LOGGER = logging.getLogger(__name__) +async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool: + """Set up the Synology DSM services.""" + await async_setup_services(hass) + return True + + async def async_setup_entry(hass: HomeAssistant, entry: SynologyDSMConfigEntry) -> bool: """Set up Synology DSM sensors.""" @@ -89,9 +98,6 @@ async def async_setup_entry(hass: HomeAssistant, entry: SynologyDSMConfigEntry) details = EXCEPTION_UNKNOWN raise ConfigEntryNotReady(details) from err - # Services - await async_setup_services(hass) - # For SSDP compat if not entry.data.get(CONF_MAC): hass.config_entries.async_update_entry( diff --git a/homeassistant/components/synology_dsm/quality_scale.yaml b/homeassistant/components/synology_dsm/quality_scale.yaml index bc53e8eca74..e925ae71b6f 100644 --- a/homeassistant/components/synology_dsm/quality_scale.yaml +++ b/homeassistant/components/synology_dsm/quality_scale.yaml @@ -1,8 +1,6 @@ rules: # Bronze - action-setup: - status: todo - comment: services are still registered in entry setup + action-setup: done appropriate-polling: done brands: done common-modules: done