jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-19 03:07:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use SurePetcareEntity for surepetcare binary sensor (#56601)

Browse Source 
* Use SurePetcareEntity for surepetcare binary sensor

Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>

* tests

Signed-off-by: Daniel Hjelseth Høyer <github@dahoiv.net>
This commit is contained in:
Daniel Hjelseth Høyer 2021-09-25 11:17:55 +02:00 committed by GitHub
parent 5c1f55ffa4
commit f0de6dc21a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
homeassistant/components/surepetcare/binary_sensor.py
View File

@ -1,8 +1,6 @@
"""Support for Sure PetCare Flaps/Pets binary sensors.""" """Support for Sure PetCare Flaps/Pets binary sensors."""
from __future__ import annotations from __future__ import annotations
from abc import abstractmethod
import logging
from typing import cast from typing import cast
from surepy.entities import SurepyEntity from surepy.entities import SurepyEntity
@ -17,14 +15,10 @@ from homeassistant.components.binary_sensor import (
from homeassistant.config_entries import ConfigEntry from homeassistant.config_entries import ConfigEntry
from homeassistant.core import HomeAssistant, callback from homeassistant.core import HomeAssistant, callback
from homeassistant.helpers.entity_platform import AddEntitiesCallback from homeassistant.helpers.entity_platform import AddEntitiesCallback
from homeassistant.helpers.update_coordinator import (
CoordinatorEntity,
DataUpdateCoordinator,
)
from . import SurePetcareDataCoordinator
from .const import DOMAIN from .const import DOMAIN
from .entity import SurePetcareEntity
_LOGGER = logging.getLogger(__name__)
async def async_setup_entry( async def async_setup_entry(
@ -34,7 +28,7 @@ async def async_setup_entry(
entities: list[SurePetcareBinarySensor] = [] entities: list[SurePetcareBinarySensor] = []
coordinator: DataUpdateCoordinator = hass.data[DOMAIN][entry.entry_id] coordinator: SurePetcareDataCoordinator = hass.data[DOMAIN][entry.entry_id]
for surepy_entity in coordinator.data.values(): for surepy_entity in coordinator.data.values():
@ -54,41 +48,19 @@ async def async_setup_entry(
async_add_entities(entities) async_add_entities(entities)
class SurePetcareBinarySensor(CoordinatorEntity, BinarySensorEntity): class SurePetcareBinarySensor(SurePetcareEntity, BinarySensorEntity):
"""A binary sensor implementation for Sure Petcare Entities.""" """A binary sensor implementation for Sure Petcare Entities."""
def __init__( def __init__(
self, self,
_id: int, surepetcare_id: int,
coordinator: DataUpdateCoordinator, coordinator: SurePetcareDataCoordinator,
) -> None: ) -> None:
"""Initialize a Sure Petcare binary sensor.""" """Initialize a Sure Petcare binary sensor."""
super().__init__(coordinator) super().__init__(surepetcare_id, coordinator)
self._id = _id self._attr_name = self._device_name
self._attr_unique_id = self._device_id
surepy_entity: SurepyEntity = coordinator.data[_id]
# cover special case where a device has no name set
if surepy_entity.name:
name = surepy_entity.name
else:
name = f"Unnamed {surepy_entity.type.name.capitalize()}"
self._attr_name = f"{surepy_entity.type.name.capitalize()} {name.capitalize()}"
self._attr_unique_id = f"{surepy_entity.household_id}-{_id}"
self._update_attr(coordinator.data[_id])
@abstractmethod
@callback
def _update_attr(self, surepy_entity: SurepyEntity) -> None:
"""Update the state and attributes."""
@callback
def _handle_coordinator_update(self) -> None:
"""Get the latest data and update the state."""
self._update_attr(self.coordinator.data[self._id])
self.async_write_ha_state()
class Hub(SurePetcareBinarySensor): class Hub(SurePetcareBinarySensor):
@ -115,7 +87,6 @@ class Hub(SurePetcareBinarySensor):
} }
else: else:
self._attr_extra_state_attributes = {} self._attr_extra_state_attributes = {}
_LOGGER.debug("%s -> state: %s", self.name, state)
class Pet(SurePetcareBinarySensor): class Pet(SurePetcareBinarySensor):
@ -139,7 +110,6 @@ class Pet(SurePetcareBinarySensor):
} }
else: else:
self._attr_extra_state_attributes = {} self._attr_extra_state_attributes = {}
_LOGGER.debug("%s -> state: %s", self.name, state)
class DeviceConnectivity(SurePetcareBinarySensor): class DeviceConnectivity(SurePetcareBinarySensor):
@ -149,15 +119,13 @@ class DeviceConnectivity(SurePetcareBinarySensor):
def __init__( def __init__(
self, self,
_id: int, surepetcare_id: int,
coordinator: DataUpdateCoordinator, coordinator: SurePetcareDataCoordinator,
) -> None: ) -> None:
"""Initialize a Sure Petcare Device.""" """Initialize a Sure Petcare Device."""
super().__init__(_id, coordinator) super().__init__(surepetcare_id, coordinator)
self._attr_name = f"{self.name}_connectivity" self._attr_name = f"{self._device_name} Connectivity"
self._attr_unique_id = ( self._attr_unique_id = f"{self._device_id}-connectivity"
f"{self.coordinator.data[self._id].household_id}-{self._id}-connectivity"
)
@callback @callback
def _update_attr(self, surepy_entity: SurepyEntity) -> None: def _update_attr(self, surepy_entity: SurepyEntity) -> None:
@ -170,4 +138,3 @@ class DeviceConnectivity(SurePetcareBinarySensor):
} }
else: else:
self._attr_extra_state_attributes = {} self._attr_extra_state_attributes = {}
_LOGGER.debug("%s -> state: %s", self.name, state)

10
tests/components/surepetcare/test_binary_sensor.py
View File

@ -7,11 +7,11 @@ from homeassistant.setup import async_setup_component
from . import HOUSEHOLD_ID, HUB_ID, MOCK_CONFIG from . import HOUSEHOLD_ID, HUB_ID, MOCK_CONFIG
EXPECTED_ENTITY_IDS = { EXPECTED_ENTITY_IDS = {
"binary_sensor.pet_flap_pet_flap_connectivity": f"{HOUSEHOLD_ID}-13576-connectivity", "binary_sensor.pet_flap_connectivity": f"{HOUSEHOLD_ID}-13576-connectivity",
"binary_sensor.cat_flap_cat_flap_connectivity": f"{HOUSEHOLD_ID}-13579-connectivity", "binary_sensor.cat_flap_connectivity": f"{HOUSEHOLD_ID}-13579-connectivity",
"binary_sensor.feeder_feeder_connectivity": f"{HOUSEHOLD_ID}-12345-connectivity", "binary_sensor.feeder_connectivity": f"{HOUSEHOLD_ID}-12345-connectivity",
"binary_sensor.pet_pet": f"{HOUSEHOLD_ID}-24680", "binary_sensor.pet": f"{HOUSEHOLD_ID}-24680",
"binary_sensor.hub_hub": f"{HOUSEHOLD_ID}-{HUB_ID}", "binary_sensor.hub": f"{HOUSEHOLD_ID}-{HUB_ID}",
} }