jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-18 18:57:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Small cleanups to logbook statement generator (#90200)

Browse Source 
We should only convert the context id to binary if
its going to be used.

Avoid some intermediate vars that are no longer needed
This commit is contained in:
J. Nick Koston 2023-03-23 14:56:58 -10:00 committed by GitHub
parent a44d6f30c9
commit f1ec77b8e0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
homeassistant/components/logbook/queries/__init__.py
View File

@ -30,10 +30,10 @@ def statement_for_request(
"""Generate the logbook statement for a logbook request."""
start_day = dt_util.utc_to_timestamp(start_day_dt)
end_day = dt_util.utc_to_timestamp(end_day_dt)
context_id_bin = ulid_to_bytes_or_none(context_id)
# No entities: logbook sends everything for the timeframe
# limited by the context_id and the yaml configured filter
if not entity_ids and not device_ids:
context_id_bin = ulid_to_bytes_or_none(context_id)
states_entity_filter = (
filters.states_metadata_entity_filter() if filters else None
)
@ -54,34 +54,30 @@ def statement_for_request(
# entities and devices: logbook sends everything for the timeframe for the entities and devices
if entity_ids and device_ids:
json_quoted_entity_ids = [json_dumps(entity_id) for entity_id in entity_ids]
json_quoted_device_ids = [json_dumps(device_id) for device_id in device_ids]
return entities_devices_stmt(
start_day,
end_day,
event_types,
states_metadata_ids or [],
json_quoted_entity_ids,
json_quoted_device_ids,
[json_dumps(entity_id) for entity_id in entity_ids],
[json_dumps(device_id) for device_id in device_ids],
)
# entities: logbook sends everything for the timeframe for the entities
if entity_ids:
json_quoted_entity_ids = [json_dumps(entity_id) for entity_id in entity_ids]
return entities_stmt(
start_day,
end_day,
event_types,
states_metadata_ids or [],
json_quoted_entity_ids,
[json_dumps(entity_id) for entity_id in entity_ids],
)
# devices: logbook sends everything for the timeframe for the devices
assert device_ids is not None
json_quoted_device_ids = [json_dumps(device_id) for device_id in device_ids]
return devices_stmt(
start_day,
end_day,
event_types,
json_quoted_device_ids,
[json_dumps(device_id) for device_id in device_ids],
)