From f3684575442c26498a1b985c6d2eeb35411b35bf Mon Sep 17 00:00:00 2001 From: Joost Lekkerkerker Date: Wed, 6 Mar 2024 16:05:35 +0100 Subject: [PATCH] Add icon translations to Sonarr (#112233) --- homeassistant/components/sonarr/icons.json | 24 ++++++++++++++++++++++ homeassistant/components/sonarr/sensor.py | 6 ------ tests/components/sonarr/test_sensor.py | 7 ------- 3 files changed, 24 insertions(+), 13 deletions(-) create mode 100644 homeassistant/components/sonarr/icons.json diff --git a/homeassistant/components/sonarr/icons.json b/homeassistant/components/sonarr/icons.json new file mode 100644 index 00000000000..7980db52b29 --- /dev/null +++ b/homeassistant/components/sonarr/icons.json @@ -0,0 +1,24 @@ +{ + "entity": { + "sensor": { + "commands": { + "default": "mdi:code-braces" + }, + "diskspace": { + "default": "mdi:harddisk" + }, + "queue": { + "default": "mdi:download" + }, + "series": { + "default": "mdi:television" + }, + "upcoming": { + "default": "mdi:television" + }, + "wanted": { + "default": "mdi:television" + } + } + } +} diff --git a/homeassistant/components/sonarr/sensor.py b/homeassistant/components/sonarr/sensor.py index 5753d0d23ea..4aea2a73ede 100644 --- a/homeassistant/components/sonarr/sensor.py +++ b/homeassistant/components/sonarr/sensor.py @@ -89,7 +89,6 @@ SENSOR_TYPES: dict[str, SonarrSensorEntityDescription[Any]] = { "commands": SonarrSensorEntityDescription[list[Command]]( key="commands", translation_key="commands", - icon="mdi:code-braces", native_unit_of_measurement="Commands", entity_registry_enabled_default=False, value_fn=len, @@ -98,7 +97,6 @@ SENSOR_TYPES: dict[str, SonarrSensorEntityDescription[Any]] = { "diskspace": SonarrSensorEntityDescription[list[Diskspace]]( key="diskspace", translation_key="diskspace", - icon="mdi:harddisk", native_unit_of_measurement=UnitOfInformation.GIGABYTES, device_class=SensorDeviceClass.DATA_SIZE, entity_registry_enabled_default=False, @@ -108,7 +106,6 @@ SENSOR_TYPES: dict[str, SonarrSensorEntityDescription[Any]] = { "queue": SonarrSensorEntityDescription[SonarrQueue]( key="queue", translation_key="queue", - icon="mdi:download", native_unit_of_measurement="Episodes", entity_registry_enabled_default=False, value_fn=lambda data: data.totalRecords, @@ -117,7 +114,6 @@ SENSOR_TYPES: dict[str, SonarrSensorEntityDescription[Any]] = { "series": SonarrSensorEntityDescription[list[SonarrSeries]]( key="series", translation_key="series", - icon="mdi:television", native_unit_of_measurement="Series", entity_registry_enabled_default=False, value_fn=len, @@ -131,7 +127,6 @@ SENSOR_TYPES: dict[str, SonarrSensorEntityDescription[Any]] = { "upcoming": SonarrSensorEntityDescription[list[SonarrCalendar]]( key="upcoming", translation_key="upcoming", - icon="mdi:television", native_unit_of_measurement="Episodes", value_fn=len, attributes_fn=lambda data: { @@ -141,7 +136,6 @@ SENSOR_TYPES: dict[str, SonarrSensorEntityDescription[Any]] = { "wanted": SonarrSensorEntityDescription[SonarrWantedMissing]( key="wanted", translation_key="wanted", - icon="mdi:television", native_unit_of_measurement="Episodes", entity_registry_enabled_default=False, value_fn=lambda data: data.totalRecords, diff --git a/tests/components/sonarr/test_sensor.py b/tests/components/sonarr/test_sensor.py index e44081f94bf..eccc535ff66 100644 --- a/tests/components/sonarr/test_sensor.py +++ b/tests/components/sonarr/test_sensor.py @@ -8,7 +8,6 @@ import pytest from homeassistant.components.sensor import DOMAIN as SENSOR_DOMAIN from homeassistant.const import ( - ATTR_ICON, ATTR_UNIT_OF_MEASUREMENT, STATE_UNAVAILABLE, UnitOfInformation, @@ -50,41 +49,35 @@ async def test_sensors( state = hass.states.get("sensor.sonarr_commands") assert state - assert state.attributes.get(ATTR_ICON) == "mdi:code-braces" assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == "Commands" assert state.state == "2" state = hass.states.get("sensor.sonarr_disk_space") assert state - assert state.attributes.get(ATTR_ICON) == "mdi:harddisk" assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == UnitOfInformation.GIGABYTES assert state.attributes.get("C:\\") == "263.10/465.42GB (56.53%)" assert state.state == "263.10" state = hass.states.get("sensor.sonarr_queue") assert state - assert state.attributes.get(ATTR_ICON) == "mdi:download" assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == "Episodes" assert state.attributes.get("The Andy Griffith Show S01E01") == "100.00%" assert state.state == "1" state = hass.states.get("sensor.sonarr_shows") assert state - assert state.attributes.get(ATTR_ICON) == "mdi:television" assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == "Series" assert state.attributes.get("The Andy Griffith Show") == "0/0 Episodes" assert state.state == "1" state = hass.states.get("sensor.sonarr_upcoming") assert state - assert state.attributes.get(ATTR_ICON) == "mdi:television" assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == "Episodes" assert state.attributes.get("Bob's Burgers") == "S04E11" assert state.state == "1" state = hass.states.get("sensor.sonarr_wanted") assert state - assert state.attributes.get(ATTR_ICON) == "mdi:television" assert state.attributes.get(ATTR_UNIT_OF_MEASUREMENT) == "Episodes" assert state.attributes.get("Bob's Burgers S04E11") == "2014-01-26T17:30:00-08:00" assert (