Do not warn for weak referenced entities (#43848)

This commit is contained in:
Paulus Schoutsen
2020-12-02 11:18:08 +01:00
committed by GitHub
parent 648f9e100d
commit f3bb243b1d
2 changed files with 34 additions and 24 deletions

View File

@@ -248,7 +248,7 @@ class TestComponentsCore(unittest.TestCase):
assert not mock_stop.called
async def test_turn_on_to_not_block_for_domains_without_service(hass):
async def test_turn_on_skips_domains_without_service(hass, caplog):
"""Test if turn_on is blocking domain with no service."""
await async_setup_component(hass, "homeassistant", {})
async_mock_service(hass, "light", SERVICE_TURN_ON)
@@ -261,7 +261,7 @@ async def test_turn_on_to_not_block_for_domains_without_service(hass):
service_call = ha.ServiceCall(
"homeassistant",
"turn_on",
{"entity_id": ["light.test", "sensor.bla", "light.bla"]},
{"entity_id": ["light.test", "sensor.bla", "binary_sensor.blub", "light.bla"]},
)
service = hass.services._services["homeassistant"]["turn_on"]
@@ -271,18 +271,19 @@ async def test_turn_on_to_not_block_for_domains_without_service(hass):
) as mock_call:
await service.job.target(service_call)
assert mock_call.call_count == 2
assert mock_call.call_count == 1
assert mock_call.call_args_list[0][0] == (
"light",
"turn_on",
{"entity_id": ["light.bla", "light.test"]},
True,
)
assert mock_call.call_args_list[1][0] == (
"sensor",
"turn_on",
{"entity_id": ["sensor.bla"]},
False,
assert mock_call.call_args_list[0][1] == {
"blocking": True,
"context": service_call.context,
}
assert (
"The service homeassistant.turn_on does not support entities binary_sensor.blub, sensor.bla"
in caplog.text
)
@@ -381,6 +382,6 @@ async def test_not_allowing_recursion(hass, caplog):
blocking=True,
)
assert (
f"Called service homeassistant.{service} with invalid entity IDs homeassistant.light"
f"Called service homeassistant.{service} with invalid entities homeassistant.light"
in caplog.text
), service