Rewrite alert test to pytest (#41102)

* Rewrite alert test to pytest

* Rewrite alert test to pytest. Add mock_notifier fixture
This commit is contained in:
Alexander Pitkin 2020-10-20 00:26:40 +03:00 committed by GitHub
parent b8417a2ce2
commit f5f4570a29
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1,7 +1,8 @@
"""The tests for the Alert component."""
# pylint: disable=protected-access
from copy import deepcopy
import unittest
import pytest
import homeassistant.components.alert as alert
from homeassistant.components.alert import DOMAIN
@ -19,9 +20,7 @@ from homeassistant.const import (
STATE_ON,
)
from homeassistant.core import callback
from homeassistant.setup import setup_component
from tests.common import get_test_home_assistant
from homeassistant.setup import async_setup_component
NAME = "alert_test"
DONE_MESSAGE = "alert_gone"
@ -63,14 +62,6 @@ TEST_NOACK = [
ENTITY_ID = f"{alert.DOMAIN}.{NAME}"
def turn_on(hass, entity_id):
"""Reset the alert.
This is a legacy helper method. Do not use it for new tests.
"""
hass.add_job(async_turn_on, hass, entity_id)
@callback
def async_turn_on(hass, entity_id):
"""Async reset the alert.
@ -81,14 +72,6 @@ def async_turn_on(hass, entity_id):
hass.async_create_task(hass.services.async_call(DOMAIN, SERVICE_TURN_ON, data))
def turn_off(hass, entity_id):
"""Acknowledge alert.
This is a legacy helper method. Do not use it for new tests.
"""
hass.add_job(async_turn_off, hass, entity_id)
@callback
def async_turn_off(hass, entity_id):
"""Async acknowledge the alert.
@ -99,14 +82,6 @@ def async_turn_off(hass, entity_id):
hass.async_create_task(hass.services.async_call(DOMAIN, SERVICE_TURN_OFF, data))
def toggle(hass, entity_id):
"""Toggle acknowledgment of alert.
This is a legacy helper method. Do not use it for new tests.
"""
hass.add_job(async_toggle, hass, entity_id)
@callback
def async_toggle(hass, entity_id):
"""Async toggle acknowledgment of alert.
@ -117,17 +92,9 @@ def async_toggle(hass, entity_id):
hass.async_create_task(hass.services.async_call(DOMAIN, SERVICE_TOGGLE, data))
# pylint: disable=invalid-name
class TestAlert(unittest.TestCase):
"""Test the alert module."""
def setUp(self):
"""Set up things to be run when tests are started."""
self.hass = get_test_home_assistant()
self._setup_notify()
self.addCleanup(self.hass.stop)
def _setup_notify(self):
@pytest.fixture
def mock_notifier(hass):
"""Mock for notifier."""
events = []
@callback
@ -135,74 +102,81 @@ class TestAlert(unittest.TestCase):
"""Add recorded event to set."""
events.append(event)
self.hass.services.register(notify.DOMAIN, NOTIFIER, record_event)
hass.services.async_register(notify.DOMAIN, NOTIFIER, record_event)
return events
def test_is_on(self):
async def test_is_on(hass):
"""Test is_on method."""
self.hass.states.set(ENTITY_ID, STATE_ON)
self.hass.block_till_done()
assert alert.is_on(self.hass, ENTITY_ID)
self.hass.states.set(ENTITY_ID, STATE_OFF)
self.hass.block_till_done()
assert not alert.is_on(self.hass, ENTITY_ID)
hass.states.async_set(ENTITY_ID, STATE_ON)
await hass.async_block_till_done()
assert alert.is_on(hass, ENTITY_ID)
hass.states.async_set(ENTITY_ID, STATE_OFF)
await hass.async_block_till_done()
assert not alert.is_on(hass, ENTITY_ID)
def test_setup(self):
async def test_setup(hass):
"""Test setup method."""
assert setup_component(self.hass, alert.DOMAIN, TEST_CONFIG)
assert STATE_IDLE == self.hass.states.get(ENTITY_ID).state
assert await async_setup_component(hass, alert.DOMAIN, TEST_CONFIG)
assert STATE_IDLE == hass.states.get(ENTITY_ID).state
def test_fire(self):
async def test_fire(hass, mock_notifier):
"""Test the alert firing."""
assert setup_component(self.hass, alert.DOMAIN, TEST_CONFIG)
self.hass.states.set("sensor.test", STATE_ON)
self.hass.block_till_done()
assert STATE_ON == self.hass.states.get(ENTITY_ID).state
assert await async_setup_component(hass, alert.DOMAIN, TEST_CONFIG)
hass.states.async_set("sensor.test", STATE_ON)
await hass.async_block_till_done()
assert STATE_ON == hass.states.get(ENTITY_ID).state
def test_silence(self):
async def test_silence(hass, mock_notifier):
"""Test silencing the alert."""
assert setup_component(self.hass, alert.DOMAIN, TEST_CONFIG)
self.hass.states.set("sensor.test", STATE_ON)
self.hass.block_till_done()
turn_off(self.hass, ENTITY_ID)
self.hass.block_till_done()
assert STATE_OFF == self.hass.states.get(ENTITY_ID).state
assert await async_setup_component(hass, alert.DOMAIN, TEST_CONFIG)
hass.states.async_set("sensor.test", STATE_ON)
await hass.async_block_till_done()
async_turn_off(hass, ENTITY_ID)
await hass.async_block_till_done()
assert STATE_OFF == hass.states.get(ENTITY_ID).state
# alert should not be silenced on next fire
self.hass.states.set("sensor.test", STATE_OFF)
self.hass.block_till_done()
assert STATE_IDLE == self.hass.states.get(ENTITY_ID).state
self.hass.states.set("sensor.test", STATE_ON)
self.hass.block_till_done()
assert STATE_ON == self.hass.states.get(ENTITY_ID).state
hass.states.async_set("sensor.test", STATE_OFF)
await hass.async_block_till_done()
assert STATE_IDLE == hass.states.get(ENTITY_ID).state
hass.states.async_set("sensor.test", STATE_ON)
await hass.async_block_till_done()
assert STATE_ON == hass.states.get(ENTITY_ID).state
def test_reset(self):
async def test_reset(hass, mock_notifier):
"""Test resetting the alert."""
assert setup_component(self.hass, alert.DOMAIN, TEST_CONFIG)
self.hass.states.set("sensor.test", STATE_ON)
self.hass.block_till_done()
turn_off(self.hass, ENTITY_ID)
self.hass.block_till_done()
assert STATE_OFF == self.hass.states.get(ENTITY_ID).state
turn_on(self.hass, ENTITY_ID)
self.hass.block_till_done()
assert STATE_ON == self.hass.states.get(ENTITY_ID).state
assert await async_setup_component(hass, alert.DOMAIN, TEST_CONFIG)
hass.states.async_set("sensor.test", STATE_ON)
await hass.async_block_till_done()
async_turn_off(hass, ENTITY_ID)
await hass.async_block_till_done()
assert STATE_OFF == hass.states.get(ENTITY_ID).state
async_turn_on(hass, ENTITY_ID)
await hass.async_block_till_done()
assert STATE_ON == hass.states.get(ENTITY_ID).state
def test_toggle(self):
async def test_toggle(hass, mock_notifier):
"""Test toggling alert."""
assert setup_component(self.hass, alert.DOMAIN, TEST_CONFIG)
self.hass.states.set("sensor.test", STATE_ON)
self.hass.block_till_done()
assert STATE_ON == self.hass.states.get(ENTITY_ID).state
toggle(self.hass, ENTITY_ID)
self.hass.block_till_done()
assert STATE_OFF == self.hass.states.get(ENTITY_ID).state
toggle(self.hass, ENTITY_ID)
self.hass.block_till_done()
assert STATE_ON == self.hass.states.get(ENTITY_ID).state
assert await async_setup_component(hass, alert.DOMAIN, TEST_CONFIG)
hass.states.async_set("sensor.test", STATE_ON)
await hass.async_block_till_done()
assert STATE_ON == hass.states.get(ENTITY_ID).state
async_toggle(hass, ENTITY_ID)
await hass.async_block_till_done()
assert STATE_OFF == hass.states.get(ENTITY_ID).state
async_toggle(hass, ENTITY_ID)
await hass.async_block_till_done()
assert STATE_ON == hass.states.get(ENTITY_ID).state
def test_notification_no_done_message(self):
async def test_notification_no_done_message(hass):
"""Test notifications."""
events = []
config = deepcopy(TEST_CONFIG)
@ -213,20 +187,21 @@ class TestAlert(unittest.TestCase):
"""Add recorded event to set."""
events.append(event)
self.hass.services.register(notify.DOMAIN, NOTIFIER, record_event)
hass.services.async_register(notify.DOMAIN, NOTIFIER, record_event)
assert setup_component(self.hass, alert.DOMAIN, config)
assert await async_setup_component(hass, alert.DOMAIN, config)
assert len(events) == 0
self.hass.states.set("sensor.test", STATE_ON)
self.hass.block_till_done()
hass.states.async_set("sensor.test", STATE_ON)
await hass.async_block_till_done()
assert len(events) == 1
self.hass.states.set("sensor.test", STATE_OFF)
self.hass.block_till_done()
hass.states.async_set("sensor.test", STATE_OFF)
await hass.async_block_till_done()
assert len(events) == 1
def test_notification(self):
async def test_notification(hass):
"""Test notifications."""
events = []
@ -235,90 +210,86 @@ class TestAlert(unittest.TestCase):
"""Add recorded event to set."""
events.append(event)
self.hass.services.register(notify.DOMAIN, NOTIFIER, record_event)
hass.services.async_register(notify.DOMAIN, NOTIFIER, record_event)
assert setup_component(self.hass, alert.DOMAIN, TEST_CONFIG)
assert await async_setup_component(hass, alert.DOMAIN, TEST_CONFIG)
assert len(events) == 0
self.hass.states.set("sensor.test", STATE_ON)
self.hass.block_till_done()
hass.states.async_set("sensor.test", STATE_ON)
await hass.async_block_till_done()
assert len(events) == 1
self.hass.states.set("sensor.test", STATE_OFF)
self.hass.block_till_done()
hass.states.async_set("sensor.test", STATE_OFF)
await hass.async_block_till_done()
assert len(events) == 2
def test_sending_non_templated_notification(self):
async def test_sending_non_templated_notification(hass, mock_notifier):
"""Test notifications."""
events = self._setup_notify()
assert await async_setup_component(hass, alert.DOMAIN, TEST_CONFIG)
assert setup_component(self.hass, alert.DOMAIN, TEST_CONFIG)
hass.states.async_set(TEST_ENTITY, STATE_ON)
await hass.async_block_till_done()
assert len(mock_notifier) == 1
last_event = mock_notifier[-1]
assert last_event.data[notify.ATTR_MESSAGE] == NAME
self.hass.states.set(TEST_ENTITY, STATE_ON)
self.hass.block_till_done()
self.assertEqual(1, len(events))
last_event = events[-1]
self.assertEqual(last_event.data[notify.ATTR_MESSAGE], NAME)
def test_sending_templated_notification(self):
async def test_sending_templated_notification(hass, mock_notifier):
"""Test templated notification."""
events = self._setup_notify()
config = deepcopy(TEST_CONFIG)
config[alert.DOMAIN][NAME][alert.CONF_ALERT_MESSAGE] = TEMPLATE
assert setup_component(self.hass, alert.DOMAIN, config)
assert await async_setup_component(hass, alert.DOMAIN, config)
self.hass.states.set(TEST_ENTITY, STATE_ON)
self.hass.block_till_done()
self.assertEqual(1, len(events))
last_event = events[-1]
self.assertEqual(last_event.data[notify.ATTR_MESSAGE], TEST_ENTITY)
hass.states.async_set(TEST_ENTITY, STATE_ON)
await hass.async_block_till_done()
assert len(mock_notifier) == 1
last_event = mock_notifier[-1]
assert last_event.data[notify.ATTR_MESSAGE] == TEST_ENTITY
def test_sending_templated_done_notification(self):
async def test_sending_templated_done_notification(hass, mock_notifier):
"""Test templated notification."""
events = self._setup_notify()
config = deepcopy(TEST_CONFIG)
config[alert.DOMAIN][NAME][alert.CONF_DONE_MESSAGE] = TEMPLATE
assert setup_component(self.hass, alert.DOMAIN, config)
assert await async_setup_component(hass, alert.DOMAIN, config)
self.hass.states.set(TEST_ENTITY, STATE_ON)
self.hass.block_till_done()
self.hass.states.set(TEST_ENTITY, STATE_OFF)
self.hass.block_till_done()
self.assertEqual(2, len(events))
last_event = events[-1]
self.assertEqual(last_event.data[notify.ATTR_MESSAGE], TEST_ENTITY)
hass.states.async_set(TEST_ENTITY, STATE_ON)
await hass.async_block_till_done()
hass.states.async_set(TEST_ENTITY, STATE_OFF)
await hass.async_block_till_done()
assert len(mock_notifier) == 2
last_event = mock_notifier[-1]
assert last_event.data[notify.ATTR_MESSAGE] == TEST_ENTITY
def test_sending_titled_notification(self):
async def test_sending_titled_notification(hass, mock_notifier):
"""Test notifications."""
events = self._setup_notify()
config = deepcopy(TEST_CONFIG)
config[alert.DOMAIN][NAME][alert.CONF_TITLE] = TITLE
assert setup_component(self.hass, alert.DOMAIN, config)
assert await async_setup_component(hass, alert.DOMAIN, config)
self.hass.states.set(TEST_ENTITY, STATE_ON)
self.hass.block_till_done()
self.assertEqual(1, len(events))
last_event = events[-1]
self.assertEqual(last_event.data[notify.ATTR_TITLE], TEST_TITLE)
hass.states.async_set(TEST_ENTITY, STATE_ON)
await hass.async_block_till_done()
assert len(mock_notifier) == 1
last_event = mock_notifier[-1]
assert last_event.data[notify.ATTR_TITLE] == TEST_TITLE
def test_sending_data_notification(self):
async def test_sending_data_notification(hass, mock_notifier):
"""Test notifications."""
events = self._setup_notify()
config = deepcopy(TEST_CONFIG)
config[alert.DOMAIN][NAME][alert.CONF_DATA] = TEST_DATA
assert setup_component(self.hass, alert.DOMAIN, config)
assert await async_setup_component(hass, alert.DOMAIN, config)
self.hass.states.set(TEST_ENTITY, STATE_ON)
self.hass.block_till_done()
self.assertEqual(1, len(events))
last_event = events[-1]
self.assertEqual(last_event.data[notify.ATTR_DATA], TEST_DATA)
hass.states.async_set(TEST_ENTITY, STATE_ON)
await hass.async_block_till_done()
assert len(mock_notifier) == 1
last_event = mock_notifier[-1]
assert last_event.data[notify.ATTR_DATA] == TEST_DATA
def test_skipfirst(self):
async def test_skipfirst(hass):
"""Test skipping first notification."""
config = deepcopy(TEST_CONFIG)
config[alert.DOMAIN][NAME][alert.CONF_SKIP_FIRST] = True
@ -329,27 +300,29 @@ class TestAlert(unittest.TestCase):
"""Add recorded event to set."""
events.append(event)
self.hass.services.register(notify.DOMAIN, NOTIFIER, record_event)
hass.services.async_register(notify.DOMAIN, NOTIFIER, record_event)
assert setup_component(self.hass, alert.DOMAIN, config)
assert await async_setup_component(hass, alert.DOMAIN, config)
assert len(events) == 0
self.hass.states.set("sensor.test", STATE_ON)
self.hass.block_till_done()
hass.states.async_set("sensor.test", STATE_ON)
await hass.async_block_till_done()
assert len(events) == 0
def test_noack(self):
async def test_noack(hass):
"""Test no ack feature."""
entity = alert.Alert(self.hass, *TEST_NOACK)
self.hass.add_job(entity.begin_alerting)
self.hass.block_till_done()
entity = alert.Alert(hass, *TEST_NOACK)
hass.async_add_job(entity.begin_alerting)
await hass.async_block_till_done()
def test_done_message_state_tracker_reset_on_cancel(self):
async def test_done_message_state_tracker_reset_on_cancel(hass):
"""Test that the done message is reset when canceled."""
entity = alert.Alert(self.hass, *TEST_NOACK)
entity = alert.Alert(hass, *TEST_NOACK)
entity._cancel = lambda *args: None
assert entity._send_done_message is False
entity._send_done_message = True
self.hass.add_job(entity.end_alerting)
self.hass.block_till_done()
hass.async_add_job(entity.end_alerting)
await hass.async_block_till_done()
assert entity._send_done_message is False