From f6f6bf8953151c63d7e99d11294d0734b032aa20 Mon Sep 17 00:00:00 2001 From: Ben Thomas Date: Tue, 28 May 2024 04:57:21 +0100 Subject: [PATCH] SharkIQ Fix for vacuums without room support (#118209) * Fix SharkIQ vacuums without room support crashing the SharkIQ integration * Fix ruff format * Fix SharkIQ tests to account for robot identifier and second expected value --- homeassistant/components/sharkiq/vacuum.py | 5 ++++- tests/components/sharkiq/const.py | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/homeassistant/components/sharkiq/vacuum.py b/homeassistant/components/sharkiq/vacuum.py index 8401feabcd8..8f0547980c3 100644 --- a/homeassistant/components/sharkiq/vacuum.py +++ b/homeassistant/components/sharkiq/vacuum.py @@ -263,7 +263,10 @@ class SharkVacuumEntity(CoordinatorEntity[SharkIqUpdateCoordinator], StateVacuum @property def available_rooms(self) -> list | None: """Return a list of rooms available to clean.""" - return self.sharkiq.get_room_list() + room_list = self.sharkiq.get_property_value(Properties.ROBOT_ROOM_LIST) + if room_list: + return room_list.split(":")[1:] + return [] @property def extra_state_attributes(self) -> dict[str, Any]: diff --git a/tests/components/sharkiq/const.py b/tests/components/sharkiq/const.py index e8d920e7763..5e61f611505 100644 --- a/tests/components/sharkiq/const.py +++ b/tests/components/sharkiq/const.py @@ -68,7 +68,7 @@ SHARK_PROPERTIES_DICT = { "Robot_Room_List": { "base_type": "string", "read_only": True, - "value": "Kitchen", + "value": "AY001MRT1:Kitchen:Living Room", }, }