jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-28 15:47:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent types-*/setuptools/wheel runtime requirements in dependencies (#145381)

Browse Source 
Prevent setuptools/wheel runtime requirements in dependencies
This commit is contained in:
epenet 2025-05-21 16:17:24 +02:00 committed by GitHub
parent dd00d0daad
commit f76165e761
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 34 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
script/hassfest/requirements.py
View File

@ -28,6 +28,25 @@ PACKAGE_REGEX = re.compile(
PIP_REGEX = re.compile(r"^(--.+\s)?([-_\.\w\d]+.*(?:==|>=|<=|~=|!=|<|>|===)?.*$)") PIP_REGEX = re.compile(r"^(--.+\s)?([-_\.\w\d]+.*(?:==|>=|<=|~=|!=|<|>|===)?.*$)")
PIP_VERSION_RANGE_SEPARATOR = re.compile(r"^(==|>=|<=|~=|!=|<|>|===)?(.*)$") PIP_VERSION_RANGE_SEPARATOR = re.compile(r"^(==|>=|<=|~=|!=|<|>|===)?(.*)$")
FORBIDDEN_PACKAGES = {"setuptools", "wheel"}
FORBIDDEN_PACKAGE_EXCEPTIONS = {
# Direct dependencies
"fitbit", # setuptools (fitbit)
"habitipy", # setuptools (habitica)
"influxdb-client", # setuptools (influxdb)
"microbeespy", # setuptools (microbees)
"pyefergy", # types-pytz (efergy)
"python-mystrom", # setuptools (mystrom)
# Transitive dependencies
"arrow", # types-python-dateutil (opower)
"asyncio-dgram", # setuptools (guardian / keba / minecraft_server)
"colorzero", # setuptools (remote_rpi_gpio / zha)
"incremental", # setuptools (azure_devops / lyric / ovo_energy / system_bridge)
"pbr", # setuptools (cmus / concord232 / mochad / nx584 / opnsense)
"pycountry-convert", # wheel (ecovacs)
"unasync", # setuptools (hive / osoenergy)
}
def validate(integrations: dict[str, Integration], config: Config) -> None: def validate(integrations: dict[str, Integration], config: Config) -> None:
"""Handle requirements for integrations.""" """Handle requirements for integrations."""
@ -204,7 +223,21 @@ def get_requirements(integration: Integration, packages: set[str]) -> set[str]:
) )
continue continue
to_check.extend(item["dependencies"]) dependencies: set[str] = item["dependencies"]
for pkg in dependencies:
if pkg.startswith("types-") or pkg in FORBIDDEN_PACKAGES:
if package in FORBIDDEN_PACKAGE_EXCEPTIONS:
integration.add_warning(
"requirements",
f"Package {pkg} should not be a runtime dependency in {package}",
)
else:
integration.add_error(
"requirements",
f"Package {pkg} should not be a runtime dependency in {package}",
)
to_check.extend(dependencies)
return all_requirements return all_requirements