jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-15 17:27:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove deprecated Renault service (#86070)

Browse Source
This commit is contained in:
epenet 2023-01-17 10:28:33 +01:00 committed by GitHub
parent 551e098177
commit f7d69ee325
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
homeassistant/components/renault/services.py
View File

@ -63,13 +63,7 @@ SERVICE_CHARGE_SET_SCHEDULES_SCHEMA = SERVICE_VEHICLE_SCHEMA.extend(
SERVICE_AC_CANCEL = "ac_cancel"
SERVICE_AC_START = "ac_start"
SERVICE_CHARGE_SET_SCHEDULES = "charge_set_schedules"
SERVICE_CHARGE_START = "charge_start"
SERVICES = [
SERVICE_AC_CANCEL,
SERVICE_AC_START,
SERVICE_CHARGE_SET_SCHEDULES,
SERVICE_CHARGE_START,
]
SERVICES = [SERVICE_AC_CANCEL, SERVICE_AC_START, SERVICE_CHARGE_SET_SCHEDULES]
def setup_services(hass: HomeAssistant) -> None:
@ -110,22 +104,6 @@ def setup_services(hass: HomeAssistant) -> None:
"It may take some time before these changes are reflected in your vehicle"
)
async def charge_start(service_call: ServiceCall) -> None:
"""Start charge."""
# The Renault start charge service has been replaced by a
# dedicated button entity and marked as deprecated
LOGGER.warning(
"The 'renault.charge_start' service is deprecated and "
"replaced by a dedicated start charge button entity; please "
"use that entity to start the charge instead"
)
proxy = get_vehicle_proxy(service_call.data)
LOGGER.debug("Charge start attempt")
result = await proxy.vehicle.set_charge_start()
LOGGER.debug("Charge start result: %s", result)
def get_vehicle_proxy(service_call_data: Mapping) -> RenaultVehicleProxy:
"""Get vehicle from service_call data."""
device_registry = dr.async_get(hass)
@ -159,12 +137,6 @@ def setup_services(hass: HomeAssistant) -> None:
charge_set_schedules,
schema=SERVICE_CHARGE_SET_SCHEDULES_SCHEMA,
)
hass.services.async_register(
DOMAIN,
SERVICE_CHARGE_START,
charge_start,
schema=SERVICE_VEHICLE_SCHEMA,
)
def unload_services(hass: HomeAssistant) -> None:

28
tests/components/renault/test_services.py
View File

@ -16,7 +16,6 @@ from homeassistant.components.renault.services import (
SERVICE_AC_CANCEL,
SERVICE_AC_START,
SERVICE_CHARGE_SET_SCHEDULES,
SERVICE_CHARGE_START,
SERVICES,
)
from homeassistant.config_entries import ConfigEntry
@ -242,33 +241,6 @@ async def test_service_set_charge_schedule_multi(
assert mock_action.mock_calls[0][1] == (mock_call_data,)
async def test_service_set_charge_start(
hass: HomeAssistant, config_entry: ConfigEntry, caplog: pytest.LogCaptureFixture
) -> None:
"""Test that service invokes renault_api with correct data."""
await hass.config_entries.async_setup(config_entry.entry_id)
await hass.async_block_till_done()
data = {
ATTR_VEHICLE: get_device_id(hass),
}
with patch(
"renault_api.renault_vehicle.RenaultVehicle.set_charge_start",
return_value=(
schemas.KamereonVehicleHvacStartActionDataSchema.loads(
load_fixture("renault/action.set_charge_start.json")
)
),
) as mock_action:
await hass.services.async_call(
DOMAIN, SERVICE_CHARGE_START, service_data=data, blocking=True
)
assert len(mock_action.mock_calls) == 1
assert mock_action.mock_calls[0][1] == ()
assert f"'{DOMAIN}.{SERVICE_CHARGE_START}' service is deprecated" in caplog.text
async def test_service_invalid_device_id(
hass: HomeAssistant, config_entry: ConfigEntry
) -> None: